Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/#review144620 --- Ship it! Master (b912e17) is green with this patch.

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-03 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/ --- (Updated Aug. 3, 2016, 3:34 p.m.) Review request for Aurora, Jie Yu, Maxim

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-02 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/#review144560 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 2, 2016, 8:55

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-02 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/#review144534 --- Fix it, then Ship it!

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-02 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/#review144528 --- Ship it! Master (b912e17) is green with this patch.

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-02 Thread Joshua Cohen
> On Aug. 1, 2016, 7:05 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, lines 200-209 > > > > > > Those two calls have the implicit assumptions: > > > > * the role

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-02 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/ --- (Updated Aug. 2, 2016, 8:55 p.m.) Review request for Aurora, Jie Yu, Maxim

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-01 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/#review144324 --- Looks good to me in general. A couple of general remarks below.

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-01 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/#review144357 --- Ship it! Master (b912e17) is green with this patch.

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-08-01 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/ --- (Updated Aug. 1, 2016, 5:22 p.m.) Review request for Aurora, Jie Yu, Maxim

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-07-26 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/ --- (Updated July 26, 2016, 4:57 p.m.) Review request for Aurora, Jie Yu, Maxim

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-05-27 Thread Joshua Cohen
> On May 26, 2016, 12:17 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/executor/common/sandbox.py, lines 208-230 > > > > > > Seeing this spelled out, I feel like we should not have such code in > >

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-05-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/#review134955 --- Thanks for looking into this difficult but important problem.

Re: Review Request 47853: Isolate the executor's filesystem from the task's.

2016-05-25 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/#review134845 --- Ship it! Master (d521dcd) is green with this patch.

Review Request 47853: Isolate the executor's filesystem from the task's.

2016-05-25 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47853/ --- Review request for Aurora, Maxim Khutornenko and Stephan Erb. Repository: