Re: Review Request 49899: Upgrade to gradle 2.14.

2016-07-11 Thread Aurora ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49899/#review141715
---


Ship it!




Master (c41420f) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On July 11, 2016, 3:46 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49899/
> ---
> 
> (Updated July 11, 2016, 3:46 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings Gradle to 2.14, release notes here:
>   https://docs.gradle.org/2.13/release-notes
>   https://docs.gradle.org/2.14/release-notes
> 
> Since the Gradle daemon is no longer incubating it is enabled by
> default for the project and the Vagrant provisioning is simplified
> as a result.
> 
>  buildSrc/gradle.properties| 2 +-
>  examples/vagrant/provision-dev-cluster.sh | 9 -
>  gradle.properties | 2 ++
>  gradle/wrapper/gradle-wrapper.properties  | 2 +-
>  4 files changed, 4 insertions(+), 11 deletions(-)
> 
> 
> Diffs
> -
> 
>   buildSrc/gradle.properties 075726fbd8ba44479c7571e3df80fc3169b5422c 
>   examples/vagrant/provision-dev-cluster.sh 
> 2c78677c7c81ce7ffe36c8a2400ad23b4dce677b 
>   gradle.properties PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.properties 
> 8508237ea3fb0c69ae1d5d245bf9f0c4c42c0b2c 
> 
> Diff: https://reviews.apache.org/r/49899/diff/
> 
> 
> Testing
> ---
> 
> Locally green and Gradle daemon observed used in e2e:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> I also built a fresh IDEA project with `./gradlew idea` and
> that project built green from within IDEA.
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Re: Review Request 49899: Upgrade to gradle 2.14.

2016-07-11 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49899/#review141711
---


Ship it!




Ship It!

- Maxim Khutornenko


On July 11, 2016, 3:46 p.m., John Sirois wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49899/
> ---
> 
> (Updated July 11, 2016, 3:46 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> ---
> 
> This brings Gradle to 2.14, release notes here:
>   https://docs.gradle.org/2.13/release-notes
>   https://docs.gradle.org/2.14/release-notes
> 
> Since the Gradle daemon is no longer incubating it is enabled by
> default for the project and the Vagrant provisioning is simplified
> as a result.
> 
>  buildSrc/gradle.properties| 2 +-
>  examples/vagrant/provision-dev-cluster.sh | 9 -
>  gradle.properties | 2 ++
>  gradle/wrapper/gradle-wrapper.properties  | 2 +-
>  4 files changed, 4 insertions(+), 11 deletions(-)
> 
> 
> Diffs
> -
> 
>   buildSrc/gradle.properties 075726fbd8ba44479c7571e3df80fc3169b5422c 
>   examples/vagrant/provision-dev-cluster.sh 
> 2c78677c7c81ce7ffe36c8a2400ad23b4dce677b 
>   gradle.properties PRE-CREATION 
>   gradle/wrapper/gradle-wrapper.properties 
> 8508237ea3fb0c69ae1d5d245bf9f0c4c42c0b2c 
> 
> Diff: https://reviews.apache.org/r/49899/diff/
> 
> 
> Testing
> ---
> 
> Locally green and Gradle daemon observed used in e2e:
> ```
> ./build-support/jenkins/build.sh
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> I also built a fresh IDEA project with `./gradlew idea` and
> that project built green from within IDEA.
> 
> 
> Thanks,
> 
> John Sirois
> 
>



Review Request 49899: Upgrade to gradle 2.14.

2016-07-11 Thread John Sirois

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49899/
---

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
---

This brings Gradle to 2.14, release notes here:
  https://docs.gradle.org/2.13/release-notes
  https://docs.gradle.org/2.14/release-notes

Since the Gradle daemon is no longer incubating it is enabled by
default for the project and the Vagrant provisioning is simplified
as a result.

 buildSrc/gradle.properties| 2 +-
 examples/vagrant/provision-dev-cluster.sh | 9 -
 gradle.properties | 2 ++
 gradle/wrapper/gradle-wrapper.properties  | 2 +-
 4 files changed, 4 insertions(+), 11 deletions(-)


Diffs
-

  buildSrc/gradle.properties 075726fbd8ba44479c7571e3df80fc3169b5422c 
  examples/vagrant/provision-dev-cluster.sh 
2c78677c7c81ce7ffe36c8a2400ad23b4dce677b 
  gradle.properties PRE-CREATION 
  gradle/wrapper/gradle-wrapper.properties 
8508237ea3fb0c69ae1d5d245bf9f0c4c42c0b2c 

Diff: https://reviews.apache.org/r/49899/diff/


Testing
---

Locally green and Gradle daemon observed used in e2e:
```
./build-support/jenkins/build.sh
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```

I also built a fresh IDEA project with `./gradlew idea` and
that project built green from within IDEA.


Thanks,

John Sirois