Re: Review Request 50617: AURORA-1741 Added missing test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144223 --- Ship it! Ship It! - Joshua Cohen On July 29, 2016, 10:46 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50617/ > --- > > (Updated July 29, 2016, 10:46 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1741 > https://issues.apache.org/jira/browse/AURORA-1741 > > > Repository: aurora > > > Description > --- > > AURORA-1741 Added missing test cases > > > Diffs > - > > src/test/python/apache/aurora/client/test_config.py > 4742fa28e3156e5b20791b80f2db8392f7f2f4bf > > Diff: https://reviews.apache.org/r/50617/diff/ > > > Testing > --- > > `./pants test src/test/python/apache/aurora/client/cli:cli` > > > Thanks, > > Mehrdad Nurolahzade > >
Re: Review Request 50617: AURORA-1741 Added missing test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144215 --- Master (e14d0a3) is red with this patch. ./build-support/jenkins/build.sh Test coverage missing for org/apache/aurora/scheduler/storage/log/StreamManagerImpl Test coverage missing for org/apache/aurora/scheduler/storage/log/EntrySerializer$EntrySerializerImpl Test coverage missing for org/apache/aurora/scheduler/storage/log/LogStorage$ScheduledExecutorSchedulingService Test coverage missing for org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator$SnapshotDeduplicatorImpl Test coverage missing for org/apache/aurora/scheduler/storage/log/Entries Test coverage missing for org/apache/aurora/scheduler/storage/log/WriteAheadStorage Test coverage missing for org/apache/aurora/scheduler/storage/log/LogManager Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory$1 Test coverage missing for org/apache/aurora/scheduler/storage/backup/StorageBackup$StorageBackupImpl$BackupConfig Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl Test coverage missing for org/apache/aurora/scheduler/storage/backup/StorageBackup$StorageBackupImpl Test coverage missing for org/apache/aurora/scheduler/storage/backup/TemporaryStorage$TemporaryStorageFactory Test coverage missing for org/apache/aurora/scheduler/storage/backup/Recovery$RecoveryImpl$PendingRecovery Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$7 Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$6 Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$5 Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$4 Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$3 Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$2 Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$1 Test coverage missing for org/apache/aurora/scheduler/HostOffer Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$SchedulerCandidateImpl Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle$DefaultDelayedActions Test coverage missing for org/apache/aurora/scheduler/TaskVars$Counter Test coverage missing for org/apache/aurora/scheduler/TaskVars$1 Test coverage missing for org/apache/aurora/scheduler/HostOffer$1 Test coverage missing for org/apache/aurora/scheduler/TaskIdGenerator$TaskIdGeneratorImpl Test coverage missing for org/apache/aurora/scheduler/SchedulerLifecycle Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateStatusTypeHandler Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/MaintenanceModeTypeHandler Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/CronCollisionPolicyTypeHandler Test coverage missing for org/apache/aurora/scheduler/storage/db/typehandlers/JobUpdateActionTypeHandler * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. == BUILD FAILED Total time: 3 mins 39.138 secs I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 29, 2016, 10:46 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50617/ > --- > > (Updated July 29, 2016, 10:46 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1741 > https://issues.apache.org/jira/browse/AURORA-1741 > > > Repository: aurora > > > Description > --- > > AURORA-1741 Added missing test cases > > > Diffs > - > > src/test/python/apache/aurora/client/test_config.py > 4742fa28e3156e5b20791b80f2db8392f7f2f4bf > > Diff: https://reviews.apache.org/r/50617/diff/ > > > Testing > --- > > `./pants test src/test/python/apache/aurora/client/cli:cli` > > > Thanks, > > Mehrdad Nurolahzade > >
Re: Review Request 50617: AURORA-1741 Added missing test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/ --- (Updated July 29, 2016, 3:46 p.m.) Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Changes --- Sorry, forgot to commit :) Bugs: AURORA-1741 https://issues.apache.org/jira/browse/AURORA-1741 Repository: aurora Description --- AURORA-1741 Added missing test cases Diffs (updated) - src/test/python/apache/aurora/client/test_config.py 4742fa28e3156e5b20791b80f2db8392f7f2f4bf Diff: https://reviews.apache.org/r/50617/diff/ Testing --- `./pants test src/test/python/apache/aurora/client/cli:cli` Thanks, Mehrdad Nurolahzade
Re: Review Request 50617: AURORA-1741 Added missing test cases
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50617/
---
(Updated July 29, 2016, 3:44 p.m.)
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Changes
---
Now using a truely unbound mustache like `{{_unbound_}}` instead of
`{{thermos.ports[http]}}` that would not throw
`ThermosTaskValidator.assert_all_refs_bound()` off on a `config.job()` call.
Bugs: AURORA-1741
https://issues.apache.org/jira/browse/AURORA-1741
Repository: aurora
Description
---
AURORA-1741 Added missing test cases
Diffs (updated)
-
src/test/python/apache/aurora/client/test_config.py
4742fa28e3156e5b20791b80f2db8392f7f2f4bf
Diff: https://reviews.apache.org/r/50617/diff/
Testing
---
`./pants test src/test/python/apache/aurora/client/cli:cli`
Thanks,
Mehrdad Nurolahzade
Re: Review Request 50617: AURORA-1741 Added missing test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144212 --- Props to Joshua for finding a problem with these test scenarios. I'll sibmit a new version shortly. - Mehrdad Nurolahzade On July 29, 2016, 2:21 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50617/ > --- > > (Updated July 29, 2016, 2:21 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1741 > https://issues.apache.org/jira/browse/AURORA-1741 > > > Repository: aurora > > > Description > --- > > AURORA-1741 Added missing test cases > > > Diffs > - > > src/test/python/apache/aurora/client/test_config.py > 4742fa28e3156e5b20791b80f2db8392f7f2f4bf > > Diff: https://reviews.apache.org/r/50617/diff/ > > > Testing > --- > > `./pants test src/test/python/apache/aurora/client/cli:cli` > > > Thanks, > > Mehrdad Nurolahzade > >
Re: Review Request 50617: AURORA-1741 Added missing test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144206 --- Ship it! Master (e14d0a3) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 29, 2016, 9:21 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50617/ > --- > > (Updated July 29, 2016, 9:21 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1741 > https://issues.apache.org/jira/browse/AURORA-1741 > > > Repository: aurora > > > Description > --- > > AURORA-1741 Added missing test cases > > > Diffs > - > > src/test/python/apache/aurora/client/test_config.py > 4742fa28e3156e5b20791b80f2db8392f7f2f4bf > > Diff: https://reviews.apache.org/r/50617/diff/ > > > Testing > --- > > `./pants test src/test/python/apache/aurora/client/cli:cli` > > > Thanks, > > Mehrdad Nurolahzade > >
Re: Review Request 50617: AURORA-1741 Added missing test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/#review144202 --- Ship it! Ship It! - David McLaughlin On July 29, 2016, 9:21 p.m., Mehrdad Nurolahzade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50617/ > --- > > (Updated July 29, 2016, 9:21 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1741 > https://issues.apache.org/jira/browse/AURORA-1741 > > > Repository: aurora > > > Description > --- > > AURORA-1741 Added missing test cases > > > Diffs > - > > src/test/python/apache/aurora/client/test_config.py > 4742fa28e3156e5b20791b80f2db8392f7f2f4bf > > Diff: https://reviews.apache.org/r/50617/diff/ > > > Testing > --- > > `./pants test src/test/python/apache/aurora/client/cli:cli` > > > Thanks, > > Mehrdad Nurolahzade > >
Review Request 50617: AURORA-1741 Added missing test cases
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50617/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs: AURORA-1741 https://issues.apache.org/jira/browse/AURORA-1741 Repository: aurora Description --- AURORA-1741 Added missing test cases Diffs - src/test/python/apache/aurora/client/test_config.py 4742fa28e3156e5b20791b80f2db8392f7f2f4bf Diff: https://reviews.apache.org/r/50617/diff/ Testing --- `./pants test src/test/python/apache/aurora/client/cli:cli` Thanks, Mehrdad Nurolahzade
