Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review150590 --- Ship it! Master (60e5e4e) is green with this patch.

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/ --- (Updated Sept. 27, 2016, 6:06 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51929: Scheduling multiple tasks per round.

> On Sept. 23, 2016, 7:52 p.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroup.java, line 55 > > > > > > javadoc might be useful here to make it clear that the collection is a

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review150225 --- lgtm overall. Only potential blocker is the last comment (which

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review150106 --- Ship it! Ship It! - Zameer Manji On Sept. 20, 2016, 3:02

Re: Review Request 51929: Scheduling multiple tasks per round.

> On Sept. 22, 2016, 10:34 p.m., Zameer Manji wrote: > > src/main/java/org/apache/aurora/scheduler/filter/AttributeAggregate.java, > > line 114 > > > > > > Is there a way of doing this without making

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review150085 ---

Re: Review Request 51929: Scheduling multiple tasks per round.

> On Sept. 20, 2016, 11:49 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java, > > lines 93-96 > > > > > > Regarding your notes in the RB description: I don't see

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149747 --- Ship it! Ship It! - Stephan Erb On Sept. 21, 2016, 12:02

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149744 --- Ship it! Master (8432894) is green with this patch.

Re: Review Request 51929: Scheduling multiple tasks per round.

> On Sept. 20, 2016, 6:49 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/SchedulingModule.java, > > lines 93-96 > > > > > > Regarding your notes in the RB description: I don't see

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/ --- (Updated Sept. 20, 2016, 10:02 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51929: Scheduling multiple tasks per round.

> On Sept. 16, 2016, 9:08 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java, line > > 197 > > > > > > Side show: Isn't that `if` unnecessary here and we can adjust

Re: Review Request 51929: Scheduling multiple tasks per round.

> On Sept. 16, 2016, 11:08 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java, line > > 197 > > > > > > Side show: Isn't that `if` unnecessary here and we can adjust

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149681 ---

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149294 --- Ship it! Master (a87ad41) is green with this patch.

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149290 --- @ReviewBot retry - Maxim Khutornenko On Sept. 16, 2016, 9:53

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149288 --- Master (496397a) is red with this patch.

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/ --- (Updated Sept. 16, 2016, 9:53 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/ --- (Updated Sept. 16, 2016, 9:53 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149260 --- Master (783baae) is red with this patch.

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/ --- (Updated Sept. 16, 2016, 7:53 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 51929: Scheduling multiple tasks per round.

> On Sept. 16, 2016, 9:08 a.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/scheduling/TaskGroups.java, line > > 197 > > > > > > Side show: Isn't that `if` unnecessary here and we can adjust

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149179 ---

Re: Review Request 51929: Scheduling multiple tasks per round.

> On Sept. 16, 2016, 1:20 a.m., Aurora ReviewBot wrote: > > Master (783baae) is red with this patch. > > ./build-support/jenkins/build.sh > > > > # Create file stdout for capturing output. > > We can't use StringIO mock > > 

Re: Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/#review149162 --- Master (783baae) is red with this patch.

Review Request 51929: Scheduling multiple tasks per round.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51929/ --- Review request for Aurora, Joshua Cohen, Stephan Erb, and Zameer Manji.