Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review151078 --- Ship it! Ship It! - Zameer Manji On Sept. 29, 2016, 4:43

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150970 --- Ship it! Master (655105d) is green with this patch.

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-29 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/ --- (Updated Sept. 29, 2016, 11:43 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150942 --- one data valiadation issue, everything else LGTM.

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-28 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150759 --- Ship it! Ship It! - Joshua Cohen On Sept. 28, 2016, 5 p.m.,

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150679 --- Ship it! Master (69cba78) is green with this patch.

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-27 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/ --- (Updated Sept. 28, 2016, 4:08 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-27 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150671 --- docs/reference/configuration.md (line 368)

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150649 --- Ship it! Master (69cba78) is green with this patch.

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-27 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/ --- (Updated Sept. 27, 2016, 11:33 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-27 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/ --- (Updated Sept. 27, 2016, 11:30 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-23 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150161 --- Ship it! Master (4ead189) is green with this patch.

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-22 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150134 --- docs/reference/configuration.md (line 368)

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-22 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/ --- (Updated Sept. 23, 2016, 4:34 a.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-22 Thread Kai Huang
> On Sept. 23, 2016, 1:16 a.m., Dmitriy Shirchenko wrote: > > src/main/python/apache/aurora/client/config.py, line 113 > > > > > > why was this configuration option deleted? it is still referenced: > >

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-22 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/#review150118 --- src/main/python/apache/aurora/client/config.py (line 112)

Re: Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-22 Thread Kai Huang
> On Sept. 20, 2016, 7:59 p.m., Aurora ReviewBot wrote: > > Master (a9f4e26) is green with this patch. > > ./build-support/jenkins/build.sh > > > > I will refresh this build result if you post a review containing > > "@ReviewBot retry" ping for review: Could any one take a look at this

Review Request 52094: Add min_consecutive_health_checks in HealthCheckConfig

2016-09-20 Thread Kai Huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52094/ --- Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji.