Re: Review Request 52428: Add missing libffi build dep to support pants.
> On Sept. 30, 2016, 12:58 p.m., Stephan Erb wrote: > > Do the vagrant files have to be adapted as well? Nope - those support testing and the testing does not use pants, just its products in `.rpm` or `.deb` form. - John --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151061 --- On Sept. 30, 2016, 12:17 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52428/ > --- > > (Updated Sept. 30, 2016, 12:17 p.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Repository: aurora-packaging > > > Description > --- > > builder/deb/debian-jessie/Dockerfile | 1 + > builder/deb/ubuntu-trusty/Dockerfile | 1 + > builder/rpm/centos-7/Dockerfile | 1 + > 3 files changed, 3 insertions(+) > > > Diffs > - > > builder/deb/debian-jessie/Dockerfile > 4a70359f56b5c4b3a3dd30d005f39ee03707427a > builder/deb/ubuntu-trusty/Dockerfile > 56f81e3b0533d2a2be84e723c143dee3e6e7e79a > builder/rpm/centos-7/Dockerfile 3431860708f59460dd2f6b575e23f280e903d41e > > Diff: https://reviews.apache.org/r/52428/diff/ > > > Testing > --- > > This corrects the missing deps seen here: > https://builds.apache.org/job/aurora-packaging-nightly/440/ > > Now locally green: > ``` > (aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o > snapshot.tar.gz HEAD > (aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz > 0.17.0-SNAPSHOT > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 52428: Add missing libffi build dep to support pants.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151061 --- Ship it! Do the vagrant files have to be adapted as well? - Stephan Erb On Sept. 30, 2016, 8:17 nachm., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52428/ > --- > > (Updated Sept. 30, 2016, 8:17 nachm.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Repository: aurora-packaging > > > Description > --- > > builder/deb/debian-jessie/Dockerfile | 1 + > builder/deb/ubuntu-trusty/Dockerfile | 1 + > builder/rpm/centos-7/Dockerfile | 1 + > 3 files changed, 3 insertions(+) > > > Diffs > - > > builder/deb/debian-jessie/Dockerfile > 4a70359f56b5c4b3a3dd30d005f39ee03707427a > builder/deb/ubuntu-trusty/Dockerfile > 56f81e3b0533d2a2be84e723c143dee3e6e7e79a > builder/rpm/centos-7/Dockerfile 3431860708f59460dd2f6b575e23f280e903d41e > > Diff: https://reviews.apache.org/r/52428/diff/ > > > Testing > --- > > This corrects the missing deps seen here: > https://builds.apache.org/job/aurora-packaging-nightly/440/ > > Now locally green: > ``` > (aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o > snapshot.tar.gz HEAD > (aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz > 0.17.0-SNAPSHOT > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 52428: Add missing libffi build dep to support pants.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151055 --- Ship it! Ship It! - Joshua Cohen On Sept. 30, 2016, 6:17 p.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52428/ > --- > > (Updated Sept. 30, 2016, 6:17 p.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Repository: aurora-packaging > > > Description > --- > > builder/deb/debian-jessie/Dockerfile | 1 + > builder/deb/ubuntu-trusty/Dockerfile | 1 + > builder/rpm/centos-7/Dockerfile | 1 + > 3 files changed, 3 insertions(+) > > > Diffs > - > > builder/deb/debian-jessie/Dockerfile > 4a70359f56b5c4b3a3dd30d005f39ee03707427a > builder/deb/ubuntu-trusty/Dockerfile > 56f81e3b0533d2a2be84e723c143dee3e6e7e79a > builder/rpm/centos-7/Dockerfile 3431860708f59460dd2f6b575e23f280e903d41e > > Diff: https://reviews.apache.org/r/52428/diff/ > > > Testing > --- > > This corrects the missing deps seen here: > https://builds.apache.org/job/aurora-packaging-nightly/440/ > > Now locally green: > ``` > (aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o > snapshot.tar.gz HEAD > (aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz > 0.17.0-SNAPSHOT > ``` > > > Thanks, > > John Sirois > >
Re: Review Request 52428: Add missing libffi build dep to support pants.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/#review151053 --- Ship it! Ship It! - Zameer Manji On Sept. 30, 2016, 11:17 a.m., John Sirois wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52428/ > --- > > (Updated Sept. 30, 2016, 11:17 a.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Repository: aurora-packaging > > > Description > --- > > builder/deb/debian-jessie/Dockerfile | 1 + > builder/deb/ubuntu-trusty/Dockerfile | 1 + > builder/rpm/centos-7/Dockerfile | 1 + > 3 files changed, 3 insertions(+) > > > Diffs > - > > builder/deb/debian-jessie/Dockerfile > 4a70359f56b5c4b3a3dd30d005f39ee03707427a > builder/deb/ubuntu-trusty/Dockerfile > 56f81e3b0533d2a2be84e723c143dee3e6e7e79a > builder/rpm/centos-7/Dockerfile 3431860708f59460dd2f6b575e23f280e903d41e > > Diff: https://reviews.apache.org/r/52428/diff/ > > > Testing > --- > > This corrects the missing deps seen here: > https://builds.apache.org/job/aurora-packaging-nightly/440/ > > Now locally green: > ``` > (aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o > snapshot.tar.gz HEAD > (aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz > 0.17.0-SNAPSHOT > ``` > > > Thanks, > > John Sirois > >
Review Request 52428: Add missing libffi build dep to support pants.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52428/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Repository: aurora-packaging Description --- builder/deb/debian-jessie/Dockerfile | 1 + builder/deb/ubuntu-trusty/Dockerfile | 1 + builder/rpm/centos-7/Dockerfile | 1 + 3 files changed, 3 insertions(+) Diffs - builder/deb/debian-jessie/Dockerfile 4a70359f56b5c4b3a3dd30d005f39ee03707427a builder/deb/ubuntu-trusty/Dockerfile 56f81e3b0533d2a2be84e723c143dee3e6e7e79a builder/rpm/centos-7/Dockerfile 3431860708f59460dd2f6b575e23f280e903d41e Diff: https://reviews.apache.org/r/52428/diff/ Testing --- This corrects the missing deps seen here: https://builds.apache.org/job/aurora-packaging-nightly/440/ Now locally green: ``` (aurora) $ git archive --prefix=apache-aurora-$(cat .auroraversion)/ -o snapshot.tar.gz HEAD (aurora-packaging) $ ./build-artifact.sh ../aurora/snapshot.tar.gz 0.17.0-SNAPSHOT ``` Thanks, John Sirois
