Re: Review Request 17270: Bridge framework for client v2.

2014-02-06 Thread Mark Chu-Carroll
On Feb. 3, 2014, 2:15 p.m., Bill Farner wrote: Ship It! brian, ping? can't ship without shipits from everyone on the People line. - Mark --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.

2014-02-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17785/#review33802 --- Ship it!

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33811 --- src/main/python/apache/aurora/client/cli/role.py

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33814 --- src/main/python/apache/aurora/client/cli/role.py

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Mark Chu-Carroll
On Feb. 6, 2014, 1:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/role.py, line 44 https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Jonathan Boulle
On Feb. 6, 2014, 6:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/role.py, line 44 https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Mark Chu-Carroll
On Feb. 6, 2014, 1:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/role.py, line 44 https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Kevin Sweeney
On Feb. 6, 2014, 10:36 a.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/role.py, line 44 https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/#review33825 --- Ship it! src/main/python/apache/aurora/client/cli/quota.py

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 6, 2014, 2:19 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 6, 2014, 2:27 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17730: Now sorting roles before displaying them on home page.

2014-02-06 Thread Suman Karumuri
On Feb. 5, 2014, 8:28 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 25 https://reviews.apache.org/r/17730/diff/2/?file=469965#file469965line25 JavaScript ignoramus here, but have you considered localeCompare() [1]?

Re: Review Request 17730: Now sorting roles before displaying them on home page.

2014-02-06 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17730/ --- (Updated Feb. 6, 2014, 7:32 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails

2014-02-06 Thread Jonathan Boulle
On Feb. 5, 2014, 2:18 a.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/command_runner.py, line 139 https://reviews.apache.org/r/17724/diff/1/?file=469319#file469319line139 It's API level, because this is the highest level shared by all of the distinct code

Re: Review Request 17056: fix dependencies for setup_py

2014-02-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review33840 --- Did this ever land? - Kevin Sweeney On Jan. 17, 2014, 10:37

Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-02-06 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-145

Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.

2014-02-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17729/#review33844 ---

Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.

2014-02-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17729/ --- (Updated Feb. 6, 2014, 9:22 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails

2014-02-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17724/ --- (Updated Feb. 6, 2014, 4:40 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-02-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review33846 --- No ship. AbstractCronIT is used by QuartzCronIT in

Re: Review Request 17723: Implementing support for DRAINING state.

2014-02-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17723/#review33847 --- Ship it! Ship It! - Kevin Sweeney On Feb. 4, 2014, 1:31 p.m.,

Re: Review Request 17270: Bridge framework for client v2.

2014-02-06 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33842 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 17270: Bridge framework for client v2.

2014-02-06 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33855 --- src/main/python/apache/aurora/client/cli/__init__.py

Review Request 17823: Add a utility to list missing shipits.

2014-02-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17823/ --- Review request for Aurora and Brian Wickman. Repository: aurora Description

Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.

2014-02-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17785/#review33868 --- src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.

2014-02-06 Thread Maxim Khutornenko
On Feb. 7, 2014, 12:05 a.m., Kevin Sweeney wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 273 https://reviews.apache.org/r/17785/diff/1/?file=470610#file470610line273 I'm not clear on why THROTTLED is an active state - doesn't it precede PENDING? THROTTLED is just

Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.

2014-02-06 Thread Kevin Sweeney
On Feb. 6, 2014, 4:05 p.m., Kevin Sweeney wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 273 https://reviews.apache.org/r/17785/diff/1/?file=470610#file470610line273 I'm not clear on why THROTTLED is an active state - doesn't it precede PENDING? Maxim

Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.

2014-02-06 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17785/#review33877 --- Rebased, re-run tests and pushed to master. - Maxim Khutornenko

Re: Review Request 17270: Bridge framework for client v2.

2014-02-06 Thread Jonathan Boulle
On Feb. 6, 2014, 10:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 149 https://reviews.apache.org/r/17270/diff/3/?file=456886#file456886line149 That's actually the way that I originally wrote it, and wickman wanted me to change it to

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-06 Thread Bill Farner
Thief! You stole my idea! On Thursday, February 6, 2014, Kevin Sweeney kevi...@apache.org wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17823/

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-02-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review33891 --- I'll be out until Monday - I'll have another look then. - Kevin

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-06 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17823/#review33895 --- to help keep things a little more organized we should put this in a

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-02-06 Thread Jake Farrell
On Feb. 6, 2014, 9:53 p.m., Kevin Sweeney wrote: No ship. AbstractCronIT is used by QuartzCronIT in https://reviews.apache.org/r/17750/ Merging AbstractCronIT and QuartzCronIT is on the list of followup TODOs for that review, so this will be mitigated then. AbstractCronIT depends

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-02-06 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/ --- (Updated Feb. 7, 2014, 1:45 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-06 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17823/#review33910 --- +1 - Suman Karumuri On Feb. 6, 2014, 11:52 p.m., Kevin Sweeney