Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-18 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review34706 --- Ship it! Ship It! - Brian Wickman On Feb. 18, 2014, 1:47 p.m.,

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-18 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/#review34714 --- src/main/python/apache/aurora/client/cli/sla.py

Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18229/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-213

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18229/#review34736 --- Can you verify this fixes the e2e test? - Kevin Sweeney On Feb.

Re: Review Request 18141: Prepare and launch GC executor tasks asynchronously.

2014-02-18 Thread Bill Farner
On Feb. 14, 2014, 8:49 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/MesosSchedulerImpl.java, line 168 https://reviews.apache.org/r/18141/diff/1/?file=486030#file486030line168 This comment seems more appropriate for the SchedulerModule where the list is

Re: Review Request 18141: Prepare and launch GC executor tasks asynchronously.

2014-02-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18141/#review34749 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 18, 2014, 7:16

Re: Review Request 18157: Compute task host attribute aggregates once when scheduling tasks.

2014-02-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18157/ --- (Updated Feb. 18, 2014, 7:26 p.m.) Review request for Aurora, Suman Karumuri

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/ --- (Updated Feb. 18, 2014, 7:30 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
On Feb. 18, 2014, 6:54 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/options.py, line 68 https://reviews.apache.org/r/18153/diff/1/?file=486455#file486455line68 This will throw a ValueError if the user didn't give a numeric value. Good point. Fixed. -

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-18 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/ --- (Updated Feb. 18, 2014, 2:30 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Brian Wickman
On Feb. 18, 2014, 6:57 p.m., Kevin Sweeney wrote: Can you verify this fixes the e2e test? Brian Wickman wrote: give me an hour and i'll get back to you *** + echo 'OK (all tests passed)' OK (all tests passed) + echo '***' *** + exit 0 - Brian

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18229/#review34772 --- Ship it! Ship It! - Kevin Sweeney On Feb. 18, 2014, 10:52 a.m.,

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-18 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/ --- (Updated Feb. 18, 2014, 3:31 p.m.) Review request for Aurora, David Robinson

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/#review34775 --- src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/ --- (Updated Feb. 18, 2014, 8:46 p.m.) Review request for Aurora, Mark Chu-Carroll

Review Request 18239: rename ThermosExecutor to AuroraExecutor, clean up thermos-isms from ExecutorBase

2014-02-18 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18239/ --- Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll. Bugs:

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Brian Wickman
On Feb. 18, 2014, 8:45 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/api/sla.py, lines 61-62 https://reviews.apache.org/r/18153/diff/2/?file=496733#file496733line61 This is handled in the return statement by validating the index range. Having max() would not

Re: Review Request 18244: Use GMT in generated predictions.

2014-02-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18244/#review34790 --- Ship it! Ship It! - Bill Farner On Feb. 18, 2014, 10:15 p.m.,

Review Request 18245: Use user.signingkey for tag-signing.

2014-02-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18245/ --- Review request for Aurora, Jake Farrell and Bill Farner. Repository: aurora

Review Request 18247: Add kevints CODE SIGNING KEY to KEYS.

2014-02-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18247/ --- Review request for Aurora, Jake Farrell and Bill Farner. Repository: aurora

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/ --- (Updated Feb. 18, 2014, 10:52 p.m.) Review request for Aurora, Mark

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
On Feb. 18, 2014, 10:15 p.m., Brian Wickman wrote: src/main/python/apache/aurora/client/cli/options.py, line 70 https://reviews.apache.org/r/18153/diff/3/?file=496781#file496781line70 is 100 an incorrect percentile? 100th percentile means max() right? Brian Wickman wrote:

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/#review34798 --- Ship it! src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
On Feb. 18, 2014, 10:58 p.m., Brian Wickman wrote: src/main/python/apache/aurora/client/api/sla.py, line 61 https://reviews.apache.org/r/18153/diff/4/?file=497198#file497198line61 raise ValueError('Percentile must be within (0, 100), got %r instead.' % percentile) Done. On

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153/ --- (Updated Feb. 18, 2014, 11:19 p.m.) Review request for Aurora, Mark

Review Request 18248: fix python tests on master

2014-02-18 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18248/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Repository: aurora

Re: Review Request 18247: Add kevints CODE SIGNING KEY to KEYS.

2014-02-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18247/#review34813 --- Ship it! Ship It! - Bill Farner On Feb. 18, 2014, 10:50 p.m.,