Re: Review Request 18267: Implement help for v2 bridge

2014-02-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18267/ --- (Updated Feb. 21, 2014, 8:56 a.m.) Review request for Aurora, David Robinson

Review Request 18354: Add a packaging target for clientv2.

2014-02-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18354/ --- Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-226

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35150 --- src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 16144: ZookeeperSchedulerClient url property errored when no proxy_url was set, and the client was not connected.

2014-02-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16144/#review35154 --- Ship it! Ship It! - Mark Chu-Carroll On Dec. 9, 2013, 8:57

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-02-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334/#review35152 --- Ship it! Ship It! - Mark Chu-Carroll On Feb. 20, 2014, 7:05

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Maxim Khutornenko
On Feb. 21, 2014, 2:55 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/sla.py, line 88 https://reviews.apache.org/r/18296/diff/1/?file=498483#file498483line88 This comment doesn't make sense to me. I don't understand what an instance of this class is. Is it

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/ --- (Updated Feb. 21, 2014, 4:30 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35170 --- src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

2014-02-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345/#review35173 --- This LGTM, deferring ship for the conversation. build-support/pex

Re: Review Request 18316: Aurora-193: fix license plugin

2014-02-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18316/#review35199 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 11:50 a.m.,

Re: Review Request 18316: Aurora-193: fix license plugin

2014-02-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18316/#review35198 --- Ship it! Ship It! - Bill Farner On Feb. 20, 2014, 7:50 p.m.,

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35202 --- Ship it! Ship It! - Brian Wickman On Feb. 21, 2014, 7:49 p.m.,

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35203 --- src/main/python/apache/aurora/client/api/sla.py

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Brian Wickman
On Feb. 21, 2014, 7:48 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/api/sla.py, lines 135-139 https://reviews.apache.org/r/18296/diff/2/?file=500057#file500057line135 The else would fire even if the _hosts is empty producing an unbound variable error. I