Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41145 ---

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 23, 2014, 3:02 p.m.) Review request for Aurora, Suman Karumuri

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/#review41146 --- Ship it!

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris
On April 23, 2014, 3:14 p.m., Maxim Khutornenko wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js, line 22 https://reviews.apache.org/r/20146/diff/5/?file=565577#file565577line22 Missing , for the new records. That's what I get for multitasking Fix

Re: Review Request 20490: Add a get version API method.

2014-04-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20490/#review41149 --- Ship it! Ship It! - Brian Wickman On April 22, 2014, 7:59 p.m.,

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Maxim Khutornenko
On April 22, 2014, 7:57 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/sla/SlaAlgorithm.java, line 65 https://reviews.apache.org/r/20398/diff/7/?file=562468#file562468line65 I'm still failing to see the upside of this enum. An obvious downside is that

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 23, 2014, 5:42 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 20573: Include inactive tasks when computing job summaries

2014-04-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20573/#review41172 --- Ship it!

Re: Review Request 19767: CronScheduler based on Quartz

2014-04-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19767/#review41178 --- Ship it! Latest changes LGTM! - Bill Farner On April 22, 2014,

Re: Review Request 19767: CronScheduler based on Quartz

2014-04-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19767/ --- (Updated April 23, 2014, 11:39 a.m.) Review request for Aurora, Maxim

Review Request 20620: Add machine maintainer auth capability.

2014-04-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20620/ --- Review request for Aurora, Suman Karumuri and Maxim Khutornenko. Bugs:

Review Request 20629: End to end test should not look at the number of html lines.

2014-04-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20629/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/#review41201 --- Ship it!

Re: Review Request 20629: End to end test should not look at the number of html lines.

2014-04-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20629/#review41238 --- Ship it! Ship It! - Kevin Sweeney On April 23, 2014, 12:59

Re: Review Request 20573: Include inactive tasks when computing job summaries

2014-04-23 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20573/ --- (Updated April 23, 2014, 11:08 p.m.) Review request for Aurora and Bill

Re: Review Request 20573: Include inactive tasks when computing job summaries

2014-04-23 Thread Suman Karumuri
On April 23, 2014, 6:15 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 407 https://reviews.apache.org/r/20573/diff/2/?file=565348#file565348line407 Your call, but you could extract a convenience function (this is

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Maxim Khutornenko
On April 23, 2014, 10:16 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/sla/MetricCalculator.java, line 67 https://reviews.apache.org/r/20398/diff/8/?file=565882#file565882line67 You can save a good amount of wiring boilerplate if you use Guava's

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/#review41244 --- you can pull me off the review on this one. - Brian Wickman On

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/ --- (Updated April 23, 2014, 11:52 p.m.) Review request for Aurora, Kevin Sweeney

Review Request 20640: Fix createJob to accept non-cron jobs.

2014-04-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20640/ --- Review request for Aurora, Bill Farner and Brian Wickman. Bugs: AURORA-349

Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Dave Lester
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20641/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 19627: Updates documentation to specify template, adds headers to pages that needed them, cleans up whitespace, and makes markdown for headers consistent.

2014-04-23 Thread Dave Lester
On April 21, 2014, 6:57 p.m., Bill Farner wrote: Dave - is this review still relevant? Thanks for following-up! Yes, it is. - Dave --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 20640: Fix createJob to accept non-cron jobs.

2014-04-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20640/ --- (Updated April 23, 2014, 6:06 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 20640: Fix createJob to accept non-cron jobs.

2014-04-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20640/#review41253 --- -1 no unit test coverage - Bill Farner On April 24, 2014, 1:10

Re: Review Request 20573: Include inactive tasks when computing job summaries

2014-04-23 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20573/ --- (Updated April 24, 2014, 1:15 a.m.) Review request for Aurora and Bill Farner.

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/ --- (Updated April 24, 2014, 1:33 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Dave Lester
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20641/ --- (Updated April 24, 2014, 1:34 a.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20641/#review41261 --- Ship it! Ship It! - Bill Farner On April 24, 2014, 1:34 a.m.,

Re: Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Dave Lester
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20641/ --- (Updated April 24, 2014, 2:35 a.m.) Review request for Aurora, Jake Farrell,

Re: Review Request 20641: AURORA-48: Renames documentation filenames in associated links to be SEO friendly

2014-04-23 Thread Bill Farner
On April 24, 2014, 2:31 a.m., Bill Farner wrote: Ship It! Pushed to master as 94b723b - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20641/#review41261

Re: Review Request 20146: AURORA-265: Add missing tooltips for task states in dictionary.js

2014-04-23 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20146/ --- (Updated April 24, 2014, 2:55 a.m.) Review request for Aurora, Suman Karumuri

Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-04-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-340

Review Request 20650: Exclude reports directory from idea project.

2014-04-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20650/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: