Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-14 Thread Suman Karumuri
> On May 14, 2014, 4:26 a.m., Suman Karumuri wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 386 > > > > > > I see this function call (function definition itself is good)

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-14 Thread David McLaughlin
> On May 14, 2014, 4:26 a.m., Suman Karumuri wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 386 > > > > > > I see this function call (function definition itself is good)

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-14 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/ --- (Updated May 14, 2014, 10:39 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21247/ --- (Updated May 14, 2014, 3:46 p.m.) Review request for Aurora, Suman Karumuri and

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-14 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21247/#review42981 --- Thanks for the changes. - Suman Karumuri On May 14, 2014, 3:46 p.

Review Request 21440: Implementing parallel updater

2014-05-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-350

Re: Review Request 21294: Only serve thrift over HTTP.

2014-05-14 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21294/#review43002 --- Ship it! Ship It! - Mark Chu-Carroll On May 9, 2014, 8:50 p.m.,

Re: Review Request 21440: Implementing parallel updater

2014-05-14 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/#review43004 --- src/main/python/apache/aurora/client/api/instance_watcher.py

Re: Review Request 21407: Add JSHint to our build

2014-05-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21407/#review43010 --- Ship it! build.gradle

Re: Review Request 21426: Added a nav bar with Aurora logo.

2014-05-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21426/#review42992 --- Was hoping for something that looks more like the navbar at: http:/

Re: Review Request 21297: Adding UpdateConfig value checks.

2014-05-14 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21297/ --- (Updated May 14, 2014, 8 p.m.) Review request for Aurora, Kevin Sweeney and Bri

Review Request 21145: Changed sandbox link from span2 to span3.

2014-05-14 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21145/ --- Review request for Aurora and David McLaughlin. Bugs: AURORA-396 https://is

Re: Review Request 21407: Add JSHint to our build

2014-05-14 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21407/#review43011 --- Ship it! Ship It! - Suman Karumuri On May 13, 2014, 9:38 p.m., D

Re: Review Request 21232: Add a strict mode for commands that specify instances.

2014-05-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21232/#review42591 --- Ship it! Ship It! - David McLaughlin On May 8, 2014, 6:54 p.m.,

Re: Review Request 21253: AURORA-392: Add apache- to source distribution name

2014-05-14 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21253/#review42986 --- Ship it! Ship It! - Kevin Sweeney On May 8, 2014, 7:25 p.m., Jak

Re: Review Request 21145: Changed sandbox link from span2 to span3.

2014-05-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21145/#review42538 --- Ship it! Ship It! - David McLaughlin On May 8, 2014, 8:23 p.m.,

Re: Review Request 21144: Always show resource consumption table on Job page.

2014-05-14 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21144/#review42594 --- Ship it! Ship It! - Bill Farner On May 7, 2014, 1:39 a.m., Suman

Re: Review Request 21170: Make the "task run" command accept an instances spec.

2014-05-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21170/#review42587 --- Ship it! - David McLaughlin On May 7, 2014, 6:48 p.m., Mark Chu-C