Re: Review Request 21780: Adding cron client commands.

2014-05-29 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21780/#review44246 --- Ship it! Ship It! - Suman Karumuri On May 21, 2014, 5:45 p.m.,

Re: Review Request 21780: Adding cron client commands.

2014-05-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21780/ --- (Updated May 29, 2014, 10:33 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22007: Fix logic error when populating task resources.

2014-05-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22007/#review44262 --- Ship it! Ship It! - Maxim Khutornenko On May 29, 2014, 4:32

Review Request 22023: Modify clientv2 to always log messages from the server

2014-05-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22023/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: aurora-477

Re: Review Request 21980: Fix client logging.

2014-05-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21980/ --- (Updated May 29, 2014, 1:05 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 21497: Add CORS support to thrift end points.

2014-05-29 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21497/ --- (Updated May 29, 2014, 6:12 p.m.) Review request for Aurora, David McLaughlin,

Re: Review Request 21943: Accept a job key for config loading.

2014-05-29 Thread Antoine Tollenaere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21943/ --- (Updated May 29, 2014, 6:21 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 21943: Accept a job key for config loading.

2014-05-29 Thread Antoine Tollenaere
On May 29, 2014, 12:49 a.m., Mark Chu-Carroll wrote: Thank you for this! Long overdue; I've been meaning to get to this, but never had time. Yes I was embarrassed with these old todos for myself. I can't merge the change though, you'll have to do it for me. - Antoine

Review Request 22032: first draft of a developing client v2 document.

2014-05-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/ --- Review request for Aurora, David McLaughlin and Henry Saputra. Bugs: aurora-20

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-05-29 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22023/#review44283 --- Ship it! src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 22023: Modify clientv2 to always log messages from the server

2014-05-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22023/ --- (Updated May 29, 2014, 4:45 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22050: Change excludes in rsync commands to avoid unintentionally suppressing non-top-level directories.

2014-05-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22050/#review44288 --- Ship it! Ship It! - Kevin Sweeney On May 29, 2014, 2:04 p.m.,

Re: Review Request 22032: first draft of a developing client v2 document.

2014-05-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/#review44291 --- docs/developing-aurora-client.md

Re: Review Request 22032: first draft of a developing client v2 document.

2014-05-29 Thread Henry Saputra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/#review44289 --- Ship it! Small nits but looks good overall. Will also you add

Re: Review Request 22032: first draft of a developing client v2 document.

2014-05-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22032/#review44295 --- docs/developing-aurora-client.md

Review Request 22056: Fix inconsistent gradle build version number.

2014-05-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22056/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 22056: Fix inconsistent gradle build version number.

2014-05-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22056/#review44298 --- Ship it! Ship It! - Maxim Khutornenko On May 29, 2014, 9:30

Review Request 22065: Fix /cron endpoint.

2014-05-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-478

Re: Review Request 22065: Fix /cron endpoint.

2014-05-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/ --- (Updated May 29, 2014, 6:09 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22065: Fix /cron endpoint.

2014-05-29 Thread Kevin Sweeney
On May 29, 2014, 4:21 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/http/Cron.java, line 52 https://reviews.apache.org/r/22065/diff/1/?file=599475#file599475line52 While you're in the neighborhood...how about some test coverage in here? Ideally the test

Re: Review Request 22065: Fix /cron endpoint.

2014-05-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22065/ --- (Updated May 29, 2014, 6:32 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22008: Exclude .git from rsync copy in vagrant.

2014-05-29 Thread Mark Chu-Carroll
On May 29, 2014, 7:58 a.m., Mark Chu-Carroll wrote: Why? Right now, I do a lot of debugging of the client using vagrant. My typical workflow is: - Make the change in my git workspace. - Commit it to a branch. - vagrant ssh into the virtual cluster - git pull /vagrant mybranch