Re: Review Request 22457: Improve aurora job diff command.

2014-06-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review46747 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 22839: Add configuration plugins to default aurora client.

2014-06-26 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22839/#review46756 --- src/main/python/apache/aurora/client/cli/standalone_client.py

Re: Review Request 22948: Add a script that allows for easy selective rebuilding of components in the vagrant environment.

2014-06-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22948/#review46757 --- Ship it! Ship It! - Maxim Khutornenko On June 25, 2014, 12:43

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46758 ---

Re: Review Request 22998: Generate wrapper classes for all thrift structs in api.thrift.

2014-06-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22998/#review46759 --- Ship it! Awesome! - Maxim Khutornenko On June 26, 2014, 3:44

Re: Review Request 22999: Use immutable types in AttributeStore.

2014-06-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22999/#review46761 --- Ship it! Ship It! - Maxim Khutornenko On June 26, 2014, 4:45

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46770 --- replace Preconditions.checkNotNull with Objects.requireNonNull as

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Bill Farner
On June 26, 2014, 4:59 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, line 96 https://reviews.apache.org/r/22982/diff/1/?file=617559#file617559line96 This seems like a repeating pattern to avoid naming collision. What do

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Bill Farner
On June 26, 2014, 6:21 p.m., Kevin Sweeney wrote: replace Preconditions.checkNotNull with Objects.requireNonNull as well? Great suggestion, i'll update the diff to add that. - Bill --- This is an automatically generated e-mail. To

Re: Review Request 19796: AURORA-145:Test dependencies leak into distribution

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19796/#review46789 --- Ship it! Ship It! - Bill Farner On June 26, 2014, 3:23 a.m.,

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 26, 2014, 7:52 p.m.) Review request for Aurora and Maxim

Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.

2014-06-26 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/#review46794 --- Ship it! Ship It! - Joe Smith On June 25, 2014, 11:48 a.m.,

Review Request 23087: Fix build break in code generator.

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23087/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 23087: Fix build break in code generator.

2014-06-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23087/#review46795 --- Ship it! Ship It! - Maxim Khutornenko On June 26, 2014, 7:59

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/#review46796 --- Latest diff is bad, i managed to pick up some python code with my

Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.

2014-06-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/ --- (Updated June 26, 2014, 8:14 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22982: Use java.util.Objects replacements for guava helpers.

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22982/ --- (Updated June 26, 2014, 8:33 p.m.) Review request for Aurora and Maxim

Re: Review Request 22999: Use immutable types in AttributeStore.

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22999/ --- (Updated June 26, 2014, 8:37 p.m.) Review request for Aurora and Maxim

Re: Review Request 22948: Add a script that allows for easy selective rebuilding of components in the vagrant environment.

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22948/#review46808 --- Ping - Kevin, Mark? - Bill Farner On June 25, 2014, 12:43 a.m.,

Review Request 23107: Database-backed implementation of SchedulerStore.

2014-06-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-555