Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Repository: aur

Re: Review Request 23718: AURORA-594: RC1 files missing Apache license headers

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23718/#review48248 --- Ship it! src/main/python/apache/aurora/BUILD

Re: Review Request 23741: Add a human-friendly HTTP/JSON API with auto-generated documentation.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23741/ --- (Updated July 21, 2014, 4:59 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23455: Add a lightweight version of command hooks for clientv1 commands.

2014-07-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23455/#review48068 --- Ship it! Ship It! src/main/python/apache/aurora/client/commands/c

Re: Review Request 22944: Use tasksWithoutConfig on job page

2014-07-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22944/#review48292 --- Ping? - David McLaughlin On June 24, 2014, 9:30 p.m., David McLau

Review Request 23753: Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23753/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-593 https://issue

Re: Review Request 23753: Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin.

2014-07-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23753/#review48294 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2014, 1:58 p.m., B

Re: Review Request 22944: Use tasksWithoutConfig on job page

2014-07-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22944/#review48295 --- Ship it! Ship It! - Kevin Sweeney On June 24, 2014, 2:30 p.m., D

Re: Review Request 21440: Implementing parallel updater

2014-07-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated July 21, 2014, 9:09 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 23244: Fixing return value in _check_sla.

2014-07-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23244/ --- (Updated July 21, 2014, 9:39 p.m.) Review request for Aurora, Joe Smith and Mar

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

2014-07-21 Thread Maxim Khutornenko
> On July 2, 2014, 11:11 p.m., Bill Farner wrote: > > src/main/thrift/org/apache/aurora/gen/api.thrift, line 414 > > > > > > What's the motivation for including the job key? I would assume that > > the caller either

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

2014-07-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/ --- (Updated July 21, 2014, 9:58 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48298 --- Ping. - Maxim Khutornenko On July 3, 2014, 1:48 a.m., Maxim Khuto

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/#review48299 --- Ship it! Ship It! - Bill Farner On July 21, 2014, 9:58 p.m., Max

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-07-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review48300 --- Ship it! Still think it's worth keeping but don't want to block it.

Re: Review Request 23188: Adding getPendingReason RPC to expose scheduling vetos in the UI/client.

2014-07-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23188/#review48303 --- Ship it! Ship It! - Kevin Sweeney On July 21, 2014, 2:58 p.m., M

Re: Review Request 20648: Remove IsolatedSchedulerModule and surrounding code.

2014-07-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20648/#review48304 --- Ship it! Ship It! - Kevin Sweeney On July 17, 2014, 3:53 p.m., B

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48302 --- src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInt

Review Request 23776: Add --stacktrace to gradle build command.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23776/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description -

Re: Review Request 23776: Add --stacktrace to gradle build command.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23776/ --- (Updated July 21, 2014, 10:27 p.m.) Review request for Aurora and Kevin Sweeney

Re: Review Request 23666: REST service for aurora client commands, built with Tornado Web framework

2014-07-21 Thread Misho Krastev
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23666/ --- (Updated July 21, 2014, 10:58 p.m.) Review request for Aurora. Changes --

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Maxim Khutornenko
> On July 21, 2014, 10:16 p.m., Bill Farner wrote: > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, > > line 721 > > > > > > We should avoid taking advantage of passing nulls where p

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/ --- (Updated July 21, 2014, 11:23 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 23254: Refactoring SchedulerCore (killTasks)

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23254/#review48316 --- Ship it! Ship It! - Bill Farner On July 21, 2014, 11:23 p.m., Ma

Review Request 23779: Fix filter spec for leader redirect.

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23779/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-584 https://i

Review Request 23782: Revert "Instruct jacoco gradle plugin to save coverage details needed by jacoco jenkins plugin."

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23782/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description -

Re: Review Request 23666: REST service for aurora client commands, built with Tornado Web framework

2014-07-21 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23666/#review48322 --- Do you think this should be obviated by https://reviews.apache.org/r

Re: Review Request 23779: Fix filter spec for leader redirect.

2014-07-21 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23779/#review48323 --- Ship it! Ship It! - Maxim Khutornenko On July 22, 2014, 12:09 a.