Re: Review Request 23827: Filtering out unknown hosts when starting maintenance.

2014-07-23 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23827/#review48531 --- Ship it! Ship It! - Mark Chu-Carroll On July 22, 2014, 6:37

Re: Review Request 21440: Implementing parallel updater

2014-07-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21440/ --- (Updated July 23, 2014, 5:05 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 23107: Database-backed implementation of SchedulerStore.

2014-07-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23107/ --- (Updated July 23, 2014, 5:10 p.m.) Review request for Aurora and Kevin

Review Request 23859: When syncing code to vagrant, delete files that were deleted from the repository.

2014-07-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23859/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-587

Re: Review Request 23872: Fix problem with deschedule command.

2014-07-23 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23872/#review48574 --- Does this point out lack of unit test coverage, or were unit tests

Re: Review Request 23872: Fix problem with deschedule command.

2014-07-23 Thread Mark Chu-Carroll
It's a bit sneaky - unit tests pass, because they mock the call to the API, and the way that the API is implemented in Python, the usual spec mechanism doesn't work for the thrift proxy. So the unit test couldn't catch this. The end-to-end test should have caught it - I'm not sure why it didn't.

Re: Review Request 23872: Fix problem with deschedule command.

2014-07-23 Thread Bill Farner
wired up to thrift. The generated thrift object (AuroraAdmin.Client) has these signatures, though, right? -=Bill On Wed, Jul 23, 2014 at 4:54 PM, Mark Chu-Carroll mchucarr...@apache.org wrote: Unfortunately, no. Because the python code that calls through thrift is using a dynamic

Re: Review Request 23872: Fix problem with deschedule command.

2014-07-23 Thread Mark Chu-Carroll
Yeah, but the argument list of that object is different from the argument list used by the python client code - the dynamic stuff adds parameters for session IDs and auth keys. I spent a lot of time when I was writing the unit tests on this - it's a very hard thing to mock well. There's a lot of

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-23 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/#review48593 --- Ship it! Good start, thanks for getting this out here. Any

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-23 Thread Bill Farner
On July 24, 2014, 12:40 a.m., Kevin Sweeney wrote: Good start, thanks for getting this out here. Any thoughts on wiring up executor command-line flags as a scheduler command-line flag? Should make this relatively easy to wire up, demo, and integration test. Worth a followup review?

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-23 Thread Kevin Sweeney
On July 23, 2014, 5:40 p.m., Kevin Sweeney wrote: Good start, thanks for getting this out here. Any thoughts on wiring up executor command-line flags as a scheduler command-line flag? Should make this relatively easy to wire up, demo, and integration test. Worth a followup review?

Re: Review Request 23872: Fix problem with deschedule command.

2014-07-23 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23872/#review48611 --- Ship it! Ship It! - Maxim Khutornenko On July 23, 2014, 11:54

Re: Review Request 23863: AURORA-587: Example ServerSet Announcer implementation

2014-07-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23863/ --- (Updated July 24, 2014, 2:36 a.m.) Review request for Aurora, Kevin Sweeney

Review Request 23876: AURORA-599 - Reset changelog and version for 0.5.0 rc2

2014-07-23 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23876/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-599