Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-29 Thread Mark Chu-Carroll
Ping, again? David, Joe? This is a really easy one! -Mark On Mon, Jul 28, 2014 at 2:07 PM, Mark Chu-Carroll mchucarr...@apache.org wrote: ping? On Fri, Jul 25, 2014 at 4:50 PM, Mark Chu-Carroll mchucarr...@twopensource.com wrote: This is an automatically generated e-mail. To

Re: Review Request 24042: Add test coverage for Mname.

2014-07-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24042/#review48991 --- Ship it! Ship It! - Maxim Khutornenko On July 29, 2014, 5:27

Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-29 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23949/#review48992 --- Ship it! Ship It! - David McLaughlin On July 25, 2014, 8:50

Re: Review Request 23471: add support for Mesos masters running with --no-root_submissions, see AURORA-311

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/#review48993 --- wickman, ping? - Bill Farner On July 22, 2014, 11:28 p.m.,

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23348/#review48994 --- Ship it! Ship It! - Bill Farner On July 9, 2014, 7:50 p.m.,

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

2014-07-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23348/#review48997 --- Ship it! Ship It! - Kevin Sweeney On July 9, 2014, 12:50 p.m.,

Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs:

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/#review49002 --- Ship it!

Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-29 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23949/#review49009 --- Ship it! Ship It! - David Robinson On July 25, 2014, 8:50 p.m.,

Re: Review Request 22944: Use tasksWithoutConfig on job page

2014-07-29 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22944/#review49010 --- This already has two ship its. Mark, do you mind removing yourself

Review Request 24062: Improve usability of links in the job page.

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24062/ --- Review request for Aurora and David McLaughlin. Bugs: AURORA-561

Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-29 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23949/ --- (Updated July 29, 2014, 2:53 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 22944: Use tasksWithoutConfig on job page

2014-07-29 Thread Bill Farner
On July 29, 2014, 6:52 p.m., David McLaughlin wrote: This already has two ship its. Mark, do you mind removing yourself and adding Bill? FYI - i don't believe Mark will have RB permissions to edit the review. You can feel free to do the swap and proceed with the commit. - Bill

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Bill Farner
On July 29, 2014, 6:18 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/http/AbortCallback.java, line 27 https://reviews.apache.org/r/24059/diff/1/?file=644660#file644660line27 Since this isn't in a library anymore you should be fine replacing this with

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- (Updated July 29, 2014, 7:06 p.m.) Review request for Aurora, Kevin Sweeney

Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/ --- Review request for Aurora, Jake Farrell and Bill Farner. Bugs: AURORA-620

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/#review49014 --- build.gradle https://reviews.apache.org/r/24063/#comment85852

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/#review49015 --- Ship it! Ship It! - Bill Farner On July 29, 2014, 7:14 p.m.,

Re: Review Request 22944: Use tasksWithoutConfig on job page

2014-07-29 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22944/ --- (Updated July 29, 2014, 7:19 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 22944: Use tasksWithoutConfig on job page

2014-07-29 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22944/ --- (Updated July 29, 2014, 7:20 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 24062: Improve usability of links in the job page.

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24062/ --- (Updated July 29, 2014, 8:11 p.m.) Review request for Aurora and David

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/#review49022 --- src/main/java/org/apache/aurora/scheduler/http/ServletModule.java

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- (Updated July 29, 2014, 9:44 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Bill Farner
On July 29, 2014, 8:58 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/http/ServletModule.java, line 124 https://reviews.apache.org/r/24059/diff/2/?file=644918#file644918line124 I thought you wanted to drop it? Hah whoops, that happened in a different

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/#review49042 --- Ship it! Ship It! - Maxim Khutornenko On July 29, 2014, 9:44

Re: Review Request 23315: s/Unsecure/Insecure/

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23315/#review49044 --- Update or discard? - Bill Farner On July 7, 2014, 6:28 p.m.,

Re: Review Request 23330: replace 143 kB favicon with 318 byte version

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/#review49043 --- Reviewers - ping? - Bill Farner On July 8, 2014, 1:18 a.m.,

Re: Review Request 23329: remove embedded jquery

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/#review49045 --- Reviewers - ping? - Bill Farner On July 9, 2014, 9:50 p.m.,

Re: Review Request 22457: Improve aurora job diff command.

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22457/#review49046 --- Mark - looks like this was committed, reverted, then re-committed.

Review Request 24077: Upgrade pants to 0.0.20

2014-07-29 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 23471: add support for Mesos masters running with --no-root_submissions, see AURORA-311

2014-07-29 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23471/#review49047 --- Ship it! Ship It! - Brian Wickman On July 22, 2014, 11:28 p.m.,

Re: Review Request 24077: Upgrade pants to 0.0.20

2014-07-29 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/#review49048 --- Nevermind, I think pants 0.0.20 is actually broken. - Brian

Re: Review Request 22457: Improve aurora job diff command.

2014-07-29 Thread Mark Chu-Carroll
On July 29, 2014, 7:36 p.m., Bill Farner wrote: Mark - looks like this was committed, reverted, then re-committed. If it's now in, can you please close the review? Sadly no. It was committed, reverted, recommitted, reverted, rerecommitted, rerereverted. Why it fails in the hudson

Re: Review Request 24077: Upgrade pants to 0.0.20

2014-07-29 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/ --- (Updated July 29, 2014, 11:50 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 24077: Upgrade pants to 0.0.20

2014-07-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/#review49057 --- Is there a changelog anywhere? - Kevin Sweeney On July 29, 2014,

Re: Review Request 24077: Upgrade pants to 0.0.20

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24077/#review49058 --- Ship it! Can you also run ./build-support/jenkins/build.sh before

Re: Review Request 24059: Replace HttpModule from twitter.common with our own code.

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24059/ --- (Updated July 29, 2014, 11:58 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 24077: Upgrade pants to 0.0.20

2014-07-29 Thread Brian Wickman
On July 29, 2014, 11:54 p.m., Kevin Sweeney wrote: Is there a changelog anywhere? yes, as a matter of fact, they started publishing them just a couple releases ago: https://pypi.python.org/pypi/pantsbuild.pants/0.0.21 - Brian ---

Review Request 24078: Add an InstanceUpdater to fit into rolling update coordination in the scheduler.

2014-07-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24078/ --- Review request for Aurora, David McLaughlin, Kevin Sweeney, and Maxim

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-29 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/#review49076 --- +0, I dont really think that this is necessary and will add

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-29 Thread Bill Farner
On July 30, 2014, 1:55 a.m., Jake Farrell wrote: +0, I dont really think that this is necessary and will add overhead (especially with AURORA-616), thoughts on opening this up on the dev@ list to a wider discussion? +1 to hashing this out in a dev@ discussion. I've had a nervous

Re: Review Request 23329: remove embedded jquery

2014-07-29 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/#review49084 --- Not sure I understand the motivation here. It's generally best to