Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-30 Thread Tobias Weingartner
On July 30, 2014, 1:55 a.m., Jake Farrell wrote: +0, I dont really think that this is necessary and will add overhead (especially with AURORA-616), thoughts on opening this up on the dev@ list to a wider discussion? Bill Farner wrote: +1 to hashing this out in a dev@ discussion.

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-30 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24063/#review49114 --- Ship it! Ship It! - Mark Chu-Carroll On July 29, 2014, 3:14

Re: Review Request 23329: remove embedded jquery

2014-07-30 Thread David Robinson
On July 30, 2014, 4:25 a.m., David McLaughlin wrote: Not sure I understand the motivation here. It's generally best to host your own static assets. Users typically debug their Aurora jobs by looking at individual instances, which usually involves accessing the web interfaces (provided by

Re: Review Request 23329: remove embedded jquery

2014-07-30 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329/#review49153 --- ./src/main/python/apache/thermos/observer/http/assets/jquery*

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

2014-07-30 Thread Bill Farner
On July 29, 2014, 5:32 p.m., Kevin Sweeney wrote: Ship It! How did the tests go on this? Ready to submit? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23348/#review48997

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

2014-07-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23348/#review49156 --- This patch fails to apply - Dominic, would you mind rebasing? -

Re: Review Request 24063: Use JCenter over HTTPS instead of Maven Central

2014-07-30 Thread Kevin Sweeney
On July 29, 2014, 6:55 p.m., Jake Farrell wrote: +0, I dont really think that this is necessary and will add overhead (especially with AURORA-616), thoughts on opening this up on the dev@ list to a wider discussion? Bill Farner wrote: +1 to hashing this out in a dev@ discussion.

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

2014-07-30 Thread Dominic Hamon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23348/ --- (Updated July 30, 2014, 1:25 p.m.) Review request for Aurora, Joe Smith, Kevin

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

2014-07-30 Thread Dominic Hamon
On July 30, 2014, 1:23 p.m., Kevin Sweeney wrote: This patch fails to apply - Dominic, would you mind rebasing? rebased. didn't see any rebasing issues though. - Dominic --- This is an automatically generated e-mail. To reply,

Review Request 24116: Defining stubs for the Update APIs.

2014-07-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-611

Re: Review Request 24116: Defining stubs for the Update APIs.

2014-07-30 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49170 ---

Re: Review Request 24116: Defining stubs for the Update APIs.

2014-07-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49168 ---

Re: Review Request 24116: Defining stubs for the Update APIs.

2014-07-30 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24116/#review49171 --- src/main/thrift/org/apache/aurora/gen/api.thrift

Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24126/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-626

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24126/ --- (Updated July 30, 2014, 11:59 p.m.) Review request for Aurora, Kevin Sweeney,

Re: Review Request 23330: replace 143 kB favicon with 318 byte version

2014-07-30 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/ --- (Updated July 31, 2014, 12:13 a.m.) Review request for Aurora, David

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24126/#review49185 --- src/main/python/apache/aurora/client/api/updater.py

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Maxim Khutornenko
On July 31, 2014, 12:19 a.m., Bill Farner wrote: src/main/python/apache/aurora/client/api/updater.py, line 242 https://reviews.apache.org/r/24126/diff/1/?file=646402#file646402line242 Nit - this flag is only gated on if not. Consider inverting the meaning of the flag and don't

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Bill Farner
On July 31, 2014, 12:19 a.m., Bill Farner wrote: src/test/python/apache/aurora/client/api/test_updater.py, line 821 https://reviews.apache.org/r/24126/diff/1/?file=646405#file646405line821 Can you add two more test cases with batch_size 1: - instances % batch_size ==

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Maxim Khutornenko
On July 31, 2014, 12:19 a.m., Bill Farner wrote: src/test/python/apache/aurora/client/api/test_updater.py, line 821 https://reviews.apache.org/r/24126/diff/1/?file=646405#file646405line821 Can you add two more test cases with batch_size 1: - instances % batch_size ==

Re: Review Request 24126: Adding a wait_for_batch_completion option into parallel updater.

2014-07-30 Thread Maxim Khutornenko
On July 31, 2014, 12:19 a.m., Bill Farner wrote: src/test/python/apache/aurora/client/api/test_updater.py, line 821 https://reviews.apache.org/r/24126/diff/1/?file=646405#file646405line821 Can you add two more test cases with batch_size 1: - instances % batch_size ==