Re: Review Request 24727: Store a lock association with job updates.

2014-08-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24727/#review50723 ---

Re: Review Request 24727: Store a lock association with job updates.

2014-08-15 Thread Bill Farner
On Aug. 15, 2014, 3:47 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, lines 1293-1299 https://reviews.apache.org/r/24727/diff/2/?file=661215#file661215line1293 Why this change? The lock is supposed to be already

Re: Review Request 24727: Store a lock association with job updates.

2014-08-15 Thread Maxim Khutornenko
On Aug. 15, 2014, 3:47 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, lines 1293-1299 https://reviews.apache.org/r/24727/diff/2/?file=661215#file661215line1293 Why this change? The lock is supposed to be already

Re: Review Request 24727: Store a lock association with job updates.

2014-08-15 Thread Bill Farner
On Aug. 15, 2014, 3:47 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, lines 1293-1299 https://reviews.apache.org/r/24727/diff/2/?file=661215#file661215line1293 Why this change? The lock is supposed to be already

Re: Review Request 24727: Store a lock association with job updates.

2014-08-15 Thread Maxim Khutornenko
On Aug. 15, 2014, 3:47 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, lines 1293-1299 https://reviews.apache.org/r/24727/diff/2/?file=661215#file661215line1293 Why this change? The lock is supposed to be already

Re: Review Request 24727: Store a lock association with job updates.

2014-08-15 Thread Bill Farner
On Aug. 15, 2014, 3:47 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, lines 1293-1299 https://reviews.apache.org/r/24727/diff/2/?file=661215#file661215line1293 Why this change? The lock is supposed to be already

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-15 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/ --- (Updated Aug. 15, 2014, 5:52 p.m.) Review request for Aurora, Maxim

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50752 --- src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-15 Thread David McLaughlin
On Aug. 15, 2014, 6:02 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 558 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line558 Rolling back assumes removing new (INSTANCE_REMOVED) and adding old (INSTANCE_ADDED). Do we

Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24744/ --- Review request for Aurora, Mark Chu-Carroll and Bill Farner. Repository:

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24744/#review50755 --- src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Maxim Khutornenko
On Aug. 15, 2014, 6:20 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 751 https://reviews.apache.org/r/24744/diff/1/?file=661623#file661623line751 We really should not expose the lock. Any attempt to do anything with the lock will ~certainly

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Maxim Khutornenko
On Aug. 15, 2014, 6:20 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 751 https://reviews.apache.org/r/24744/diff/1/?file=661623#file661623line751 We really should not expose the lock. Any attempt to do anything with the lock will ~certainly

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Bill Farner
On Aug. 15, 2014, 6:20 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 751 https://reviews.apache.org/r/24744/diff/1/?file=661623#file661623line751 We really should not expose the lock. Any attempt to do anything with the lock will ~certainly

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-15 Thread Maxim Khutornenko
On Aug. 15, 2014, 6:20 p.m., Bill Farner wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 751 https://reviews.apache.org/r/24744/diff/1/?file=661623#file661623line751 We really should not expose the lock. Any attempt to do anything with the lock will ~certainly

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50805 --- src/main/thrift/org/apache/aurora/gen/api.thrift