Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread David McLaughlin
On Aug. 15, 2014, 6:02 p.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 558 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line558 Rolling back assumes removing new (INSTANCE_REMOVED) and adding old (INSTANCE_ADDED). Do we

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread David McLaughlin
On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 538 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538 What action is going to be used for an instance that failed to update and the job rollback is

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24744/#review50900 --- Ship it! Ship It! - Bill Farner On Aug. 15, 2014, 11:57 p.m.,

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Bill Farner
On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 538 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538 What action is going to be used for an instance that failed to update and the job rollback is

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Bill Farner
On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 538 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538 What action is going to be used for an instance that failed to update and the job rollback is

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Maxim Khutornenko
On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 538 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538 What action is going to be used for an instance that failed to update and the job rollback is

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Bill Farner
On Aug. 16, 2014, 12:23 a.m., Maxim Khutornenko wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 538 https://reviews.apache.org/r/24720/diff/2/?file=661560#file661560line538 What action is going to be used for an instance that failed to update and the job rollback is

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/ --- (Updated Aug. 18, 2014, 5:49 p.m.) Review request for Aurora, Maxim

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50910 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 18, 2014, 5:49

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/#review50911 --- Ship it! Ship It! - Bill Farner On Aug. 18, 2014, 5:49 p.m.,

Re: Review Request 24720: Expand actions in JobUpdateAction

2014-08-18 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24720/ --- (Updated Aug. 18, 2014, 5:59 p.m.) Review request for Aurora, Maxim

Review Request 24813: Add a job update controller interface.

2014-08-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24813/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-613

Review Request 24815: Refactoring SchedulerCore final part.

2014-08-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24815/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-94

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24744/ --- (Updated Aug. 18, 2014, 8:10 p.m.) Review request for Aurora, Mark Chu-Carroll

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-18 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24744/#review50930 --- Ship it! Looks fine, but I don't really understand the reasoning.

Re: Review Request 24744: Dropping lock from startJobUpdate parameters.

2014-08-18 Thread Maxim Khutornenko
On Aug. 18, 2014, 8:16 p.m., Mark Chu-Carroll wrote: Looks fine, but I don't really understand the reasoning. To me, it seems like expecting someone to have a lockid for a pause or a resume call is a good idea. It allows someone to pass responsibility for an ongoing update to

Re: Review Request 24813: Add a job update controller interface.

2014-08-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24813/#review50935 --- Ship it!

Re: Review Request 24813: Add a job update controller interface.

2014-08-18 Thread Bill Farner
On Aug. 18, 2014, 9:14 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, line 64 https://reviews.apache.org/r/24813/diff/1/?file=662707#file662707line64 s/../. Fixed. - Bill

Re: Review Request 24813: Add a job update controller interface.

2014-08-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24813/ --- (Updated Aug. 18, 2014, 9:19 p.m.) Review request for Aurora and Maxim

Review Request 24823: Use convenience function in Numbers to group instance IDs.

2014-08-18 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24823/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 24823: Use convenience function in Numbers to group instance IDs.

2014-08-18 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24823/#review50941 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 18, 2014, 11:33