Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/#review50974 --- src/main/python/apache/aurora/client/cli/jobs.py

Re: Review Request 24827: Add a pubsub event adapter to the JobUpdateController.

2014-08-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24827/#review50976 ---

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Mark Chu-Carroll
On Aug. 19, 2014, 11:47 a.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, lines 119-121 https://reviews.apache.org/r/24852/diff/1/?file=664290#file664290line119 General question: what happens to a message returned by the response in case of error?

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/#review50981 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 19, 2014, 3:22

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Maxim Khutornenko
On Aug. 19, 2014, 3:47 p.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/client/cli/test_create.py, lines 233-234 https://reviews.apache.org/r/24852/diff/1/?file=664291#file664291line233 This is the existing test, right? Diff shows it in green for some reason...

Re: Review Request 24827: Add a pubsub event adapter to the JobUpdateController.

2014-08-19 Thread Bill Farner
On Aug. 19, 2014, 3:58 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, line 74 https://reviews.apache.org/r/24827/diff/1/?file=663946#file663946line74 A TODO to follow up on deleted flag removal? Removed now, thanks for

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Mark Chu-Carroll
On Aug. 19, 2014, 11:47 a.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/client/cli/test_create.py, lines 233-234 https://reviews.apache.org/r/24852/diff/1/?file=664291#file664291line233 This is the existing test, right? Diff shows it in green for some reason...

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread Maxim Khutornenko
On Aug. 19, 2014, 3:47 p.m., Maxim Khutornenko wrote: src/test/python/apache/aurora/client/cli/test_create.py, lines 233-234 https://reviews.apache.org/r/24852/diff/1/?file=664291#file664291line233 This is the existing test, right? Diff shows it in green for some reason...

Re: Review Request 24835: Implementing pause/resume/abort APIs.

2014-08-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24835/#review50992 --- Ship it! LGTM mod separation of concerns on

Re: Review Request 24852: Add command output tests for job create, job killall, job kill

2014-08-19 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24852/#review50994 --- Ship it! Ship It! - David McLaughlin On Aug. 19, 2014, 3:22

Re: Review Request 24827: Add a pubsub event adapter to the JobUpdateController.

2014-08-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24827/#review50995 --- Ship it! Ship It! - Maxim Khutornenko On Aug. 19, 2014, 5:43

Re: Review Request 24827: Add a pubsub event adapter to the JobUpdateController.

2014-08-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24827/ --- (Updated Aug. 19, 2014, 5:49 p.m.) Review request for Aurora and Maxim

Re: Review Request 24827: Add a pubsub event adapter to the JobUpdateController.

2014-08-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24827/ --- (Updated Aug. 19, 2014, 5:43 p.m.) Review request for Aurora and Maxim

Re: Review Request 24752: combine finalization_wait when combining tasks

2014-08-19 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24752/#review50997 --- src/main/python/apache/thermos/config/schema_helpers.py

Re: Review Request 24835: Implementing pause/resume/abort APIs.

2014-08-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24835/ --- (Updated Aug. 19, 2014, 6:33 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 24662: Implementing job update get thrift APIs.

2014-08-19 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24662/#review51008 --- Ship it!

Re: Review Request 24662: Implementing job update get thrift APIs.

2014-08-19 Thread Maxim Khutornenko
On Aug. 19, 2014, 6:37 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1284 https://reviews.apache.org/r/24662/diff/3/?file=660762#file660762line1284 Push the requireNonNull out to the first line to avoid even opening

Re: Review Request 24662: Implementing job update get thrift APIs.

2014-08-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24662/ --- (Updated Aug. 19, 2014, 6:56 p.m.) Review request for Aurora, David McLaughlin

Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-19 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/ --- Review request for Aurora, Joe Smith and Mark Chu-Carroll. Bugs: AURORA-43

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-19 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51045 --- Ship it! Ship It! - David Robinson On Aug. 19, 2014, 10:51