Re: Review Request 25255: Implement server-driven update commands.

2014-09-11 Thread Mark Chu-Carroll
On Sept. 3, 2014, 3:58 p.m., Maxim Khutornenko wrote: src/main/python/apache/aurora/client/cli/jobs.py, line 667 https://reviews.apache.org/r/25255/diff/1/?file=673959#file673959line667 How about a BROWSER_OPTION for all update commands (start/pause/resume/abort)? It will,

Re: Review Request 25255: Implement server-driven update commands.

2014-09-11 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25255/#review53030 --- I was about to ping about this, when I discovered that my replies

Review Request 25543: Update to pants 0.0.23.

2014-09-11 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25543/ --- Review request for Aurora, Joe Smith and Brian Wickman. Bugs: aurora-695

Re: Review Request 25543: Update to pants 0.0.23.

2014-09-11 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25543/#review53048 --- Ship it! Ship It! - Zameer Manji On Sept. 11, 2014, 9:13 a.m.,

Re: Review Request 25481: Adding JobUpdateRequest validation.

2014-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review53061 --- Aha, i thought you wanted this done down in JobUpdateController, so

Re: Review Request 25481: Adding JobUpdateRequest validation.

2014-09-11 Thread Maxim Khutornenko
On Sept. 11, 2014, 5:54 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1371 https://reviews.apache.org/r/25481/diff/1/?file=684118#file684118line1371 I believe this will not surface nicely to the user, but will

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-11 Thread Mark Chu-Carroll
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review53071 --- Ship it! Ship It! - Mark Chu-Carroll On Sept. 10, 2014, 6:43

Re: Review Request 25481: Adding JobUpdateRequest validation.

2014-09-11 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25481/#review53073 ---

Re: Review Request 25481: Adding JobUpdateRequest validation.

2014-09-11 Thread Maxim Khutornenko
On Sept. 11, 2014, 6:13 p.m., Zameer Manji wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1371 https://reviews.apache.org/r/25481/diff/1/?file=684118#file684118line1371 I'm a little unfamilar with JobUpdateRequest and this RPC but it

Review Request 25548: Apply GzipFilter to POSTs as well as GETs

2014-09-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25548/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-697

Re: Review Request 25481: Adding JobUpdateRequest validation.

2014-09-11 Thread Bill Farner
On Sept. 11, 2014, 5:54 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1371 https://reviews.apache.org/r/25481/diff/1/?file=684118#file684118line1371 I believe this will not surface nicely to the user, but will

Re: Review Request 25548: Apply GzipFilter to POSTs as well as GETs

2014-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25548/#review53084 --- Ship it! Ship It! - Bill Farner On Sept. 11, 2014, 6:20 p.m.,

Re: Review Request 25529: Add a controller for job updates.

2014-09-11 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/#review53075 --- This matches the logic previously explained to me, but the diff is

Re: Review Request 25481: Adding JobUpdateRequest validation.

2014-09-11 Thread Maxim Khutornenko
On Sept. 11, 2014, 5:54 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1371 https://reviews.apache.org/r/25481/diff/1/?file=684118#file684118line1371 I believe this will not surface nicely to the user, but will

Review Request 25552: Show reason for PENDING state in Scheduler UI

2014-09-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25552/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs:

Re: Review Request 25548: Apply GzipFilter to POSTs as well as GETs

2014-09-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25548/#review53105 --- Ship it! Ship It! - David McLaughlin On Sept. 11, 2014, 6:20

Re: Review Request 25548: Apply GzipFilter to POSTs as well as GETs

2014-09-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25548/#review53109 --- Pushed to Apache master. - David McLaughlin On Sept. 11, 2014,

Review Request 25556: Dropping synchronized from validateIfLocked()

2014-09-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25556/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 25556: Dropping synchronized from validateIfLocked()

2014-09-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25556/ --- (Updated Sept. 11, 2014, 9:08 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 25391: Add information about log initialisation step.

2014-09-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25391/#review53110 --- Thanks Joseph! Pushed to master. - David McLaughlin On Sept. 5,

Re: Review Request 25552: Show reason for PENDING state in Scheduler UI

2014-09-11 Thread David McLaughlin
On Sept. 11, 2014, 8:45 p.m., Joshua Cohen wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js, line 90 https://reviews.apache.org/r/25552/diff/1/?file=686507#file686507line90 I think this could just be: _.indexBy(reasons, 'taskId') Good

Re: Review Request 25552: Show reason for PENDING state in Scheduler UI

2014-09-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25552/ --- (Updated Sept. 11, 2014, 9:55 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 25556: Dropping synchronized from validateIfLocked()

2014-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25556/#review53121 --- Ship it! Please add a TODO for test coverage. Testing this for

Re: Review Request 25552: Show reason for PENDING state in Scheduler UI

2014-09-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25552/#review53123 --- Ship it! Ship It! - Joshua Cohen On Sept. 11, 2014, 9:55 p.m.,

Re: Review Request 25529: Add a controller for job updates.

2014-09-11 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/#review53101 --- Some of these questions are probably non-sensical due to my limited

Re: Review Request 25556: Dropping synchronized from validateIfLocked()

2014-09-11 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25556/#review53129 --- Feel free to merge in this test case if it's to your liking:

Re: Review Request 25529: Add a controller for job updates.

2014-09-11 Thread Bill Farner
On Sept. 11, 2014, 6:51 p.m., Zameer Manji wrote: build.gradle, line 262 https://reviews.apache.org/r/25529/diff/1/?file=685001#file685001line262 Is this needed? If so please break it out of this change. Context: this has code coverage run without adding -Pq Happy to pull this out

Re: Review Request 25529: Add a controller for job updates.

2014-09-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25529/#review53051 --- src/main/java/org/apache/aurora/scheduler/base/Query.java

Re: Review Request 25556: Dropping synchronized from validateIfLocked()

2014-09-11 Thread Maxim Khutornenko
On Sept. 11, 2014, 10:45 p.m., Bill Farner wrote: Feel free to merge in this test case if it's to your liking: https://github.com/wfarner/incubator-aurora/commit/a62f794c6052f6abfa53197dede7f6d21f80f4e4 Big thanks for the patch! Updated. - Maxim

Re: Review Request 25556: Dropping synchronized from validateIfLocked()

2014-09-11 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25556/ --- (Updated Sept. 12, 2014, 12:13 a.m.) Review request for Aurora and Bill