Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26469/#review55979 --- Ship it! Ship It! - Bill Farner On Oct. 9, 2014, 12:15 a.m.,

Re: Review Request 26394: Deprecating Identity struct (renaming fields).

2014-10-09 Thread Bill Farner
On Oct. 9, 2014, 12:05 a.m., Bill Farner wrote: Thanks again for leading this - i'm very happy to see momentum on removing `Identity`. Stepping back - i wonder if we should re-evaluate the way we do field deprecations now that we've established a protocol with JIRA and releases.

Re: Review Request 26376: Implementing non-prod MTTA/R SLA metrics.

2014-10-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26376/#review55984 --- Ship it!

Re: Review Request 26383: Health Check Disabler

2014-10-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26383/#review55985 --- src/main/python/apache/aurora/executor/common/health_checker.py

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/#review55986 ---

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Bill Farner
On Oct. 9, 2014, 2:32 p.m., Bill Farner wrote: Ship It! Hmm, i'm now getting a different coverage error when preparing to submit this: * What went wrong: Execution failed for task ':jacocoTestReport'. Thanks for adding the first test coverage to:

Re: Review Request 26425: Fixing quota checking for updates.

2014-10-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26425/#review55991 --- Ship it! Ship It! - Bill Farner On Oct. 8, 2014, 10:58 p.m.,

Re: Review Request 26383: Health Check Disabler

2014-10-09 Thread Zameer Manji
On Oct. 9, 2014, 7:53 a.m., Bill Farner wrote: src/main/python/apache/aurora/executor/common/health_checker.py, line 66 https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66 FWIW i actually meant to suggest that the snooze has no concept of time at all. If the

Re: Review Request 26383: Health Check Disabler

2014-10-09 Thread Kevin Sweeney
On Oct. 9, 2014, 7:53 a.m., Bill Farner wrote: src/main/python/apache/aurora/executor/common/health_checker.py, line 66 https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66 FWIW i actually meant to suggest that the snooze has no concept of time at all. If the

Review Request 26504: Restore JDK8 compatibility

2014-10-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26504/ --- Review request for Aurora, Maxim Khutornenko and Zameer Manji. Repository:

Re: Review Request 26504: Restore JDK8 compatibility

2014-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26504/#review56003 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 9, 2014, 4:50

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Joshua Cohen
Nope, it's passing for me, but it's similar to the behavior I was seeing with ApiBeta$2; even after cleaning the reports directory I was *not* getting the failure about it missing coverage even though it actually was. On Thu, Oct 9, 2014 at 8:32 AM, Bill Farner wfar...@apache.org wrote: This

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Joshua Cohen
I can also verify that running the entire test suite in a debugger, a breakpoint set in OfferQueue$OfferQueueImpl$2 is not hit. On Thu, Oct 9, 2014 at 10:05 AM, Joshua Cohen jco...@twopensource.com wrote: Nope, it's passing for me, but it's similar to the behavior I was seeing with ApiBeta$2;

Re: Review Request 26504: Restore JDK8 compatibility

2014-10-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26504/#review56011 --- Ship it! Ship It! - Joshua Cohen On Oct. 9, 2014, 4:50 p.m.,

Re: Review Request 26504: Restore JDK8 compatibility

2014-10-09 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26504/#review56012 --- Ship it! Ship It! - Zameer Manji On Oct. 9, 2014, 9:50 a.m.,

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26478/#review56010 ---

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Bill Farner
Can you post your xml report to a ticket? It might help get to the bottom of this flakiness. On Thursday, October 9, 2014, Joshua Cohen jco...@twopensource.com wrote: I can also verify that running the entire test suite in a debugger, a breakpoint set in OfferQueue$OfferQueueImpl$2 is not hit.

Re: Review Request 26383: Health Check Disabler

2014-10-09 Thread Zameer Manji
On Oct. 9, 2014, 7:53 a.m., Bill Farner wrote: src/main/python/apache/aurora/executor/common/health_checker.py, line 66 https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66 FWIW i actually meant to suggest that the snooze has no concept of time at all. If the

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Zameer Manji
Applying the patch, cleaning my reports directory and then running `./gradlew clean build` produces no error for me. I can share my xml report if needed. On Thu, Oct 9, 2014 at 10:42 AM, Bill Farner wfar...@apache.org wrote: Can you post your xml report to a ticket? It might help get to the

Re: Review Request 26383: Health Check Disabler

2014-10-09 Thread David Pan
On Oct. 9, 2014, 2:53 p.m., Bill Farner wrote: src/main/python/apache/aurora/executor/common/health_checker.py, line 66 https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66 FWIW i actually meant to suggest that the snooze has no concept of time at all. If the

Re: Review Request 26469: Kill code to serve ApiBeta help pages that's no longer used now that the content is served directly.

2014-10-09 Thread Joshua Cohen
Filed https://issues.apache.org/jira/browse/AURORA-822 and attached my report. On Thu, Oct 9, 2014 at 11:29 AM, Zameer Manji zma...@twopensource.com wrote: Applying the patch, cleaning my reports directory and then running `./gradlew clean build` produces no error for me. I can share my xml

Re: Review Request 26383: Health Check Disabler

2014-10-09 Thread Kevin Sweeney
On Oct. 9, 2014, 7:53 a.m., Bill Farner wrote: src/main/python/apache/aurora/executor/common/health_checker.py, line 66 https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66 FWIW i actually meant to suggest that the snooze has no concept of time at all. If the

Re: Review Request 26376: Implementing non-prod MTTA/R SLA metrics.

2014-10-09 Thread Maxim Khutornenko
On Oct. 9, 2014, 2:46 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/sla/MetricCalculatorTest.java, line 59 https://reviews.apache.org/r/26376/diff/1/?file=714221#file714221line59 Can you instead export these values into a MapString, AtomicLong and validate

Re: Review Request 26376: Implementing non-prod MTTA/R SLA metrics.

2014-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26376/ --- (Updated Oct. 9, 2014, 9:04 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 26383: Health Check Disabler

2014-10-09 Thread David Pan
On Oct. 9, 2014, 2:53 p.m., Bill Farner wrote: src/main/python/apache/aurora/executor/common/health_checker.py, line 66 https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66 FWIW i actually meant to suggest that the snooze has no concept of time at all. If the

Re: Review Request 26383: Health Check Disabler

2014-10-09 Thread Joshua Cohen
I feel like we should err on the side of correctness here, rather than simplicity? The dangers of someone accidentally leaving health checks disabled indefinitely (on a service that has opted in to health checks) are not insignificant. On Thu, Oct 9, 2014 at 1:34 PM, Kevin Sweeney

Re: Review Request 26383: Health Check Disabler

2014-10-09 Thread Joshua Cohen
On Oct. 9, 2014, 2:53 p.m., Bill Farner wrote: src/main/python/apache/aurora/executor/common/health_checker.py, line 66 https://reviews.apache.org/r/26383/diff/3/?file=716355#file716355line66 FWIW i actually meant to suggest that the snooze has no concept of time at all. If the

Re: Review Request 26478: Add a flag to deduplicate storage snapshots

2014-10-09 Thread Kevin Sweeney
On Oct. 9, 2014, 10:30 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotDeduplicator.java, line 133 https://reviews.apache.org/r/26478/diff/2/?file=716380#file716380line133 There is a remote possibility of numOutputTasks to be zero in a

Re: Review Request 26431: Moving post_drain script execution into host_maintenance.py

2014-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26431/#review56076 --- Ping, Mark. - Maxim Khutornenko On Oct. 8, 2014, 11:46 p.m.,

Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review56080 --- Ship it! src/main/thrift/org/apache/aurora/gen/api.thrift

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/ --- (Updated Oct. 9, 2014, 11:23 p.m.) Review request for Aurora, David

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-09 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26531/#review56083 --- Ship it! Ship It! - David McLaughlin On Oct. 9, 2014, 11:23

Re: Review Request 26531: Defining schema for the heartbeat RPC.

2014-10-09 Thread Maxim Khutornenko
On Oct. 9, 2014, 11:20 p.m., David McLaughlin wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 619 https://reviews.apache.org/r/26531/diff/1/?file=717117#file717117line619 I think we decided not to do auto-resume once a job is paused due to lack of heartbeat, but I