Re: Review Request 27309: Make executor overhead configurable via CLI.

2014-10-29 Thread Zameer Manji
On Oct. 28, 2014, 3:14 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/ResourceSlot.java, line 36 https://reviews.apache.org/r/27309/diff/1/?file=735736#file735736line36 Is there a jira w/ more context? If not can there be? It's not clear to me from looking at

Re: Review Request 27309: Make executor overhead configurable via CLI.

2014-10-29 Thread Joshua Cohen
On Oct. 28, 2014, 10:14 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/ResourceSlot.java, line 36 https://reviews.apache.org/r/27309/diff/1/?file=735736#file735736line36 Is there a jira w/ more context? If not can there be? It's not clear to me from looking

Re: Review Request 27309: Make executor overhead configurable via CLI.

2014-10-29 Thread Zameer Manji
On Oct. 28, 2014, 3:14 p.m., Joshua Cohen wrote: src/main/java/org/apache/aurora/scheduler/ResourceSlot.java, line 36 https://reviews.apache.org/r/27309/diff/1/?file=735736#file735736line36 Is there a jira w/ more context? If not can there be? It's not clear to me from looking at

Re: Review Request 27309: Make executor overhead configurable via CLI.

2014-10-29 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27309/ --- (Updated Oct. 29, 2014, 12:54 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27309: Make executor overhead configurable via CLI.

2014-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27309/#review59039 --- Ship it! Master (978998a) is green with this patch.

Re: Review Request 27309: Make executor overhead configurable via CLI.

2014-10-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27309/#review59044 --- Ship it! Ship It! - Joshua Cohen On Oct. 29, 2014, 7:54 p.m.,

Re: Review Request 27309: Make executor overhead configurable via CLI.

2014-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27309/#review59051 --- Ship it! This is now on master $ git log -1 origin/master

Review Request 27352: Cleaning up old vagrant cluster names.

2014-10-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27352/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 27352: Cleaning up old vagrant cluster names.

2014-10-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27352/#review59056 --- Ship it! Ship It! - Kevin Sweeney On Oct. 29, 2014, 3:21 p.m.,

Re: Review Request 27352: Cleaning up old vagrant cluster names.

2014-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27352/#review59062 --- Ship it! Master (6b30cf7) is green with this patch.

Re: Review Request 27352: Cleaning up old vagrant cluster names.

2014-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27352/#review59067 --- Ship it! Ship It! - Bill Farner On Oct. 29, 2014, 10:21 p.m.,

Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- Review request for Aurora, Jake Farrell and Kevin Sweeney. Bugs: AURORA-711

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59072 --- Ship it! Ship It! - Kevin Sweeney On Oct. 29, 2014, 4:19 p.m.,

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59074 --- Ship it! Consider adding a README file under

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59076 --- Ship it! Master (6b30cf7) is green with this patch.

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Bill Farner
On Oct. 29, 2014, 11:32 p.m., Maxim Khutornenko wrote: Consider adding a README file under /src/resources/org/apache/thermos/root/checkpoints with the link to this document to improve discoverablity. Good call, done. - Bill

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/ --- (Updated Oct. 29, 2014, 11:38 p.m.) Review request for Aurora, Jake Farrell

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59080 --- Would this be a good time to suggest moving these to

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59081 --- Ship it! Master (6b30cf7) is green with this patch.

Review Request 27363: Add explicit test coverage for stat gauge in TaskSchedulerImpl.

2014-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27363/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs:

Re: Review Request 27363: Add explicit test coverage for stat gauge in TaskSchedulerImpl.

2014-10-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27363/#review59084 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 30, 2014, 12:14

Re: Review Request 27363: Add explicit test coverage for stat gauge in TaskSchedulerImpl.

2014-10-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27363/#review59085 --- Ship it! Ship It! - Joshua Cohen On Oct. 30, 2014, 12:14 a.m.,

Re: Review Request 27363: Add explicit test coverage for stat gauge in TaskSchedulerImpl.

2014-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27363/#review59090 --- Ship it! Master (6b30cf7) is green with this patch.

Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27364/ --- Review request for Aurora, Joshua Cohen, Bill Farner, and Brian Wickman.

Review Request 27365: Add FakeStatsProvider and check stat values in SchedulerLifecycleTest.

2014-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27365/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs:

Re: Review Request 27365: Add FakeStatsProvider and check stat values in SchedulerLifecycleTest.

2014-10-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27365/#review59092 --- Ship it! Ship It! - Joshua Cohen On Oct. 30, 2014, 12:44 a.m.,

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27364/#review59093 --- It feels a bit strange to change actual code for the sake of an

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27364/#review59094 --- Ship it! Master (6b30cf7) is green with this patch.

Re: Review Request 27365: Add FakeStatsProvider and check stat values in SchedulerLifecycleTest.

2014-10-29 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27365/#review59095 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 30, 2014, 12:44

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-29 Thread Kevin Sweeney
On Oct. 29, 2014, 5:56 p.m., Joshua Cohen wrote: It feels a bit strange to change actual code for the sake of an IDE? The relative imports I'm fine with, but adding the BadZipFile error handling feels off to me. Not necessarily a -1 on this, but I'm curious if there's an alternative.

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27364/ --- (Updated Oct. 29, 2014, 6:05 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-29 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27364/ --- (Updated Oct. 29, 2014, 6:06 p.m.) Review request for Aurora, Joshua Cohen,

Re: Review Request 27365: Add FakeStatsProvider and check stat values in SchedulerLifecycleTest.

2014-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27365/#review59100 --- Ship it! Master (0f63e8f) is green with this patch.

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Jake Farrell
On Oct. 29, 2014, 11:49 p.m., Kevin Sweeney wrote: Would this be a good time to suggest moving these to src/test/resources to match other conventions? As far as I can tell it should be a quick sed one-liner. +1 - Jake --- This

Re: Review Request 27357: Document thermos checkpoint files, include them in git archives.

2014-10-29 Thread Jake Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27357/#review59111 --- Ship it! Ship It! - Jake Farrell On Oct. 29, 2014, 11:38 p.m.,

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-29 Thread Joshua Cohen
On Oct. 30, 2014, 12:56 a.m., Joshua Cohen wrote: It feels a bit strange to change actual code for the sake of an IDE? The relative imports I'm fine with, but adding the BadZipFile error handling feels off to me. Not necessarily a -1 on this, but I'm curious if there's an

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-29 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27364/#review59135 --- Ship it! lgtm modulo questions below.

Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-29 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371/ --- Review request for Aurora, Joshua Cohen and Maxim Khutornenko. Bugs:

Re: Review Request 27371: Add stat gauge coverage for AsyncModule and MemStorage.

2014-10-29 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27371/#review59140 --- Ship it! Master (d85e616) is green with this patch.

Re: Review Request 27364: Add a script to generate a PyCharm-compatible virtualenv.

2014-10-29 Thread Kevin Sweeney
On Oct. 29, 2014, 9:41 p.m., Joshua Cohen wrote: src/test/python/apache/aurora/executor/test_executor_builds.py, line 32 https://reviews.apache.org/r/27364/diff/1/?file=742184#file742184line32 It's pip installable for linux, right? Can we do skipif platform != linux?