---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27375/
---
Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27375/#review59143
---
Ship it!
Master (d85e616) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27375/#review59162
---
Ship it!
One down...
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27364/#review59205
---
Ship it!
build-support/python/make-pycharm-virtualenv
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/#review59206
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27317/#review59208
---
Please excuse me if this seems like nit-picking, i'm just searching
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27357/#review59223
---
Ship it!
Master (d85e616) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/#review59224
---
Ship it!
On Oct. 30, 2014, 4:41 a.m., Joshua Cohen wrote:
build-support/python/make-pycharm-virtualenv, line 24
https://reviews.apache.org/r/27364/diff/1/?file=742139#file742139line24
should we write this under build-support/python? or does pycharm
require this in the root?
Kevin
On Oct. 30, 2014, 4:16 p.m., Bill Farner wrote:
src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java, line 420
https://reviews.apache.org/r/27317/diff/1/?file=736703#file736703line420
Is there a reason we don't use `Resources` here? Seems like you could
leverage it
On Oct. 30, 2014, 8:31 a.m., Bill Farner wrote:
build-support/python/make-pycharm-virtualenv, line 3
https://reviews.apache.org/r/27364/diff/1/?file=742139#file742139line3
Double-check the license header, we don't include the year.
Fixed.
- Kevin
On Oct. 29, 2014, 9:41 p.m., Joshua Cohen wrote:
src/test/python/apache/aurora/executor/test_executor_builds.py, line 32
https://reviews.apache.org/r/27364/diff/1/?file=742184#file742184line32
It's pip installable for linux, right?
Can we do skipif platform != linux?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27364/#review59231
---
Master (d85e616) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27364/
---
(Updated Oct. 30, 2014, 10:23 a.m.)
Review request for Aurora, Joshua Cohen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27371/#review59232
---
Ship it!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27364/#review59234
---
Master (d85e616) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27364/
---
(Updated Oct. 30, 2014, 10:49 a.m.)
Review request for Aurora, Joshua Cohen,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27364/#review59235
---
Ship it!
Master (d85e616) is green with this patch.
18 matches
Mail list logo