Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-03 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 3, 2014, 2:49 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59573 --- Ship it! Master (9186f2e) is green with this patch.

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

2014-11-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/#review59591 --- Ship it!

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27317/#review59599 --- Ping. - Maxim Khutornenko On Oct. 30, 2014, 5:11 p.m., Maxim

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Maxim Khutornenko
On Nov. 3, 2014, 6:38 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java, line 16 https://reviews.apache.org/r/27317/diff/1/?file=736702#file736702line16 java.util.Objects Done. On Nov. 3, 2014, 6:38 p.m., Kevin Sweeney wrote:

Re: Review Request 27317: Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27317/ --- (Updated Nov. 3, 2014, 6:52 p.m.) Review request for Aurora, Kevin Sweeney and

Review Request 27538: Optionally ignore unknown transaction operations.

2014-11-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27538/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 27538: Optionally ignore unknown transaction operations.

2014-11-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27538/#review59631 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 3, 2014, 8:30

Re: Review Request 27538: Optionally ignore unknown transaction operations.

2014-11-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27538/#review59633 --- Master (1149d7a) is red with this patch.

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

2014-11-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/ --- (Updated Nov. 3, 2014, 9:25 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

2014-11-03 Thread Bill Farner
On Nov. 3, 2014, 5:59 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/AsyncModule.java, line 178 https://reviews.apache.org/r/27467/diff/1/?file=746652#file746652line178 Does not read right, s/of/if/? Thanks, fixed. On Nov. 3, 2014, 5:59 p.m.,

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

2014-11-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/#review59645 --- Master (c03cea5) is red with this patch.

Review Request 27541: Revert Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27541/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 27541: Revert Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27541/#review59649 --- Ship it! Please file and attach a ticket to this, can be done

Re: Review Request 27541: Revert Adding resource consumption calculation for cron jobs.

2014-11-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27541/#review59651 --- This patch does not apply cleanly on master (9ef905a), do you need

Review Request 27542: Add test coverage for WriteAheadStorage.

2014-11-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27542/ --- Review request for Aurora. Repository: aurora Description --- Bring

Re: Review Request 27542: Add test coverage for WriteAheadStorage.

2014-11-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27542/ --- (Updated Nov. 3, 2014, 10:11 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

2014-11-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/#review59655 --- It seems like exponential backoff is warranted here - in the case

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

2014-11-03 Thread Ben Mahler
On Nov. 3, 2014, 10:17 p.m., Kevin Sweeney wrote: It seems like exponential backoff is warranted here - in the case that the master is completely overloaded there may be confirmation status updates in the queue that we haven't seen yet. Also, do you know off hand what the behavior

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

2014-11-03 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/ --- (Updated Nov. 3, 2014, 10:46 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

2014-11-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/#review59671 --- Ship it! Master (9ef905a) is green with this patch.

Re: Review Request 27545: Replace twitter.commons.io.FileUtils dependency w/ guava's Files

2014-11-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/#review59675 --- Master (9ef905a) is red with this patch.

Re: Review Request 27545: Replace twitter.commons.io.FileUtils dependency w/ guava's Files

2014-11-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27545/#review59677 --- Ship it! Ship It! - Kevin Sweeney On Nov. 3, 2014, 3:09 p.m.,

Re: Review Request 27467: Retry Driver.killTask periodically until the task changes states.

2014-11-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27467/#review59680 --- Ship it!

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-03 Thread Dan Norris
On Nov. 3, 2014, 6:03 p.m., Joshua Cohen wrote: 3rdparty/python/requirements.txt, line 1 https://reviews.apache.org/r/27492/diff/2/?file=747354#file747354line1 We should be able to skip argparse now that we're pinned to python2.7 (it was added to the stdlib). Didn't even think

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-03 Thread Dan Norris
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/ --- (Updated Nov. 4, 2014, 12:42 a.m.) Review request for Aurora and Kevin

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-03 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59699 --- Master (9ef905a) is red with this patch.

Re: Review Request 27492: AURORA-617: Switch pants 3rdparty to use python_requirements

2014-11-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27492/#review59707 --- Mind resubmitting your patch (just rerun the rbt command with no