Re: Review Request 27601: Adding resource consumption calculation for cron jobs.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27601/#review60349 --- Ship it! Ship It! - Bill Farner On Nov. 5, 2014, 1:23 a.m.,

Re: Review Request 27712: Fixing beta-update OK status messaging.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27712/#review60352 --- Ship it! LGTM once Job update has started message is removed from

Re: Review Request 27712: Fixing beta-update OK status messaging.

2014-11-07 Thread Maxim Khutornenko
On Nov. 7, 2014, 6:05 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 1582 https://reviews.apache.org/r/27712/diff/1/?file=754027#file754027line1582 Please remove. The API really should not be sending back messages of

Re: Review Request 27712: Fixing beta-update OK status messaging.

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27712/ --- (Updated Nov. 7, 2014, 7:12 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27712: Fixing beta-update OK status messaging.

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27712/ --- (Updated Nov. 7, 2014, 7:13 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27698: Move zookeeper connection off the main thread to prevent client deadlocks.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27698/#review60384 --- Ship it! Master (2d68bc6) is green with this patch.

Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-917

Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs:

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/#review60394 --- Ship it! Master (2d68bc6) is green with this patch.

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/#review60397 --- Ship it! src/main/python/apache/aurora/client/cli/cron.py

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/#review60402 --- Ship it! Master (03cb0d1) is green with this patch.

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27710/#review60404 --- Ship it! Ship It! - Bill Farner On Nov. 6, 2014, 11:40 p.m.,

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/#review60398 --- src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27710/#review60407 --- Ship it! Ship It! - Joshua Cohen On Nov. 6, 2014, 11:40 p.m.,

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/#review60400 --- Ship it!

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
On Nov. 7, 2014, 10:39 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java, line 123 https://reviews.apache.org/r/27746/diff/1/?file=754888#file754888line123 LOG.info(Retrying for ... in ...) Done. On Nov. 7, 2014, 10:39 p.m., Maxim

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
On Nov. 7, 2014, 10:47 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java, line 326 https://reviews.apache.org/r/27746/diff/1/?file=754879#file754879line326 typo in blockUntilStopped Fixed. On Nov. 7, 2014, 10:47 p.m., Kevin Sweeney

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/ --- (Updated Nov. 7, 2014, 11:05 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/#review60413 --- Master (03cb0d1) is red with this patch.

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/ --- (Updated Nov. 7, 2014, 10:59 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27746/#review60414 --- Ship it! Ship It! - Maxim Khutornenko On Nov. 7, 2014, 11:05

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Kevin Sweeney
On Nov. 7, 2014, 2:39 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java, line 123 https://reviews.apache.org/r/27746/diff/1/?file=754888#file754888line123 LOG.info(Retrying for ... in ...) Bill Farner wrote: Done. Not worth such

Re: Review Request 27746: Simplify management of the driver lifecycle using AbstractidleService.

2014-11-07 Thread Bill Farner
On Nov. 7, 2014, 10:39 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/async/TaskTimeout.java, line 123 https://reviews.apache.org/r/27746/diff/1/?file=754888#file754888line123 LOG.info(Retrying for ... in ...) Bill Farner wrote: Done. Kevin

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Maxim Khutornenko
On Nov. 7, 2014, 10:20 p.m., Bill Farner wrote: src/main/python/apache/aurora/client/cli/cron.py, line 55 https://reviews.apache.org/r/27747/diff/1/?file=754819#file754819line55 This file has a mix of single- and double-quoted strings. Consider settling on single and avoid the

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/ --- (Updated Nov. 7, 2014, 11:42 p.m.) Review request for Aurora, David McLaughlin

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/#review60422 --- This patch does not apply cleanly on master (66bd6fe), do you need

Review Request 27757: Replace bindStartupAction with Service registration

2014-11-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-920

Re: Review Request 27757: Replace bindStartupAction with Service registration

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review60433 --- Ship it! Master (66bd6fe) is green with this patch.

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/ --- (Updated Nov. 8, 2014, 12:28 a.m.) Review request for Aurora, David McLaughlin

Review Request 27762: Use async eventbus

2014-11-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-920

Re: Review Request 27762: Use async eventbus

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/#review60442 --- Ship it!

Re: Review Request 27542: Add test coverage for WriteAheadStorage.

2014-11-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27542/#review60443 --- Ship it! Ship It! - Kevin Sweeney On Nov. 6, 2014, 1:07 p.m.,

Re: Review Request 27762: Use async eventbus

2014-11-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/#review60447 ---

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/#review60449 --- Ship it! Master (66bd6fe) is green with this patch.

Re: Review Request 27762: Use async eventbus

2014-11-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/ --- (Updated Nov. 7, 2014, 4:50 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27762: Use async eventbus

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/#review60451 --- Master (66bd6fe) is red with this patch.

Re: Review Request 27762: Use async eventbus

2014-11-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/ --- (Updated Nov. 7, 2014, 4:57 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 27762: Use async eventbus

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27762/#review60452 --- Ship it! Master (66bd6fe) is green with this patch.

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-07 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27710/#review60454 --- Ship it! Ship It! - Joe Smith On Nov. 6, 2014, 3:40 p.m.,

Re: Review Request 27710: Remove stracktrace redirection.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27710/#review60469 --- Master (54b0262) is red with this patch.

Review Request 27770: Make it easier to request another ReviewBot run, and flag diffs that seem to lack test coverage.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27770/ --- Review request for Aurora, David McLaughlin and Joshua Cohen. Repository:

Re: Review Request 27770: Make it easier to request another ReviewBot run, and flag diffs that seem to lack test coverage.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27770/#review60472 --- Ship it! Master (54b0262) is green with this patch.

Review Request 27772: Fix fails pass on SchedulerDriverServiceTest case.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27772/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Re: Review Request 27772: Fix false passing test case in SchedulerDriverServiceTest.

2014-11-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27772/ --- (Updated Nov. 8, 2014, 5:53 a.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 27772: Fix false passing test case in SchedulerDriverServiceTest.

2014-11-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27772/#review60475 --- Ship it! Master (54b0262) is green with this patch.