Re: Review Request 27880: Fix missing paren in review bot.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27880/#review60815 --- Ship it! Ship It! - Joshua Cohen On Nov. 11, 2014, 6:31 p.m.,

Re: Review Request 27828: Move read-modify-write logic out of AttributeStore.Mutable for simpler layering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27828/ --- (Updated Nov. 11, 2014, 7:23 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27828: Move read-modify-write logic out of AttributeStore.Mutable for simpler layering.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27828/ --- (Updated Nov. 11, 2014, 7:27 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 27747: Splitting cron and non-cron job creation in client v2.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27747/#review60843 --- Ship it! Ship It! - David McLaughlin On Nov. 8, 2014, 12:28

Re: Review Request 27705: Adding instrumentation into the scheduling pipeline.

On Nov. 11, 2014, 10:04 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilterImpl.java, line 283 https://reviews.apache.org/r/27705/diff/1/?file=753245#file753245line283 Can you do this in a SchedulingFilter decorator instead? That way you

Re: Review Request 27757: Replace bindStartupAction with Service registration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27757/#review60874 --- Ship it!

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27889/#review60886 --- Ship it!

Re: Review Request 27852: Ensure run verb returns an exit code.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27852/#review60888 --- src/main/python/apache/aurora/client/cli/task.py

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27889/#review60889 --- Ship it! Master (0774c4e) is green with this patch.

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

On Nov. 11, 2014, 10:51 p.m., Kevin Sweeney wrote: src/test/java/org/apache/aurora/scheduler/state/MaintenanceControllerImplTest.java, line 73 https://reviews.apache.org/r/27889/diff/1/?file=758427#file758427line73 Is this needed anymore? Maintenance doesn't have a dependency on

Re: Review Request 27889: Send an event for host attributes changing rather than maintenance mode changing.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27889/#review60890 --- Ship it!

Review Request 27892: Fixes for the make pycharm script:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27892/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Repository: aurora

Re: Review Request 27892: Fixes for the make pycharm script:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27892/#review60893 --- Master (0774c4e) is red with this patch.

Re: Review Request 27892: Fixes for the make pycharm script:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27892/#review60894 --- @ReviewBot retry - Joshua Cohen On Nov. 11, 2014, 11:11 p.m.,

Re: Review Request 27892: Fixes for the make pycharm script:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27892/#review60898 --- Ship it! Master (0774c4e) is green with this patch.

Review Request 27894: Bump commons version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27894/ --- Review request for Aurora, Joe Smith and Bill Farner. Repository: aurora

Re: Review Request 27894: Bump commons version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27894/#review60904 --- Ship it! Ship It! - Joshua Cohen On Nov. 12, 2014, 12:26 a.m.,

Re: Review Request 27894: Bump commons version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27894/#review60908 --- Ship it! Ship It! - Bill Farner On Nov. 12, 2014, 12:26 a.m.,

Re: Review Request 27894: Bump commons version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27894/#review60909 --- Ship it! Master (7ecb718) is green with this patch.

Re: Review Request 27848: Add friendly error message to the client when lock is held.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27848/#review60892 --- Ship it! src/main/python/apache/aurora/client/cli/context.py

Re: Review Request 27892: Fixes for the make pycharm script:

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27892/#review60918 --- Ship it! Thanks! - Bill Farner On Nov. 11, 2014, 11:11 p.m.,

Re: Review Request 27894: Bump commons version.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27894/#review60919 --- Ship it! This is now on master ``` $ git log -1 origin/master

Re: Review Request 27848: Add friendly error message to the client when lock is held.

On Nov. 12, 2014, 1:28 a.m., Bill Farner wrote: src/main/python/apache/aurora/client/cli/context.py, line 152 https://reviews.apache.org/r/27848/diff/3/?file=757408#file757408line152 Is this going to produce some redundant output? See reply below, not sure why it didn't reply