Re: Review Request 28920: Add support for docker containers to aurora

2014-12-16 Thread Steve Niemitz
On Dec. 13, 2014, 1:59 a.m., Jay Buffington wrote: I haven't had time to complete this review, but I wanted to give you what I have so far. This is all fantastic and I really appreciate you doing this! I'm excited to start using this implementation. You should update

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-16 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Dec. 16, 2014, 9:19 p.m.) Review request for Aurora, Jay Buffington,

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review65245 --- Ship it! Master (95ad0fa) is green with this patch.

Review Request 29117: Adding thrift API changes document.

2014-12-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-973

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-16 Thread Jay Buffington
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review65249 --- There some issues here with usability that maybe this patch doesn't

Re: Review Request 29117: Adding thrift API changes document.

2014-12-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/ --- (Updated Dec. 16, 2014, 10:29 p.m.) Review request for Aurora and Kevin

Re: Review Request 29117: Adding thrift API changes document.

2014-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review65255 --- Ship it! Master (95ad0fa) is green with this patch.

Review Request 29126: Make 'pants goal' invocations work. Use proper python codegen style.

2014-12-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29126/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Re: Review Request 29126: Make 'pants goal' invocations work. Use proper python codegen style.

2014-12-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29126/#review65260 --- Ship it! BUILD.tools

Re: Review Request 29126: Make 'pants goal' invocations work. Use proper python codegen style.

2014-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29126/#review65261 --- Ship it! Master (95ad0fa) is green with this patch.

Re: Review Request 29126: Make 'pants goal' invocations work. Use proper python codegen style.

2014-12-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29126/ --- (Updated Dec. 16, 2014, 11:57 p.m.) Review request for Aurora and Kevin

Review Request 29132: get_client_version should never be allowed to run unpatched in test.

2014-12-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/ --- Review request for Aurora. Repository: aurora Description ---

Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.

2014-12-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/ --- (Updated Dec. 17, 2014, 12:57 a.m.) Review request for Aurora and Kevin

Re: Review Request 29132: get_client_version should never be allowed to run unpatched in test.

2014-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29132/#review65273 --- Ship it! Master (ab18bd0) is green with this patch.

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-16 Thread Jay Buffington
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review65276 --- Sorry for the multiple reviews. There is a lot here. Maybe we

Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-16 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/ --- Review request for Aurora, Kevin Sweeney and Zameer Manji. Bugs: AURORA-691

Re: Review Request 29137: Implementing dual read the PopulatedJobConfig struct

2014-12-16 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29137/#review65283 --- This patch does not apply cleanly on master (ab18bd0), do you need