Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/#review67565 --- Master (1f907da) is red with this patch.

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/ --- (Updated Jan. 10, 2015, 12:44 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/ --- (Updated Jan. 10, 2015, 12:42 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/#review67548 --- Err, no-ship. This breaks aurorabuild in vagrant: ``` $

Re: Review Request 29786: Don't double up on verbose kwargs when creating a DirectSchedulerClient.

2015-01-09 Thread Bhuvan Arumugam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29786/#review67549 --- Ship it! Ship It! - Bhuvan Arumugam On Jan. 9, 2015, 11:22

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Bill Farner
On Jan. 9, 2015, 11:27 p.m., Bill Farner wrote: Err, no-ship. This breaks aurorabuild in vagrant: ``` $ aurorabuild client sending incremental file list skipping non-regular file src/main/python/apache/aurora/client/cli/.auroraversion sent 44.29K bytes received 437 bytes

Re: Review Request 29786: Don't double up on verbose kwargs when creating a DirectSchedulerClient.

2015-01-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29786/#review67554 --- Ship it! Ship It! - Kevin Sweeney On Jan. 9, 2015, 3:22 p.m.,

Re: Review Request 29786: Don't double up on verbose kwargs when creating a DirectSchedulerClient.

2015-01-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29786/#review67563 --- Ship it! Master (1f907da) is green with this patch.

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/ --- (Updated Jan. 10, 2015, 12:04 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 29717: Remove dynamic command hooks and dynamic hook policy.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29717/#review67556 --- It seems that some amount of `docs/design/command-hooks.md` should

Re: Review Request 29786: Don't double up on verbose kwargs when creating a DirectSchedulerClient.

2015-01-09 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29786/#review67564 --- Ship it! Ship It! - Maxim Khutornenko On Jan. 9, 2015, 11:22

Re: Review Request 29696: Fix bad call to print_out causing 'job inspect --raw' to fail.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29696/ --- (Updated Jan. 9, 2015, 6:45 p.m.) Review request for Aurora, Kevin Sweeney and

Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-970 and

Re: Review Request 29117: Adding thrift API changes document.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29117/#review67471 --- docs/developing-aurora-client.md

Re: Review Request 29772: Add build-support/rbtools to .gitignore

2015-01-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29772/#review67480 --- Ship it! Master (c7afcf0) is green with this patch.

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/#review67481 --- This patch does not apply cleanly on master (c7afcf0), do you need

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-09 Thread Bill Farner
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote: docs/deploying-aurora-scheduler.md, line 155 https://reviews.apache.org/r/28920/diff/7/?file=808126#file808126line155 From reading the code, it appears this additional path is needed for them both to be available in the container.

Review Request 29772: Add build-support/rbtools to .gitignore

2015-01-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29772/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Repository:

Re: Review Request 29772: Add build-support/rbtools to .gitignore

2015-01-09 Thread Joshua Cohen
On Jan. 9, 2015, 7:06 p.m., Kevin Sweeney wrote: .gitignore, line 18 https://reviews.apache.org/r/29772/diff/1/?file=814816#file814816line18 I don't see this in my repo - is there some more context for this change? Bill Farner wrote: Ditto. I had assumed everyone was

Re: Review Request 29731: Service status endpoint.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29731/#review67467 --- Ship it! Ship It! - Bill Farner On Jan. 8, 2015, 11:47 p.m.,

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/ --- (Updated Jan. 9, 2015, 7:05 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 29772: Add build-support/rbtools to .gitignore

2015-01-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29772/#review67483 --- .gitignore https://reviews.apache.org/r/29772/#comment111527

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/#review67488 --- src/main/python/apache/aurora/client/cli/__init__.py

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-09 Thread Steve Niemitz
On Jan. 8, 2015, 2:20 a.m., Kevin Sweeney wrote: Thanks for the patch, looking good, mostly style nits below. If you haven't seen them yet check out the [Java](https://github.com/twitter/commons/blob/master/src/java/com/twitter/common/styleguide.md) and

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/ --- (Updated Jan. 9, 2015, 7:38 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 29776: ReviewBot, you awake? This should fail.

2015-01-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29776/#review67504 --- Ship it! Master (74e5471) is green with this patch.

Review Request 29777: Use pipefail to capture build failures in ReviewBot.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29777/ --- Review request for Aurora, Kevin Sweeney and Maxim Khutornenko. Bugs:

Re: Review Request 29696: Fix bad call to print_out causing 'job inspect --raw' to fail.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29696/ --- (Updated Jan. 9, 2015, 6:31 p.m.) Review request for Aurora, Kevin Sweeney and

Review Request 29774: Scrub docs of remaining references to aurora2 and aurora help.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29774/ --- Review request for Aurora and Kevin Sweeney. Repository: aurora Description

Review Request 29776: ReviewBot, you awake? This should fail.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29776/ --- Review request for Aurora. Repository: aurora Description ---

Re: Review Request 29772: Add build-support/rbtools to .gitignore

2015-01-09 Thread Bill Farner
On Jan. 9, 2015, 7:06 p.m., Kevin Sweeney wrote: .gitignore, line 18 https://reviews.apache.org/r/29772/diff/1/?file=814816#file814816line18 I don't see this in my repo - is there some more context for this change? Ditto. - Bill

Re: Review Request 29774: Scrub docs of remaining references to aurora2 and aurora help.

2015-01-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29774/#review67487 --- Ship it! docs/developing-aurora-client.md

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-09 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 9, 2015, 7:34 p.m.) Review request for Aurora, Jay Buffington,

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Joshua Cohen
On Jan. 9, 2015, 7:23 p.m., Kevin Sweeney wrote: src/main/python/apache/aurora/client/cli/__init__.py, lines 228-230 https://reviews.apache.org/r/29770/diff/2/?file=814850#file814850line228 Can this be a module-level constant like ```py __version__ =

Re: Review Request 29777: Use pipefail to capture build failures in ReviewBot.

2015-01-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29777/#review67508 --- Ship it! Ship It! - Kevin Sweeney On Jan. 9, 2015, 12:31 p.m.,

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review67498 --- Ship it! Master (74e5471) is green with this patch.

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/#review67500 --- Ship it! Ship It! - Kevin Sweeney On Jan. 9, 2015, 11:38 a.m.,

Re: Review Request 29774: Scrub docs of remaining references to aurora2 and aurora help.

2015-01-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29774/#review67501 --- Ship it! Master (74e5471) is green with this patch.

Re: Review Request 29776: ReviewBot, you awake? This should fail.

2015-01-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29776/#review67505 --- Master (74e5471) is red with this patch.

Re: Review Request 29770: Add support for --version flag to client.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29770/#review67547 --- Ship it! Ship It! - Bill Farner On Jan. 9, 2015, 7:38 p.m.,

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-09 Thread Bill Farner
On Jan. 8, 2015, 6:48 p.m., Bill Farner wrote: docs/deploying-aurora-scheduler.md, line 155 https://reviews.apache.org/r/28920/diff/7/?file=808126#file808126line155 From reading the code, it appears this additional path is needed for them both to be available in the container.

Re: Review Request 29774: Scrub docs of remaining references to aurora2 and aurora help.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29774/ --- (Updated Jan. 9, 2015, 8:50 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 29774: Scrub docs of remaining references to aurora2 and aurora help.

2015-01-09 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29774/ --- (Updated Jan. 9, 2015, 8:51 p.m.) Review request for Aurora and Kevin Sweeney.

Re: Review Request 29774: Scrub docs of remaining references to aurora2 and aurora help.

2015-01-09 Thread Bill Farner
On Jan. 9, 2015, 7:23 p.m., Joshua Cohen wrote: docs/developing-aurora-client.md, line 7 https://reviews.apache.org/r/29774/diff/1/?file=814856#file814856line7 webUI here is inconsistent with web-ui on the previous line. Either one works, but it should be consistent. Thanks.

Re: Review Request 29774: Scrub docs of remaining references to aurora2 and aurora help.

2015-01-09 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29774/#review67514 --- Ship it! Ship It! - Joshua Cohen On Jan. 9, 2015, 8:51 p.m.,

Re: Review Request 29774: Scrub docs of remaining references to aurora2 and aurora help.

2015-01-09 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29774/#review67518 --- Ship it! Ship It! - Kevin Sweeney On Jan. 9, 2015, 12:51 p.m.,

Re: Review Request 29774: Scrub docs of remaining references to aurora2 and aurora help.

2015-01-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29774/#review67517 --- Ship it! Master (74e5471) is green with this patch.

Re: Review Request 29777: Use pipefail to capture build failures in ReviewBot.

2015-01-09 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29777/#review67515 --- Ship it! Master (74e5471) is green with this patch.