Review Request 30467: Update mesos lib to 0.21.1

2015-01-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- Review request for Aurora and Kevin Sweeney. Bugs: AURORA-1028

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70403 --- Ship it! Ship It! - Kevin Sweeney On Jan. 30, 2015, 10:53 a.m.,

Re: Review Request 30467: Update mesos lib to 0.21.1

2015-01-30 Thread Bill Farner
On Jan. 30, 2015, 10:55 p.m., Stephan Erb wrote: What about the other references to 0.20.1? (e.g., 3rdparty/python/requirements.txt). Is it safe to update just one of them? Kevin Sweeney wrote: +1, please refer to previous mesos upgrade patches you'll also want to build

Re: Review Request 30467: Update mesos lib to 0.21.1

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/#review70438 --- Ship it! Master (c739122) is green with this patch.

Re: Review Request 30433: Prevent multiple active job updates from being inserted into storage.

2015-01-30 Thread Bill Farner
On Jan. 30, 2015, 5:44 a.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java, line 152 https://reviews.apache.org/r/30433/diff/1/?file=841071#file841071line152 Suggest adding an explanation of what active update means, e.g.:

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review70379 --- Ship it! Master (4f04a34) is green with this patch.

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-30 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/ --- (Updated Jan. 30, 2015, 7:18 nachm.) Review request for Aurora, Bill Farner

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-01-30 Thread Maxim Khutornenko
On Jan. 30, 2015, 5:34 p.m., David McLaughlin wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1126 https://reviews.apache.org/r/30325/diff/3/?file=841926#file841926line1126 Have we considered adding a batch interface, to avoid having to make multiple RPCs for a

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review70434 --- Ship it! Master (c739122) is green with this patch.

Re: Review Request 30467: Update mesos lib to 0.21.1

2015-01-30 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/#review70432 --- What about the other references to 0.20.1? (e.g.,

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-01-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ --- (Updated Jan. 30, 2015, 10:31 p.m.) Review request for Aurora, David

Re: Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/#review70427 --- Master (c739122) is red with this patch.

Re: Review Request 30467: Update mesos lib to 0.21.1

2015-01-30 Thread Kevin Sweeney
On Jan. 30, 2015, 2:55 p.m., Stephan Erb wrote: What about the other references to 0.20.1? (e.g., 3rdparty/python/requirements.txt). Is it safe to update just one of them? +1, please refer to previous mesos upgrade patches you'll also want to build new eggs and upload them to

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review70422 --- Ship it! Master (4f04a34) is green with this patch.

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review70407 --- Ship it! Ship It! - Zameer Manji On Jan. 30, 2015, 11:18 a.m.,

Re: Review Request 30433: Prevent multiple active job updates from being inserted into storage.

2015-01-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30433/ --- (Updated Jan. 30, 2015, 6:34 p.m.) Review request for Aurora and Maxim

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 3:24 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-01-30 Thread David McLaughlin
On Jan. 30, 2015, 5:34 p.m., David McLaughlin wrote: api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1126 https://reviews.apache.org/r/30325/diff/3/?file=841926#file841926line1126 Have we considered adding a batch interface, to avoid having to make multiple RPCs for a

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70449 --- Ship it! Master (c739122) is green with this patch.

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 6:18 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30467: Update mesos lib to 0.21.1

2015-01-30 Thread Stephan Erb
On Jan. 30, 2015, 10:55 p.m., Stephan Erb wrote: What about the other references to 0.20.1? (e.g., 3rdparty/python/requirements.txt). Is it safe to update just one of them? Kevin Sweeney wrote: +1, please refer to previous mesos upgrade patches you'll also want to build

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70456 ---

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-01-30 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review70383 --- Ship it! Ship It! - David McLaughlin On Jan. 30, 2015, 5:23

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 3:48 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70461 --- Ship it! Master (c739122) is green with this patch.

Re: Review Request 30467: Update mesos lib to 0.21.1

2015-01-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- (Updated Jan. 31, 2015, 1:45 a.m.) Review request for Aurora and Kevin

Re: Review Request 30467: Update mesos lib to 0.21.1

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/#review70481 --- Master (7fbe5bb) is red with this patch.

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70393 --- I was able to address these compiler errors with a more targeted

Re: Review Request 30433: Prevent multiple active job updates from being inserted into storage.

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30433/#review70418 --- Ship it! Master (4f04a34) is green with this patch.

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70443 ---

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-01-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- (Updated Jan. 30, 2015, 5:23 p.m.) Review request for Aurora, David

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
On Jan. 30, 2015, 4:56 p.m., Maxim Khutornenko wrote: I'm not in love with this fix, but the alternative is to declare these methods as throwing Exception which propagates out pretty widely. - that happens to be exactly what we do in java unit tests. No matter the type, it will still

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70453 --- Ship it! Ship It! - Bill Farner On Jan. 30, 2015, 11:48 p.m.,

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 4:09 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 6:18 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/ --- (Updated Jan. 30, 2015, 3:54 p.m.) Review request for Aurora and Bill Farner.

Re: Review Request 30473: Fixing copyright notice

2015-01-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30473/#review70478 --- Ship it! Ship It! - Bill Farner On Jan. 31, 2015, 1:11 a.m.,

Re: Review Request 30474: Preparing for 0.7.0 RC3

2015-01-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30474/#review70477 --- Ship it! Ship It! - Bill Farner On Jan. 31, 2015, 1:17 a.m.,

Review Request 30461: Adding pulse_interval_secs into client UpdateConfig.

2015-01-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30461/ --- Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/#review70413 --- Ship it! Master (4f04a34) is green with this patch.

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70451 --- Master (c739122) is red with this patch.

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-01-30 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/#review70377 --- api/src/main/thrift/org/apache/aurora/gen/api.thrift

Review Request 30474: Preparing for 0.7.0 RC3

2015-01-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30474/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 30467: Update mesos lib to 0.21.1

2015-01-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30467/ --- (Updated Jan. 31, 2015, 1:36 a.m.) Review request for Aurora and Kevin

Re: Review Request 30474: Preparing for 0.7.0 RC3

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30474/#review70479 --- Master (7fbe5bb) is green with this patch.

Re: Review Request 30473: Fixing copyright notice

2015-01-30 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30473/#review70480 --- Ship it! Master (7fbe5bb) is green with this patch.

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
On Jan. 30, 2015, 6:44 p.m., Bill Farner wrote: I was able to address these compiler errors with a more targeted change, adding a type witness: ``` $ git diff src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java diff --git

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70445 ---

Re: Review Request 30187: Remove support for cluster metadata in YAML format.

2015-01-30 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30187/#review70419 --- Ship it! Ship It! - Brian Wickman On Jan. 28, 2015, 8:26 p.m.,

Re: Review Request 30325: Implementing pulseJobUpdate RPC.

2015-01-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30325/ --- (Updated Jan. 30, 2015, 5:19 p.m.) Review request for Aurora, David

Re: Review Request 30446: Fix compile errors under Java 8.

2015-01-30 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30446/ --- (Updated Jan. 30, 2015, 6:53 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 30010: [AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints

2015-01-30 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30010/#review70384 --- Florian, can you remove the two empty lines Bill has pointed out?

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30471/#review70447 --- Ship it! This looks good to me. As long as the default value is

Review Request 30473: Fixing copyright notice

2015-01-30 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30473/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1072

Re: Review Request 28731: Implemented TaskScheduler benchmarks.

2015-01-30 Thread Maxim Khutornenko
On Jan. 31, 2015, 12:16 a.m., Zameer Manji wrote: Ship It! Zameer Manji wrote: My comment got chompted, I'm expecting these tests to be run on Jenkins for every commit. If you check the RB history this has been discussed earlier. The outcome: perf testing is too machine state