---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30467/
---
Review request for Aurora and Kevin Sweeney.
Bugs: AURORA-1028
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/#review70403
---
Ship it!
Ship It!
- Kevin Sweeney
On Jan. 30, 2015, 10:53 a.m.,
On Jan. 30, 2015, 10:55 p.m., Stephan Erb wrote:
What about the other references to 0.20.1? (e.g.,
3rdparty/python/requirements.txt). Is it safe to update just one of them?
Kevin Sweeney wrote:
+1, please refer to previous mesos upgrade patches
you'll also want to build
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30467/#review70438
---
Ship it!
Master (c739122) is green with this patch.
On Jan. 30, 2015, 5:44 a.m., Maxim Khutornenko wrote:
src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java,
line 152
https://reviews.apache.org/r/30433/diff/1/?file=841071#file841071line152
Suggest adding an explanation of what active update means, e.g.:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review70379
---
Ship it!
Master (4f04a34) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010/
---
(Updated Jan. 30, 2015, 7:18 nachm.)
Review request for Aurora, Bill Farner
On Jan. 30, 2015, 5:34 p.m., David McLaughlin wrote:
api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1126
https://reviews.apache.org/r/30325/diff/3/?file=841926#file841926line1126
Have we considered adding a batch interface, to avoid having to make
multiple RPCs for a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/#review70434
---
Ship it!
Master (c739122) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30467/#review70432
---
What about the other references to 0.20.1? (e.g.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/
---
(Updated Jan. 30, 2015, 10:31 p.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/#review70427
---
Master (c739122) is red with this patch.
On Jan. 30, 2015, 2:55 p.m., Stephan Erb wrote:
What about the other references to 0.20.1? (e.g.,
3rdparty/python/requirements.txt). Is it safe to update just one of them?
+1, please refer to previous mesos upgrade patches
you'll also want to build new eggs and upload them to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010/#review70422
---
Ship it!
Master (4f04a34) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010/#review70407
---
Ship it!
Ship It!
- Zameer Manji
On Jan. 30, 2015, 11:18 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30433/
---
(Updated Jan. 30, 2015, 6:34 p.m.)
Review request for Aurora and Maxim
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/
---
(Updated Jan. 30, 2015, 3:24 p.m.)
Review request for Aurora and Bill Farner.
On Jan. 30, 2015, 5:34 p.m., David McLaughlin wrote:
api/src/main/thrift/org/apache/aurora/gen/api.thrift, line 1126
https://reviews.apache.org/r/30325/diff/3/?file=841926#file841926line1126
Have we considered adding a batch interface, to avoid having to make
multiple RPCs for a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/#review70449
---
Ship it!
Master (c739122) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/
---
(Updated Jan. 30, 2015, 6:18 p.m.)
Review request for Aurora, Kevin Sweeney
On Jan. 30, 2015, 10:55 p.m., Stephan Erb wrote:
What about the other references to 0.20.1? (e.g.,
3rdparty/python/requirements.txt). Is it safe to update just one of them?
Kevin Sweeney wrote:
+1, please refer to previous mesos upgrade patches
you'll also want to build
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/#review70456
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review70383
---
Ship it!
Ship It!
- David McLaughlin
On Jan. 30, 2015, 5:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/
---
(Updated Jan. 30, 2015, 3:48 p.m.)
Review request for Aurora and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/#review70461
---
Ship it!
Master (c739122) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30467/
---
(Updated Jan. 31, 2015, 1:45 a.m.)
Review request for Aurora and Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30467/#review70481
---
Master (7fbe5bb) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/#review70393
---
I was able to address these compiler errors with a more targeted
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30433/#review70418
---
Ship it!
Master (4f04a34) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/#review70443
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/
---
(Updated Jan. 30, 2015, 5:23 p.m.)
Review request for Aurora, David
On Jan. 30, 2015, 4:56 p.m., Maxim Khutornenko wrote:
I'm not in love with this fix, but the alternative is to declare these
methods as throwing Exception which propagates out pretty widely. - that
happens to be exactly what we do in java unit tests. No matter the type, it
will still
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/#review70453
---
Ship it!
Ship It!
- Bill Farner
On Jan. 30, 2015, 11:48 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/
---
(Updated Jan. 30, 2015, 4:09 p.m.)
Review request for Aurora and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/
---
(Updated Jan. 30, 2015, 6:18 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/
---
(Updated Jan. 30, 2015, 3:54 p.m.)
Review request for Aurora and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30473/#review70478
---
Ship it!
Ship It!
- Bill Farner
On Jan. 31, 2015, 1:11 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30474/#review70477
---
Ship it!
Ship It!
- Bill Farner
On Jan. 31, 2015, 1:17 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30461/
---
Review request for Aurora, David McLaughlin, Joshua Cohen, and Bill Farner.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/#review70413
---
Ship it!
Master (4f04a34) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/#review70451
---
Master (c739122) is red with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/#review70377
---
api/src/main/thrift/org/apache/aurora/gen/api.thrift
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30474/
---
Review request for Aurora and Bill Farner.
Repository: aurora
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30467/
---
(Updated Jan. 31, 2015, 1:36 a.m.)
Review request for Aurora and Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30474/#review70479
---
Master (7fbe5bb) is green with this patch.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30473/#review70480
---
Ship it!
Master (7fbe5bb) is green with this patch.
On Jan. 30, 2015, 6:44 p.m., Bill Farner wrote:
I was able to address these compiler errors with a more targeted change,
adding a type witness:
```
$ git diff
src/test/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java
diff --git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/#review70445
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30187/#review70419
---
Ship it!
Ship It!
- Brian Wickman
On Jan. 28, 2015, 8:26 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30325/
---
(Updated Jan. 30, 2015, 5:19 p.m.)
Review request for Aurora, David
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30446/
---
(Updated Jan. 30, 2015, 6:53 p.m.)
Review request for Aurora, Kevin Sweeney
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30010/#review70384
---
Florian, can you remove the two empty lines Bill has pointed out?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30471/#review70447
---
Ship it!
This looks good to me. As long as the default value is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30473/
---
Review request for Aurora and Bill Farner.
Bugs: AURORA-1072
On Jan. 31, 2015, 12:16 a.m., Zameer Manji wrote:
Ship It!
Zameer Manji wrote:
My comment got chompted, I'm expecting these tests to be run on Jenkins
for every commit.
If you check the RB history this has been discussed earlier. The outcome: perf
testing is too machine state
55 matches
Mail list logo