Review Request 30985: Migrating documentation from v1 commands to v2

2015-02-13 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30985/ --- Review request for Aurora. Bugs: AURORA-1113

Re: Review Request 30985: Migrating documentation from v1 commands to v2

2015-02-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30985/#review72354 --- Ship it! Master (7637200) is green with this patch.

Review Request 30989: Change aurora commands to use aurora job namespace in tutorial

2015-02-13 Thread Iain Cambridge
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30989/ --- Review request for Aurora. Repository: aurora Description --- Change

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

2015-02-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/#review72420 --- @ReviewBot retry - Kevin Sweeney On Feb. 12, 2015, 4:55 p.m.,

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

2015-02-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/#review72428 --- Ship it! LGTM once the bot is happy - Bill Farner On Feb. 13,

Re: Review Request 30985: Migrating documentation from v1 commands to v2

2015-02-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30985/#review72423 --- Ship it! Thanks for doing this! Can you just make the minor

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30891/#review72429 --- To support this diff, can you include the jmh results before and

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72449 --- I'm over capacity on reviews at the moment, mind passing this one

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

2015-02-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/#review72416 --- Ship it! Ship It! - Joshua Cohen On Feb. 13, 2015, 12:55 a.m.,

Review Request 31029: Documenting coordinated updates.

2015-02-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31029/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1012

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- (Updated Feb. 13, 2015, 10:15 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 30957: Extract ReadOnlyScheduler to its own implementation class

2015-02-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30957/#review72438 --- @ReviewBot retry - Kevin Sweeney On Feb. 12, 2015, 4:55 p.m.,

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72443 --- src/test/python/apache/aurora/client/cli/test_supdate.py

Re: Review Request 30891: Offer filtering for static vetoes. Part 3 of 4: Offer filtering.

2015-02-13 Thread Maxim Khutornenko
On Feb. 13, 2015, 8:35 p.m., Bill Farner wrote: To support this diff, can you include the jmh results before and after? They are in the mentioned above original diff description: https://reviews.apache.org/r/28617/ - Maxim --- This

Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- Review request for Aurora, Bill Farner and Zameer Manji. Repository: aurora

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/ --- (Updated Feb. 13, 2015, 9:54 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Maxim Khutornenko
On Feb. 13, 2015, 10:06 p.m., Zameer Manji wrote: src/test/python/apache/aurora/client/cli/test_supdate.py, line 120 https://reviews.apache.org/r/31022/diff/1/?file=863675#file863675line120 Shouldn't 'test' be self.TEST_CLUSTER or similar? Cluster parameter is not actually used in

Re: Review Request 30985: Migrating documentation from v1 commands to v2

2015-02-13 Thread Florian Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30985/ --- (Updated Feb. 13, 2015, 10:18 nachm.) Review request for Aurora and Joshua

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72445 --- Ship it! Ship It! - Zameer Manji On Feb. 13, 2015, 2:15 p.m.,

Re: Review Request 30985: Migrating documentation from v1 commands to v2

2015-02-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30985/#review72446 --- Ship it! Ship It! - Joshua Cohen On Feb. 13, 2015, 10:18 p.m.,

Re: Review Request 31029: Documenting coordinated updates.

2015-02-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31029/#review72463 --- Ship it! Just some grammar nits docs/client-commands.md

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72462 --- Ship it! Master (9da3ef0) is green with this patch.

Re: Review Request 31029: Documenting coordinated updates.

2015-02-13 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31029/#review72464 --- Ship it! Master (9da3ef0) is green with this patch.

Re: Review Request 31022: Fixing aurora beta-update status command.

2015-02-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31022/#review72459 --- Ship it! Ship It! - Joshua Cohen On Feb. 13, 2015, 11:27 p.m.,

Re: Review Request 31029: Documenting coordinated updates.

2015-02-13 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31029/#review72469 --- Ship it! Ship It! - Joshua Cohen On Feb. 14, 2015, 12:33 a.m.,