Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74373 --- src/main/python/apache/thermos/monitoring/garbage.py

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-02-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/#review74277 --- Ship it! Master (938144c) is green with this patch.

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-26 Thread Brian Wickman
On Feb. 26, 2015, 4:25 a.m., Zameer Manji wrote: src/main/python/apache/thermos/bin/thermos.py, line 289 https://reviews.apache.org/r/31451/diff/2/?file=877122#file877122line289 How is this change related to the observer change? I was testing the observer by doing local thermos

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-26 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/ --- (Updated Feb. 26, 2015, 7:46 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74354 --- Master (36af017) is red with this patch.

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-26 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74345 --- Ship it! Ship It! - Zameer Manji On Feb. 26, 2015, 11:46 a.m.,

Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Brian Wickman
On Feb. 26, 2015, 7:46 p.m., Joshua Cohen wrote: src/main/python/apache/thermos/monitoring/garbage.py, line 83 https://reviews.apache.org/r/31491/diff/1/?file=878599#file878599line83 What's the purpose of these comments? ugh, keep forgetting to delete these comments On Feb. 26,

Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74353 --- Ship it! Master (36af017) is green with this patch.

Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/ --- Review request for Aurora, Joshua Cohen and Stephan Erb. Bugs: AURORA-1155

Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74342 --- Ship it! Master (36af017) is green with this patch.

Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74343 --- Ship it! src/main/python/apache/thermos/monitoring/garbage.py

Review Request 31493: Upgrading JMH plugin and framework versions.

2015-02-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31493/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 31493: Upgrading JMH plugin and framework versions.

2015-02-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31493/#review74361 --- Ship it! Master (36af017) is green with this patch.

Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74362 --- Ship it! Ship It! - Joshua Cohen On Feb. 26, 2015, 8 p.m.,

Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74366 --- src/main/python/apache/thermos/monitoring/garbage.py

Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74367 --- Ship it! Ship It! - Stephan Erb On Feb. 26, 2015, 9 p.m., Brian

Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/ --- (Updated Feb. 26, 2015, 10:46 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 31491: Add basic test coverage to the TaskGarbageCollector.

2015-02-26 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31491/#review74381 --- src/main/python/apache/thermos/monitoring/garbage.py

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-26 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/ --- (Updated Feb. 26, 2015, 10:43 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 31508: Removing redundant scheduling loop in preemptor.

2015-02-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31508/#review74409 --- Ship it! Master (766d1c9) is green with this patch.

Re: Review Request 31496: Set default people for reviews.

2015-02-26 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31496/#review74372 --- Ship it! Ship It! - Joshua Cohen On Feb. 26, 2015, 9:57 p.m.,

Re: Review Request 31496: Set default people for reviews.

2015-02-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31496/#review74377 --- Ship it! Master (36af017) is green with this patch.

Re: Review Request 31496: Set default people for reviews.

2015-02-26 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31496/#review74397 --- Ship it! Just to be clear, the responsibility assumed here is that

Review Request 31508: Removing redundant scheduling loop in preemptor.

2015-02-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31508/ --- Review request for Aurora, Bill Farner and Zameer Manji. Bugs: AURORA-1156

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74384 --- Master (db99eb0) is red with this patch.

Re: Review Request 31496: Set default people for reviews.

2015-02-26 Thread Zameer Manji
On Feb. 26, 2015, 3:24 p.m., Bill Farner wrote: Just to be clear, the responsibility assumed here is that of dispatchers. jcohen and i are not gateways to land patches, and should exercise judgement to re-route contributors to committers that can best help. Agreed. You and Joshua are

Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-26 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/ --- Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-1148

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-26 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31525/#review74434 --- Master (766d1c9) is red with this patch.