Re: Review Request 31570: Suppressing duplicate update instance events.

2015-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31570/#review74649 --- @ReviewBot retry - Maxim Khutornenko On Feb. 28, 2015, 1:37

Re: Review Request 31570: Suppressing duplicate update instance events.

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31570/#review74650 --- Ship it! Master (4cca6a6) is green with this patch.

Review Request 31570: Suppressing duplicate update instance events.

2015-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31570/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-1097

Re: Review Request 31570: Suppressing duplicate update instance events.

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31570/#review74646 --- Master (4cca6a6) is red with this patch.

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74513 --- Ship it! Master (766d1c9) is green with this patch.

Re: Review Request 31508: Removing redundant scheduling loop in preemptor.

2015-02-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31508/#review74514 --- Ship it! Context is that the removed code was attempting to

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74508 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 27, 2015, 4:49

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74507 --- Overall LGTM, all minor issues.

Re: Review Request 31334: Fixing cron update quota checking.

2015-02-27 Thread Bill Farner
On Feb. 24, 2015, 1:48 a.m., Aurora ReviewBot wrote: This patch does not apply cleanly on master (19378c1), do you need to rebase? I will refresh this build result if you post a review containing @ReviewBot retry Maxim, can you rebase? - Bill

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/ --- (Updated Feb. 27, 2015, 4:49 p.m.) Review request for Aurora, Joshua Cohen and

Re: Review Request 31388: Update thrift API and internal code to use JobUpdateSummary.key rather than job key and id.

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31388/#review74509 --- Master (766d1c9) is red with this patch.

Re: Review Request 31547: Revert Set default people for reviews.

2015-02-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31547/#review74522 --- Ship it! Ship It! - Bill Farner On Feb. 27, 2015, 6:02 p.m.,

Review Request 31546: Revert TARGET_PEOPLE change, this was applying to updates as well as new reviews.

2015-02-27 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31546/ --- Review request for Aurora and Bill Farner. Repository: aurora Description

Re: Review Request 31546: Revert TARGET_PEOPLE change, this was applying to updates as well as new reviews.

2015-02-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31546/#review74521 --- Ship it! Ship It! - Bill Farner On Feb. 27, 2015, 5:57 p.m.,

Review Request 31550: Add test coverage for MesosSchedulerImpl.

2015-02-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31550/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 31550: Add test coverage for MesosSchedulerImpl.

2015-02-27 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31550/#review74564 --- @ReviewBot retry Flaky test is tracked at AURORA-1054 - Bill

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated Feb. 27, 2015, 8:19 p.m.) Review request for Aurora, Jay Buffington

Re: Review Request 31508: Removing redundant scheduling loop in preemptor.

2015-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31508/ --- (Updated Feb. 27, 2015, 8:23 p.m.) Review request for Aurora, Bill Farner and

Re: Review Request 31550: Add test coverage for MesosSchedulerImpl.

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31550/#review74572 --- Ship it! Master (d1a1296) is green with this patch.

Re: Review Request 31550: Add test coverage for MesosSchedulerImpl.

2015-02-27 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31550/#review74566 --- Ship it! Ship It! - Maxim Khutornenko On Feb. 27, 2015, 6:30

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Steve Niemitz
On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/mesos/ExecutorSettings.java, line 36 https://reviews.apache.org/r/31338/diff/4/?file=876495#file876495line36 should this be private? I wanted it to be, but got style checker violations when

Re: Review Request 31525: Improving NearestFit reporting accuracy.

2015-02-27 Thread Maxim Khutornenko
On Feb. 27, 2015, 7:30 p.m., Kevin Sweeney wrote: src/main/java/org/apache/aurora/scheduler/filter/SchedulingFilter.java, lines 110-113 https://reviews.apache.org/r/31525/diff/1/?file=879537#file879537line110 How about making score an EnumSetVetoType so that you can do a

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31559/#review74604 --- I think moving the binary entry point to aurora/executor/bin is a

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31559/#review74631 --- Ship it! Master (4cca6a6) is green with this patch.

Re: Review Request 31451: Port thermos observer to the path detector interface

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31451/#review74633 --- Ship it! Master (4cca6a6) is green with this patch.

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Zameer Manji
On Feb. 27, 2015, 2:03 p.m., Zameer Manji wrote: src/test/python/apache/thermos/cli/commands/test_simplerun.py, line 19 https://reviews.apache.org/r/31559/diff/1/?file=880712#file880712line19 Instead of creating a Mock like this here, could you grab the options from the simplerun

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74627 --- Master (4cca6a6) is red with this patch.

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Bill Farner
On Feb. 27, 2015, 5:01 p.m., Bill Farner wrote: src/test/java/org/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java, lines 215-227 https://reviews.apache.org/r/31338/diff/4/?file=876499#file876499line215 Can this instead be an exact comparison of ListVolume? Presumably

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31559/ --- (Updated Feb. 27, 2015, 10:29 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31559/ --- (Updated Feb. 27, 2015, 10:48 p.m.) Review request for Aurora, Joe Smith and

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31559/#review74613 --- Master (388a5b3) is red with this patch.

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Zameer Manji
On Feb. 27, 2015, 2:03 p.m., Zameer Manji wrote: src/main/python/apache/thermos/cli/common.py, line 40 https://reviews.apache.org/r/31559/diff/1/?file=880707#file880707line40 Unrelated to your change, why have the strict option at al? Shouldn't the default behaviour validate the

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/ --- (Updated Feb. 27, 2015, 11:16 p.m.) Review request for Aurora, Jay Buffington

Re: Review Request 31559: Split thermos cli into pieces. Add custom aurora thermos entry point.

2015-02-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31559/ --- (Updated Feb. 27, 2015, 11:37 p.m.) Review request for Aurora, Joe Smith and