Re: Review Request 16797: Change name of client console script to aurora.

2014-01-10 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16797/#review31548 --- Ship it! Ship It! - Brian Wickman On Jan. 10, 2014, 10:08 p.m

Review Request 16919: Fix bad merge commit

2014-01-15 Thread Brian Wickman
. FAILURE mba=aurora=; Thanks, Brian Wickman

Re: Review Request 16985: Script to create Python sdists.

2014-01-16 Thread Brian Wickman
to a newer pants once setup_py --recursive goes in? - Brian Wickman On Jan. 17, 2014, 12:56 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16985

Review Request 17060: Fix noisy status checker debug log.

2014-01-17 Thread Brian Wickman
--- Fix noisy status checker debug log. Diffs - src/main/python/apache/aurora/executor/common/status_checker.py efffa8fda06afb830c5f65fb6eb15f4510225e96 Diff: https://reviews.apache.org/r/17060/diff/ Testing --- Thanks, Brian Wickman

Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-27 Thread Brian Wickman
going to defer to jon b's thoroughness for the rest. - Brian Wickman On Jan. 27, 2014, 6:21 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17185

Review Request 17412: Quiet noisy status checker debug messages

2014-01-27 Thread Brian Wickman
--- Fix noisy status checker debug log. Diffs - src/main/python/apache/aurora/executor/common/status_checker.py 48e7a442cfb6bda1a6b3891c25f61f0c9003b8a4 Diff: https://reviews.apache.org/r/17412/diff/ Testing --- Thanks, Brian Wickman

Re: Review Request 17412: Quiet noisy status checker debug messages

2014-01-27 Thread Brian Wickman
://reviews.apache.org/r/17412/diff/ Testing --- Thanks, Brian Wickman

Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Brian Wickman
resolve as 3rdparty/python:argparse, 3rdparty/python:bottle, etc. - Brian Wickman On Jan. 27, 2014, 8:54 p.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419

Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/#review32938 --- Ship it! Ship It! - Brian Wickman On Jan. 28, 2014, 12:19 a.m

Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/#review32937 --- Ship it! Ship It! - Brian Wickman On Jan. 28, 2014, 12:19 a.m

Re: Review Request 17293: s/thermos_observe/thermos_observer/ in README.md

2014-01-28 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17293/#review33014 --- Ship it! Ship It! - Brian Wickman On Jan. 24, 2014, 1:28 a.m

Re: Review Request 17063: Update tag-release to allow patch level increments.

2014-01-28 Thread Brian Wickman
(updated) - KEYS 0313277754679da0e5e1d2075654eac9006ce448 build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014 Diff: https://reviews.apache.org/r/17063/diff/ Testing --- Nope Thanks, Brian Wickman

Re: Review Request 17063: Update tag-release to allow patch level increments.

2014-01-28 Thread Brian Wickman
build-support/release/tag-release 90dc5da2fcb515359174d289d69cac01009f6014 Diff: https://reviews.apache.org/r/17063/diff/ Testing --- Nope Thanks, Brian Wickman

Re: Review Request 17559: requirement should be mesos==0.15.0-rc4

2014-01-30 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17559/#review33254 --- On Jan. 30, 2014, 9:31 p.m., Brian Wickman wrote

Re: Review Request 17475: Upgrade mesos to 0.15.0

2014-01-30 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17475/#review33257 --- Ship it! Ship It! - Brian Wickman On Jan. 29, 2014, 12:40 a.m

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-01-31 Thread Brian Wickman
', 'slaves/*/frameworks/*/executors/%(executor_name)s/runs', '%(slave_run_directory)s' ) % parameters - Brian Wickman On Jan. 30, 2014, 9:09 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated

Re: Review Request 17679: Upgrade twitter.common.python to 0.3.0

2014-02-03 Thread Brian Wickman
this. pants https://reviews.apache.org/r/17679/#comment63065 why not PANTS_VERSION=$(cat .pantsversion) like before? - Brian Wickman On Feb. 3, 2014, 11:13 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail

Re: Review Request 17679: Upgrade twitter.common.python to 0.3.0

2014-02-03 Thread Brian Wickman
On Feb. 4, 2014, 12:34 a.m., Brian Wickman wrote: pants, line 20 https://reviews.apache.org/r/17679/diff/1/?file=463687#file463687line20 why not PANTS_VERSION=$(cat .pantsversion) like before? Kevin Sweeney wrote: This matches the convention in other virtualenv-y scripts

Re: Review Request 17679: Upgrade twitter.common.python to 0.3.0

2014-02-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17679/#review33550 --- Ship it! Ship It! - Brian Wickman On Feb. 3, 2014, 11:13 p.m

Re: Review Request 17734: AURORA-157: Reorder python imports to be consistent

2014-02-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17734/#review33730 --- Ship it! Ship It! - Brian Wickman On Feb. 5, 2014, 8:42 p.m

Re: Review Request 17734: AURORA-157: Reorder python imports to be consistent

2014-02-05 Thread Brian Wickman
(.-prefixed) deps - third party deps Testing Done: ./gradlew build ./pants src/test/python:all -vxs Bugs closed: AURORA-157 Reviewed at https://reviews.apache.org/r/17734/ - Brian Wickman On Feb. 5, 2014, 8:42 p.m., Dan Norris wrote

Review Request 17913: Make sandboxes safer.

2014-02-10 Thread Brian Wickman
=== 5 passed in 0.07 seconds === src.test.python.apache.aurora.executor.common.directory_sandbox . SUCCESS Thanks, Brian Wickman

Re: Review Request 17913: Make sandboxes safer.

2014-02-10 Thread Brian Wickman
, Brian Wickman

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-14 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17823/#review34508 --- Ship it! Ship It! - Brian Wickman On Feb. 13, 2014, 10:59 p.m

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-14 Thread Brian Wickman
/17752/#comment64613 any reason why '-t' short form is removed? for me '-t50' is almost muscle memory. - Brian Wickman On Feb. 12, 2014, 2:16 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-14 Thread Brian Wickman
.) At the end of the day, if you end up on smaller or larger terminals, you'll probably end up using the textwrap module to change the line breaks here programmatically anyway. - Brian Wickman On Feb. 11, 2014, 3:31 p.m., Mark Chu-Carroll wrote

Re: Review Request 18042: Adding sla get_task_up_count command.

2014-02-14 Thread Brian Wickman
https://reviews.apache.org/r/18042/#comment64610 one-liner: return sorted(map(parse_time, time_values.split(','))) - Brian Wickman On Feb. 14, 2014, 5:42 p.m., Maxim Khutornenko wrote: --- This is an automatically

Re: Review Request 18163: Remove appapp references from schema

2014-02-16 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18163/#review34600 --- Ship it! Ship It! - Brian Wickman On Feb. 15, 2014, 2:43 a.m

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-18 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17752/#review34706 --- Ship it! Ship It! - Brian Wickman On Feb. 18, 2014, 1:47 p.m

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-18 Thread Brian Wickman
://reviews.apache.org/r/17948/#comment64918 in case you want to keep the indentation flow, the following works: from textwrap import dedent help=dedent( foo bar baz) - Brian Wickman On Feb. 18, 2014, 3:06 p.m., Mark Chu-Carroll wrote

Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Brian Wickman
/aurora/client/bin:aurora_admin Thanks, Brian Wickman

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Brian Wickman
/18229/#review34736 --- On Feb. 18, 2014, 6:52 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18229

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Brian Wickman
On Feb. 18, 2014, 6:57 p.m., Kevin Sweeney wrote: Can you verify this fixes the e2e test? Brian Wickman wrote: give me an hour and i'll get back to you *** + echo 'OK (all tests passed)' OK (all tests passed) + echo '***' *** + exit 0 - Brian

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Brian Wickman
://reviews.apache.org/r/18153/#comment65038 percentiles == '' seems like an error case to me. - Brian Wickman On Feb. 18, 2014, 7:30 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Review Request 18239: rename ThermosExecutor to AuroraExecutor, clean up thermos-isms from ExecutorBase

2014-02-18 Thread Brian Wickman
tests. ./pants src/test/python/apache/aurora/executor:executor-large -v passes for me locally. running e2e now. Thanks, Brian Wickman

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Brian Wickman
/ --- (Updated Feb. 18, 2014, 8:46 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-207 https://issues.apache.org/jira/browse/AURORA-207 Repository: aurora Description --- Added sla

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Brian Wickman
On Feb. 18, 2014, 10:15 p.m., Brian Wickman wrote: src/main/python/apache/aurora/client/cli/options.py, line 70 https://reviews.apache.org/r/18153/diff/3/?file=496781#file496781line70 is 100 an incorrect percentile? 100th percentile means max() right? derp, nevermind, the internet

Re: Review Request 18153: Added sla get_job_uptime command.

2014-02-18 Thread Brian Wickman
else None - Brian Wickman On Feb. 18, 2014, 10:52 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18153

Re: Review Request 18267: Implement help for v2 bridge

2014-02-20 Thread Brian Wickman
.') src/main/python/apache/aurora/client/cli/options.py https://reviews.apache.org/r/18267/#comment65451 don't forget to import Compatibility :-) - Brian Wickman On Feb. 20, 2014, 7:33 p.m., Mark Chu-Carroll wrote

Re: Review Request 18267: Implement help for v2 bridge

2014-02-20 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18267/#review35120 --- Ship it! Ship It! - Brian Wickman On Feb. 20, 2014, 9:33 p.m

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18296/#review35202 --- Ship it! Ship It! - Brian Wickman On Feb. 21, 2014, 7:49 p.m

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Brian Wickman
this was never updated. safe_hosts[host] = safe_limits != self_hosts[host].append(safe_limits) do you mean .extend()? - Brian Wickman On Feb. 21, 2014, 7:49 p.m., Maxim Khutornenko wrote: --- This is an automatically generated

Re: Review Request 18296: Adding admin_client sla_list_safe_domain command.

2014-02-21 Thread Brian Wickman
, visit: https://reviews.apache.org/r/18296/ --- (Updated Feb. 21, 2014, 7:49 p.m.) Review request for Aurora, Mark Chu-Carroll and Brian Wickman. Bugs: AURORA-208 https://issues.apache.org/jira/browse/AURORA-208

Re: Review Request 18440: Adding aurora_admin sla_probe_hosts command.

2014-02-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18440/#review35437 --- Ship it! Ship It! - Brian Wickman On Feb. 25, 2014, 6:59 p.m

Re: Review Request 18485: Improving sla_list_safe_domain performance

2014-02-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18485/#review35484 --- Ship it! Ship It! - Brian Wickman On Feb. 25, 2014, 10:26 p.m

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-28 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602/#review35816 --- Ship it! Ship It! - Brian Wickman On Feb. 28, 2014, 2:37 a.m

Re: Review Request 18580: Upgrade mesos to 0.17.0

2014-02-28 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/#review35819 --- have you run the executor:long tests? - Brian Wickman On Feb. 28

Re: Review Request 18580: Upgrade mesos to 0.17.0

2014-03-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/#review36050 --- Ship it! Ship It! - Brian Wickman On Feb. 28, 2014, 11:21 p.m

Re: Review Request 18819: Removing rollback_on_failure from restart options.

2014-03-05 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18819/#review36323 --- Ship it! Ship It! - Brian Wickman On March 5, 2014, 11:20 p.m

Re: Review Request 18819: Removing rollback_on_failure from restart options.

2014-03-05 Thread Brian Wickman
request for Aurora, David Robinson and Brian Wickman. Bugs: AURORA-247 https://issues.apache.org/jira/browse/AURORA-247 Repository: aurora Description --- Removing rollback_on_failure from restart options. Diffs - src/main/python/apache/aurora/client/api

Re: Review Request 18720: Refactored admin client commands to take advantage of new TaskQuery fields.

2014-03-06 Thread Brian Wickman
len(tasks) will always be true if tasks - Brian Wickman On March 4, 2014, 1:20 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18720

Re: Review Request 19143: Catch errors thrown by authentication modules.

2014-03-17 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19143/#review37392 --- Ship it! Ship It! - Brian Wickman On March 12, 2014, 10:59 p.m

Review Request 19426: Don't forget to register status checker observables.

2014-03-19 Thread Brian Wickman
--- src.test.python.apache.aurora.executor.executor_builds . SUCCESS src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . SUCCESS Thanks, Brian Wickman

Re: Review Request 19426: Don't forget to register status checker observables.

2014-03-19 Thread Brian Wickman
https://reviews.apache.org/r/19426/#comment69574 yes - Brian Wickman On March 19, 2014, 10:55 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19426

Re: Review Request 19411: Add support for global hooks.

2014-03-19 Thread Brian Wickman
://reviews.apache.org/r/19411/#comment69621 you'll want GlobalHookRegistry.get_hooks() to return cls.HOOKS[:], otherwise 'hooks += config.hooks' will actually mutate the global registry - Brian Wickman On March 19, 2014, 5:09 p.m., Mark Chu-Carroll wrote

Re: Review Request 19396: Implement client command logging with a unique token.

2014-03-21 Thread Brian Wickman
/#comment70121 it's unclear to me as a developer when i would use print_out vs print_err vs print_log. also, why make print_out and print_err abstract? - Brian Wickman On March 19, 2014, 1:20 p.m., Mark Chu-Carroll wrote

Re: Review Request 19078: Part 2 of converting from Packages to Metadata.

2014-03-21 Thread Brian Wickman
kill it while you're in the neighborhood.) - Brian Wickman On March 18, 2014, 12:55 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19078

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-21 Thread Brian Wickman
, and with batching as the default, should be safe to interoperate. - Brian Wickman On March 20, 2014, 6:48 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431

Re: Review Request 16710: Support multiple simulataneous auth mechanisms.

2014-03-21 Thread Brian Wickman
covered. - Brian Wickman On Jan. 8, 2014, 12:45 a.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16710

Re: Review Request 19362: Changing from STARTING to RUNNING in job uptime calculations.

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19362/#review38167 --- Ship it! Ship It! - Brian Wickman On March 18, 2014, 6:16 p.m

Re: Review Request 19411: Add support for global hooks.

2014-03-21 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19411/#review38169 --- Ship it! Ship It! - Brian Wickman On March 21, 2014, 6:21 p.m

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-21 Thread Brian Wickman
://reviews.apache.org/r/19431/#comment70194 metavar should be something like CLUSTER/ROLE/ENV/NAME[/INSTANCES] - Brian Wickman On March 21, 2014, 7:56 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-24 Thread Brian Wickman
/options.py https://reviews.apache.org/r/19431/#comment70403 passing all here will result in a ValueError from the int(x[0]), so that should probably be caught and signaled to the user as a human-readable error message. - Brian Wickman On March 22, 2014, 2:14 p.m., Mark Chu-Carroll wrote

Re: Review Request 17056: fix dependencies for setup_py

2014-03-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review38378 --- crap, i missed this. will merge/repost/submit. - Brian Wickman

Re: Review Request 17056: fix dependencies for setup_py

2014-03-24 Thread Brian Wickman
://reviews.apache.org/r/17056/diff/ Testing --- Thanks, Brian Wickman

Re: Review Request 19396: Implement client command logging with a unique token.

2014-03-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38390 --- Ship it! Ship It! - Brian Wickman On March 21, 2014, 7:06 p.m

Re: Review Request 19466: Add batching to the kill and killall commands.

2014-03-25 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19466/#review38543 --- Ship it! Ship It! - Brian Wickman On March 24, 2014, 11:21 p.m

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-25 Thread Brian Wickman
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/ --- (Updated March 24, 2014, 6:58 p.m.) Review request for Aurora, Bill Farner and Brian Wickman. Bugs: aurora-268 https://issues.apache.org

Re: Review Request 19550: Filtering out non-prod tasks for domain sla calculations.

2014-03-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19550/#review38787 --- Ship it! Ship It! - Brian Wickman On March 21, 2014, 9:15 p.m

Re: Review Request 19431: Add instance specifier syntax to clientv2

2014-03-27 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19431/#review38788 --- Ship it! Ship It! - Brian Wickman On March 26, 2014, 6:08 p.m

Re: Review Request 19895: Part 2 of converting from Packages to Metadata (client)

2014-04-02 Thread Brian Wickman
://reviews.apache.org/r/19895/#comment71637 fix comment - Brian Wickman On April 2, 2014, 1:52 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19895

Re: Review Request 19756: Filtering safe domain results by hosts.

2014-04-02 Thread Brian Wickman
, in module TypeError: 'NoneType' object is not iterable - Brian Wickman On March 27, 2014, 10:58 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19756

Re: Review Request 19756: Filtering safe domain results by hosts.

2014-04-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19756/#review39329 --- Ship it! Ship It! - Brian Wickman On April 2, 2014, 5:18 p.m

Review Request 19955: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests

2014-04-02 Thread Brian Wickman
://reviews.apache.org/r/19955/diff/ Testing --- still running the build Thanks, Brian Wickman

Re: Review Request 19955: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests

2014-04-02 Thread Brian Wickman
Wickman On April 2, 2014, 7:37 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19955/ --- (Updated April

Review Request 19958: Revert AURORA-29: Clean up resource files under src/resources/org/apache/

2014-04-02 Thread Brian Wickman
src.test.python.apache.aurora.executor.gc_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_executor . SUCCESS Thanks, Brian Wickman

Re: Review Request 19955: AURORA-14: Add jenkins-compatible script to build mesos core egg and run executor-large tests

2014-04-03 Thread Brian Wickman
--- On April 2, 2014, 7:37 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19955/ --- (Updated April 2, 2014, 7

Re: Review Request 20010: Fix two clientv2 command-line bugs.

2014-04-03 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20010/#review39472 --- Ship it! Ship It! - Brian Wickman On April 3, 2014, 5:15 p.m

Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-22 Thread Brian Wickman
/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/multiprocessing/util.py, line 258, in _exit_function info('process shutting down') TypeError: 'NoneType' object is not callable These are bugs in the stdlib that are fixed in 2.7 and are harmless. Just FYI. Thanks, Brian

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-22 Thread Brian Wickman
--- On April 22, 2014, 10:42 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583

Re: Review Request 20490: Add a get version API method.

2014-04-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20490/#review41149 --- Ship it! Ship It! - Brian Wickman On April 22, 2014, 7:59 p.m

Review Request 20629: End to end test should not look at the number of html lines.

2014-04-23 Thread Brian Wickman
--- End to end test should not look at the number of html lines. Diffs - src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh f0f2ab53c1f484a480eb2ea8766c5d299e3b8c99 Diff: https://reviews.apache.org/r/20629/diff/ Testing --- end-to-end test Thanks, Brian Wickman

Re: Review Request 20398: Scheduler SLA metrics.

2014-04-23 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20398/#review41244 --- you can pull me off the review on this one. - Brian Wickman

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-23 Thread Brian Wickman
/Python.framework/Versions/2.6/lib/python2.6/multiprocessing/util.py, line 258, in _exit_function info('process shutting down') TypeError: 'NoneType' object is not callable These are bugs in the stdlib that are fixed in 2.7 and are harmless. Just FYI. Thanks, Brian Wickman

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-24 Thread Brian Wickman
--- On April 24, 2014, 1:33 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583/ --- (Updated April 24, 2014, 1

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-24 Thread Brian Wickman
0 - Brian Wickman On April 24, 2014, 1:33 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583

Re: Review Request 20490: Add a get version API method.

2014-04-24 Thread Brian Wickman
the directory wrapper stuff. if it merges before r/20583, i will have to kill the directory wrapper stuff :-) since this goes away in twitter.common.python =0.4.0. - Brian Wickman On April 22, 2014, 7:59 p.m., Mark Chu-Carroll wrote

Re: Review Request 20583: upgrade aurora repo to newer pants and commons

2014-04-24 Thread Brian Wickman
0 - Brian Wickman On April 24, 2014, 1:33 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20583

Re: Review Request 20394: Add return code to task/process pages

2014-04-24 Thread Brian Wickman
changes. src/main/python/apache/thermos/observer/http/templates/task.tpl https://reviews.apache.org/r/20394/#comment74754 kill trailing ws - Brian Wickman On April 16, 2014, 9:38 p.m., David McLaughlin wrote

Re: Review Request 20490: Add a get version API method.

2014-04-24 Thread Brian Wickman
Make sure to close the reviewboard, otherwise it will continue to show up in review dashboards. On Thu, Apr 24, 2014 at 10:20 AM, Mark Chu-Carroll mchucarr...@apache.orgwrote: It's already pushed. On Thu, Apr 24, 2014 at 1:16 PM, Brian Wickman wick...@apache.org wrote

Re: Review Request 20678: Remove unused mootools dependency

2014-04-24 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20678/#review41368 --- Ship it! Ship It! - Brian Wickman On April 24, 2014, 6:46 p.m

Re: Review Request 20726: Removing client HTTP health checks.

2014-04-28 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20726/#review41671 --- Ship it! Ship It! - Brian Wickman On April 25, 2014, 7:41 p.m

Review Request 20867: Upgrade to pants==23

2014-04-29 Thread Brian Wickman
--- ./pants src/test/python:all -v Thanks, Brian Wickman

Review Request 20917: Pull cherrypy from remote repository.

2014-04-30 Thread Brian Wickman
PYTHON_VERBOSE=1 ./pants src/main/python/apache/thermos/observer/bin:thermos_observer before: Unsatisfiable: Cannot satisfy requirements: [PythonRequirement(cherrypy==3.2.2)] after: Wrote /Users/wickman/clients/aurora/dist/thermos_observer.pex Thanks, Brian Wickman

Re: Review Request 20917: Pull cherrypy from remote repository.

2014-04-30 Thread Brian Wickman
/dist/thermos_observer.pex Thanks, Brian Wickman

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-01 Thread Brian Wickman
, i.e. with_timeout=True src/main/python/apache/aurora/client/commands/core.py https://reviews.apache.org/r/20950/#comment75615 weird indent. also this should use die('Tasks were not killed in time.') - Brian Wickman On May 1, 2014, 8:42 p.m., Maxim Khutornenko wrote

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-01 Thread Brian Wickman
On May 1, 2014, 8:59 p.m., Brian Wickman wrote: src/main/python/apache/aurora/client/api/job_monitor.py, line 81 https://reviews.apache.org/r/20950/diff/2/?file=572973#file572973line81 = Maxim Khutornenko wrote: It's safe as is but since Mark asked about this too changing

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-02 Thread Brian Wickman
On May 1, 2014, 8:59 p.m., Brian Wickman wrote: src/main/python/apache/aurora/client/api/job_monitor.py, line 81 https://reviews.apache.org/r/20950/diff/2/?file=572973#file572973line81 = Maxim Khutornenko wrote: It's safe as is but since Mark asked about this too changing

Re: Review Request 20950: Moving kill wait to the client (Part 1: client changes)

2014-05-02 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20950/#review42025 --- Ship it! Ship It! - Brian Wickman On May 1, 2014, 10:21 p.m

Re: Review Request 21023: Make --help defer to bridged help in the bridged client executable.

2014-05-02 Thread Brian Wickman
://reviews.apache.org/r/21023/#comment75787 there's an extra newline here. - Brian Wickman On May 2, 2014, 7:46 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

  1   2   3   4   >