Review Request 20344: AURORA-267: Add container to popover to avoid clipping issue

2014-04-14 Thread David McLaughlin
widely known issue: https://github.com/twbs/bootstrap/issues/5889 Thanks, David McLaughlin

Review Request 20394: Add return code to task/process pages

2014-04-15 Thread David McLaughlin
/observer/http/templates/task.tpl b71c80d11255c111873a46b99478c36d39cc8733 src/main/python/apache/thermos/observer/task_observer.py ea40bfa610e2af90904487c809bc83b8b5f214d9 Diff: https://reviews.apache.org/r/20394/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-15 Thread David McLaughlin
is called. src/main/resources/org/apache/aurora/scheduler/http/ui/js/filters.js https://reviews.apache.org/r/19833/#comment73507 Same here, move up in scope. - David McLaughlin On April 4, 2014, 11:52 p.m., Suman Karumuri wrote

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-16 Thread David McLaughlin
On April 6, 2014, 12:24 a.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/job.html, line 62 https://reviews.apache.org/r/19833/diff/6/?file=549472#file549472line62 Can you make this an anchor instead of span? Also, the issue i pointed out

Re: Review Request 20394: Add return code to task/process pages

2014-04-16 Thread David McLaughlin
--- Thanks, David McLaughlin

Re: Review Request 20344: AURORA-267: Add container to popover to avoid clipping issue

2014-04-16 Thread David McLaughlin
/20344/diff/ Testing --- Ran locally and verified. This is a pretty widely known issue: https://github.com/twbs/bootstrap/issues/5889 Thanks, David McLaughlin

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-16 Thread David McLaughlin
, taskConstraint.value.values will always exist and will always be an array? Otherwise you should add checks for that too. - David McLaughlin On April 16, 2014, 8:37 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply

Review Request 20469: AURORA-178 - Log snapshot operations

2014-04-17 Thread David McLaughlin
, David McLaughlin

Re: Review Request 20469: AURORA-178 - Log snapshot operations

2014-04-17 Thread David McLaughlin
/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11 Diff: https://reviews.apache.org/r/20469/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-17 Thread David McLaughlin
On April 17, 2014, 12:21 a.m., David McLaughlin wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 365 https://reviews.apache.org/r/19833/diff/7/?file=560830#file560830line365 Why are you passing $scope.role, $scope.environment and $scope.job

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-18 Thread David McLaughlin
be clearer, but that doesn't need to block this. I can always cut a branch with a suggested refactor once this ships. - David McLaughlin On April 18, 2014, 2 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail

Re: Review Request 19833: Migrated Job page to angular JS

2014-04-18 Thread David McLaughlin
be clearer, but that doesn't need to block this. I can always cut a branch with a suggested refactor once this ships. - David McLaughlin On April 18, 2014, 2 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-24 Thread David McLaughlin
April 24, 2014, 7:30 p.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Bugs: aurora-270 https://issues.apache.org/jira/browse/aurora-270 Repository: aurora Description --- Stage 1 of implementing command hooks for aurora v2. This change includes

Re: Review Request 20469: AURORA-178 - Log snapshot operations

2014-04-25 Thread David McLaughlin
/LogStorage.java a1a0b428ba42d1abefed18bb40ca54c351154e11 Diff: https://reviews.apache.org/r/20469/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread David McLaughlin
/ --- (Updated April 25, 2014, 12:17 a.m.) Review request for Aurora, David McLaughlin and Suman Karumuri. Bugs: aurora-270 https://issues.apache.org/jira/browse/aurora-270 Repository: aurora Description --- Stage 1

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread David McLaughlin
in the hook. David McLaughlin wrote: I think exceptions are designed for exactly this... the hook authors can also give their own error messages. I'm not sure I understand why the distinction between an error in the hook and a request to stop the command is important. Why not just ask

Re: Review Request 20723: Add batch options to kill and killall.

2014-04-25 Thread David McLaughlin
://reviews.apache.org/r/20723/#comment74960 Shouldn't this be batch_size for consistency with the other commands? - David McLaughlin On April 25, 2014, 6:23 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 20723: Add batch options to kill and killall.

2014-04-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20723/#review41509 --- Ship it! lgtm - David McLaughlin On April 25, 2014, 7:15 p.m

Re: Review Request 20687: Stage 1 of implementing command hooks for aurora v2.

2014-04-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20687/#review41510 --- Ship it! Ship It! - David McLaughlin On April 25, 2014, 12:17

Re: Review Request 20707: Fix a plugins glitch.

2014-04-25 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20707/#review41512 --- Ship it! lgtm - David McLaughlin On April 25, 2014, 6:33 p.m

Re: Review Request 20394: Add return code to task/process pages

2014-04-28 Thread David McLaughlin
--- Thanks, David McLaughlin

Re: Review Request 20928: Command hooks: stage 2.

2014-05-01 Thread David McLaughlin
/#comment75616 Further to above, could you add some test cases for some partially defined JSON documents? - David McLaughlin On May 1, 2014, 8:47 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 20928: Command hooks: stage 2.

2014-05-01 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20928/#review41958 --- Ship it! lgtm - David McLaughlin On May 1, 2014, 9:39 p.m

Re: Review Request 21023: Make --help defer to bridged help in the bridged client executable.

2014-05-02 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21023/#review42055 --- Ship it! Ship It! - David McLaughlin On May 2, 2014, 8:02 p.m

Re: Review Request 21093: Showing status message in Job UI

2014-05-05 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21093/#review42232 --- Ship it! Ship It! - David McLaughlin On May 6, 2014, 12:43 a.m

Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-06 Thread David McLaughlin
://reviews.apache.org/r/21132/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 21205: Bugfix: restart doesn't notify user about invalid max_total_failures option.

2014-05-10 Thread David McLaughlin
https://reviews.apache.org/r/21205/#comment76401 checkstyle: extra newline - David McLaughlin On May 8, 2014, 2:26 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-05-10 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19788/#review42425 --- Ship it! Ship It! - David McLaughlin On May 7, 2014, 7:47 p.m

Re: Review Request 20394: Add return code to task/process pages

2014-05-11 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20394/#review42339 --- On April 28, 2014, 10:48 p.m., David McLaughlin wrote

Re: Review Request 21223: Bugfix: make restart command generate a correct error message in some cases.

2014-05-11 Thread David McLaughlin
/test_restarter.py https://reviews.apache.org/r/21223/#comment76403 trailing ws - David McLaughlin On May 8, 2014, 3:45 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-12 Thread David McLaughlin
a5191500b2958253e14843089a15a1ffd58e6846 Diff: https://reviews.apache.org/r/21132/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-12 Thread David McLaughlin
., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/ --- (Updated May 9, 2014, 11:47 p.m.) Review request

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-12 Thread David McLaughlin
--- On May 8, 2014, 11:45 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21247

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-12 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21247/#review42617 --- On May 12, 2014, 6:50 p.m., David McLaughlin wrote

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-12 Thread David McLaughlin
On May 9, 2014, 10:27 p.m., Bill Farner wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 400 https://reviews.apache.org/r/21247/diff/1/?file=577123#file577123line400 s/if(/if (/ David McLaughlin wrote: done. would be nice to have

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-12 Thread David McLaughlin
-732e782204b6__Screen_Shot_2014-05-08_at_4.25.36_PM.png Viewing multiple configs at the same time https://reviews.apache.org/media/uploaded/files/2014/05/08/b7b2cba1-034b-43e6-9eaa-3ba1a78f87f5__Screen_Shot_2014-05-08_at_4.25.42_PM.png Thanks, David McLaughlin

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-12 Thread David McLaughlin
/files/2014/05/08/b7b2cba1-034b-43e6-9eaa-3ba1a78f87f5__Screen_Shot_2014-05-08_at_4.25.42_PM.png Thanks, David McLaughlin

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-12 Thread David McLaughlin
On May 10, 2014, 2:14 a.m., Suman Karumuri wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/configSummary.html, line 1 https://reviews.apache.org/r/21247/diff/1/?file=577119#file577119line1 wrap this in a div. David McLaughlin wrote: Why? Suman Karumuri

Re: Review Request 21250: Removed cron jobs table from role and env page. Added cron job summary to job page.

2014-05-12 Thread David McLaughlin
? - David McLaughlin On May 12, 2014, 8:36 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21250/ --- (Updated

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-12 Thread David McLaughlin
-08_at_4.25.42_PM.png screenshot of really small group https://reviews.apache.org/media/uploaded/files/2014/05/12/2d7999ac-ba1f-45b0-bf9e-99f9c7a10009__Screen_Shot_2014-05-12_at_1.27.59_PM.png Thanks, David McLaughlin

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-12 Thread David McLaughlin
screenshot of really small group https://reviews.apache.org/media/uploaded/files/2014/05/12/2d7999ac-ba1f-45b0-bf9e-99f9c7a10009__Screen_Shot_2014-05-12_at_1.27.59_PM.png Thanks, David McLaughlin

Re: Review Request 21170: Make the task run command accept an instances spec.

2014-05-12 Thread David McLaughlin
://reviews.apache.org/r/21170/#comment76400 Should add the response code to this log message. - David McLaughlin On May 7, 2014, 6:48 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 21352: Fix regression causing scheduling rate limiter to not be honored.

2014-05-12 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21352/#review42792 --- Ship it! lgtm. - David McLaughlin On May 13, 2014, 12:06 a.m

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-13 Thread David McLaughlin
--- On May 8, 2014, 11:45 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21247/ --- (Updated May 8

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread David McLaughlin
a5191500b2958253e14843089a15a1ffd58e6846 Diff: https://reviews.apache.org/r/21132/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread David McLaughlin
/MemLockStoreTest.java a5191500b2958253e14843089a15a1ffd58e6846 Diff: https://reviews.apache.org/r/21132/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread David McLaughlin
: private static ILock makeLock(JobKey job) { ... } David McLaughlin wrote: ack. Since it is useful to be able to differentiate between two locks (and we do this in at least one test), I'm going to add two methods. One which returns a Lock and one

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread David McLaughlin
. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review42729 --- On May 9, 2014, 11:47 p.m., David McLaughlin wrote

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-13 Thread David McLaughlin
34377430268002e8e8e5bc803b409e092bb86720 src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java a5191500b2958253e14843089a15a1ffd58e6846 Diff: https://reviews.apache.org/r/21132/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 21354: Fixed duration calculation in the job page.

2014-05-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21354/#review42896 --- Ship it! Ship It! - David McLaughlin On May 13, 2014, 12:58 a.m

Re: Review Request 21273: Add a config noun with a list verb to list jobs defined in a config file.

2014-05-13 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21273/#review42897 --- Ship it! Ship It! - David McLaughlin On May 13, 2014, 6:09 p.m

Re: Review Request 21273: Add a config noun with a list verb to list jobs defined in a config file.

2014-05-13 Thread David McLaughlin
://reviews.apache.org/r/21273/#comment76739 Is it just me or a lot of these imports unused? - David McLaughlin On May 9, 2014, 6:05 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-13 Thread David McLaughlin
-12_at_1.27.59_PM.png Thanks, David McLaughlin

Review Request 21407: Add JSHint to our build

2014-05-13 Thread David McLaughlin
: 1 mins 16.824 secs Thanks, David McLaughlin

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-14 Thread David McLaughlin
- David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21247/#review42937 --- On May 14, 2014, 1:30 a.m., David McLaughlin wrote

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-14 Thread David McLaughlin
/media/uploaded/files/2014/05/12/2d7999ac-ba1f-45b0-bf9e-99f9c7a10009__Screen_Shot_2014-05-12_at_1.27.59_PM.png Thanks, David McLaughlin

Re: Review Request 21426: Added a nav bar with Aurora logo.

2014-05-14 Thread David McLaughlin
://aurora.incubator.apache.org/ Although preferably with the logo made smaller to avoid taking up so much screen real estate. - David McLaughlin On May 14, 2014, 3:43 a.m., Suman Karumuri wrote: --- This is an automatically generated e

Re: Review Request 21232: Add a strict mode for commands that specify instances.

2014-05-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21232/#review42591 --- Ship it! Ship It! - David McLaughlin On May 8, 2014, 6:54 p.m

Re: Review Request 21145: Changed sandbox link from span2 to span3.

2014-05-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21145/#review42538 --- Ship it! Ship It! - David McLaughlin On May 8, 2014, 8:23 p.m

Re: Review Request 21170: Make the task run command accept an instances spec.

2014-05-14 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21170/#review42587 --- Ship it! - David McLaughlin On May 7, 2014, 6:48 p.m., Mark Chu

Review Request 21247: Add config grouping visualisation to job page

2014-05-15 Thread David McLaughlin
-08_at_4.25.36_PM.png Viewing multiple configs at the same time https://reviews.apache.org/media/uploaded/files/2014/05/08/b7b2cba1-034b-43e6-9eaa-3ba1a78f87f5__Screen_Shot_2014-05-08_at_4.25.42_PM.png Thanks, David McLaughlin

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-15 Thread David McLaughlin
--- On May 6, 2014, 11 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132

Re: Review Request 21407: Add JSHint to our build

2014-05-15 Thread David McLaughlin
. :jacocoTestReport Coverage report generated: file:Users/dmclaughlin/t/incubator-aurora/dist/reports/jacoco/test/html/index.html :check :build BUILD SUCCESSFUL Total time: 1 mins 16.824 secs Thanks, David McLaughlin

Re: Review Request 21426: Added a nav bar with Aurora logo.

2014-05-16 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21426/#review43077 --- Ship it! Ship It! - David McLaughlin On May 15, 2014, 1:34 a.m

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-16 Thread David McLaughlin
. By passing in $scope, it is very unclear what inputs buildGroupSummary depends on. David McLaughlin wrote: The function signature is quite clear that buildGroupSummary is a function which depends on the global $scope (it both reads and writes to it - this is how Angular passes around

Re: Review Request 21407: Add JSHint to our build

2014-05-16 Thread David McLaughlin
. - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21407/#review43123 --- On May 14, 2014, 10:22 p.m., David McLaughlin wrote

Re: Review Request 21250: Removed cron jobs table from role and env page. Added cron job summary to job page.

2014-05-16 Thread David McLaughlin
/#comment77221 Please give a brief code comment describing what this code is doing. - David McLaughlin On May 15, 2014, 12:46 a.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 21247: Add config grouping visualisation to job page

2014-05-16 Thread David McLaughlin
https://reviews.apache.org/media/uploaded/files/2014/05/12/2d7999ac-ba1f-45b0-bf9e-99f9c7a10009__Screen_Shot_2014-05-12_at_1.27.59_PM.png Thanks, David McLaughlin

Re: Review Request 21459: Database-backed implementation of QuotaStore.

2014-05-16 Thread David McLaughlin
/QuotaMapper.java https://reviews.apache.org/r/21459/#comment77236 Please add docs, particularly to merge. - David McLaughlin On May 14, 2014, 9:22 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-16 Thread David McLaughlin
On May 16, 2014, 5:05 p.m., Mark Chu-Carroll wrote: src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, line 17 https://reviews.apache.org/r/21523/diff/1/?file=582876#file582876line17 Why? David McLaughlin wrote: Good question. JavaScript

Re: Review Request 21250: Removed cron jobs table from role and env page. Added cron job summary to job page.

2014-05-16 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21250/#review43164 --- Ship it! Ship It! - David McLaughlin On May 15, 2014, 9:07 p.m

Review Request 21523: Make JS compliant with JSHint rules

2014-05-16 Thread David McLaughlin
Diff: https://reviews.apache.org/r/21523/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 21497: Add CORS support to thrift end points.

2014-05-16 Thread David McLaughlin
https://reviews.apache.org/r/21497/#comment77200 Please either add an additional flag that allows you to set the origin, or just modify this flag to accept that value. i.e. --enable_cors_for=* - David McLaughlin On May 15, 2014, 7:28 p.m., Suman Karumuri wrote

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-16 Thread David McLaughlin
. Does it mean we would have to add n mappers here if we add n new fields into the LockKey? Any way this could be generalized or abstracted out? David McLaughlin wrote: We would need to add n mappers if the we expand LockKey's fields. Most likely we would change the design when

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-16 Thread David McLaughlin
--- On May 16, 2014, 1:30 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21523

Re: Review Request 21407: Add JSHint to our build

2014-05-16 Thread David McLaughlin
/src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js:211:27) return _.contains(ACTIVE_STATES, task.status); David McLaughlin wrote: Adding thrift sources wouldn't remove that error, it would just run JSHint against them too (which we don't want

Re: Review Request 19788: Add a clientv2 version of the e2e test.

2014-05-16 Thread David McLaughlin
. - David McLaughlin On April 27, 2014, 2:17 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19788

Re: Review Request 21497: Add CORS support to thrift end points.

2014-05-16 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21497/#review43192 --- Ship it! Ship It! - David McLaughlin On May 16, 2014, 12:16 a.m

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-16 Thread David McLaughlin
/html/index.html :check :build BUILD SUCCESSFUL Total time: 3 mins 19.979 secs Thanks, David McLaughlin

Review Request 21662: Move the cron summary underneath the config summary

2014-05-19 Thread David McLaughlin
://reviews.apache.org/r/21662/diff/ Testing --- Ran locally. File Attachments Screen Shot 2014-05-19 at 2.24.30 PM.png https://reviews.apache.org/media/uploaded/files/2014/05/19/00d7bd0c-6c8f-4932-aaea-abbea7d54d36__Screen_Shot_2014-05-19_at_2.24.30_PM.png Thanks, David

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-20 Thread David McLaughlin
--- On May 16, 2014, 1:30 a.m., David McLaughlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21523/ --- (Updated May 16, 2014, 1:30

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-20 Thread David McLaughlin
/index.html :check :build BUILD SUCCESSFUL Total time: 3 mins 19.979 secs Thanks, David McLaughlin

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-20 Thread David McLaughlin
Diff: https://reviews.apache.org/r/21132/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-20 Thread David McLaughlin
34377430268002e8e8e5bc803b409e092bb86720 src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java a5191500b2958253e14843089a15a1ffd58e6846 Diff: https://reviews.apache.org/r/21132/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-20 Thread David McLaughlin
fields into the LockKey? Any way this could be generalized or abstracted out? David McLaughlin wrote: We would need to add n mappers if the we expand LockKey's fields. Most likely we would change the design when that happens. I don't see a way to create a storage abstraction

Re: Review Request 21383: Add cron schedule and deschedule calls to the scheduler API.

2014-05-20 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21383/#review43535 --- Ship it! lgtm. - David McLaughlin On May 20, 2014, 12:25 a.m

Re: Review Request 21523: Make JS compliant with JSHint rules

2014-05-20 Thread David McLaughlin
) --- $ ./gradlew clean build Thanks, David McLaughlin

Re: Review Request 21753: Enable a few checkstyle checks.

2014-05-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21753/#review43644 --- Ship it! - David McLaughlin On May 21, 2014, 5:13 a.m., Bill

Re: Review Request 21754: Add PMD to the build.

2014-05-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21754/#review43646 --- Ship it! Ship It! - David McLaughlin On May 21, 2014, 6:05 a.m

Re: Review Request 21780: Adding cron client commands.

2014-05-21 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21780/#review43647 --- Ship it! Ship It! - David McLaughlin On May 21, 2014, 5:45 p.m

Review Request 21791: Do not show instance range when there is only one in group

2014-05-21 Thread David McLaughlin
: https://reviews.apache.org/r/21791/diff/ Testing --- Tested locally. Thanks, David McLaughlin

Re: Review Request 21791: Do not show instance range when there is only one in group

2014-05-21 Thread David McLaughlin
- - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21791/#review43664 --- On May 21, 2014, 10:35 p.m., David McLaughlin wrote

Review Request 21812: auroraUI needs to be global.

2014-05-22 Thread David McLaughlin
/ Testing --- ./gradlew build ./gradlew run Thanks, David McLaughlin

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review43377 --- On May 22, 2014, 5:59 p.m., David McLaughlin wrote

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
/scheduler/storage/mem/MemLockStoreTest.java a5191500b2958253e14843089a15a1ffd58e6846 Diff: https://reviews.apache.org/r/21132/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java a5191500b2958253e14843089a15a1ffd58e6846 Diff: https://reviews.apache.org/r/21132/diff/ Testing --- Thanks, David McLaughlin

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
34377430268002e8e8e5bc803b409e092bb86720 src/test/java/org/apache/aurora/scheduler/storage/mem/MemLockStoreTest.java a5191500b2958253e14843089a15a1ffd58e6846 Diff: https://reviews.apache.org/r/21132/diff/ Testing (updated) --- ./gradlew clean build Thanks, David McLaughlin

Re: Review Request 21132: Initial attempt at h2/DB storage implementation (LockStore only)

2014-05-22 Thread David McLaughlin
generated e-mail. To reply, visit: https://reviews.apache.org/r/21132/#review43743 --- On May 22, 2014, 6:26 p.m., David McLaughlin wrote: --- This is an automatically generated e-mail

Re: Review Request 21790: Upgrade Aurora UI to bootstrap3

2014-05-22 Thread David McLaughlin
with this review. Is there any way to tell bower to only install the files defined in main? The vast majority of these new files are superfluous. - David McLaughlin On May 22, 2014, 7:09 p.m., Suman Karumuri wrote: --- This is an automatically

Review Request 21828: Use asynchronous transport in Thrift.js client

2014-05-22 Thread David McLaughlin
: https://reviews.apache.org/r/21828/diff/ Testing --- ./gradlew clean build ./gradlew clean run Thanks, David McLaughlin

  1   2   3   4   >