Review Request 17293: s/thermos_observe/thermos_observer/ in README.md

2014-01-23 Thread David Robinson
, David Robinson

Re: Review Request 17293: s/thermos_observe/thermos_observer/ in README.md

2014-01-23 Thread David Robinson
4bfefd37163dfbc5947acc7adc52f57c95cd174f Diff: https://reviews.apache.org/r/17293/diff/ Testing --- None, it's a document and it's out of date. Thanks, David Robinson

Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-02 Thread David Robinson
. SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, David Robinson

Re: Review Request 17645: added rollback_on_failure to UpdateConfig

2014-02-02 Thread David Robinson
src.test.python.apache.aurora.client.hooks.hooked_api . SUCCESS src.test.python.apache.aurora.client.hooks.non_hooked_api . SUCCESS Thanks, David Robinson

Re: Review Request 17948: Implement help message generation for the noun/verb framework.

2014-02-11 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17948/#review34259 --- Ship it! lgtm - David Robinson On Feb. 11, 2014, 3:31 p.m

Re: Review Request 18265: Add configuration plugins to the clientv2 framework

2014-02-20 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18265/#review35069 --- Ship it! Ship It! - David Robinson On Feb. 19, 2014, 5:55 p.m

Re: Review Request 18267: Implement help for v2 bridge

2014-02-20 Thread David Robinson
://reviews.apache.org/r/18267/#comment65459 Shouldn't this be removed? It's defined above. - David Robinson On Feb. 20, 2014, 9:02 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 16062: fixed structdump usage message

2014-02-27 Thread David Robinson
/ Testing --- zilch Thanks, David Robinson

Review Request 18746: fix rollback on failure

2014-03-04 Thread David Robinson
sorting out vagrant. Thanks, David Robinson

Re: Review Request 18819: Removing rollback_on_failure from restart options.

2014-03-05 Thread David Robinson
://reviews.apache.org/r/18746/ Would it be worthwhile exposing the feature as a flag in addition to a config option? - David Robinson On March 5, 2014, 11:20 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 18819: Removing rollback_on_failure from restart options.

2014-03-06 Thread David Robinson
On March 6, 2014, 12:43 a.m., David Robinson wrote: I added the missing flag instead: https://reviews.apache.org/r/18746/ Would it be worthwhile exposing the feature as a flag in addition to a config option? Brian Wickman wrote: I'm not sure the flag makes sense

Re: Review Request 19505: Die, underscores, die!

2014-03-20 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19505/#review38024 --- Ship it! Ship It! - David Robinson On March 20, 2014, 10:59 p.m

Re: Review Request 20010: Fix two clientv2 command-line bugs.

2014-04-03 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20010/#review39480 --- Ship it! Ship It! - David Robinson On April 3, 2014, 5:15 p.m

Re: Review Request 20009: Add the open command to clientv2, and fix an error case in v1.

2014-04-03 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20009/#review39481 --- Ship it! Ship It! - David Robinson On April 3, 2014, 4:58 p.m

Re: Review Request 20521: Extend the client configuration plugin architecture.

2014-04-22 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20521/#review41056 --- Ship it! Ship It! - David Robinson On April 22, 2014, 7:38 p.m

Re: Review Request 21093: Showing status message in Job UI

2014-05-05 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21093/#review42231 --- Ship it! Ship It! - David Robinson On May 6, 2014, 12:43 a.m

Re: Review Request 20285: Improve documentation and testing for host maintenance API

2014-05-23 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20285/#review43886 --- Ship it! Ship It! - David Robinson On May 21, 2014, 3:51 a.m

Re: Review Request 23189: Export zero for racks that have no lost tasks.

2014-07-01 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23189/#review47095 --- Ship it! Ship It! - David Robinson On July 1, 2014, 1:53 a.m

Review Request 23329: remove embedded jquery

2014-07-07 Thread David Robinson
://reviews.apache.org/r/23329/diff/ Testing --- Thanks, David Robinson

Re: Review Request 23329: remove embedded jquery

2014-07-09 Thread David Robinson
--- On July 8, 2014, 1:08 a.m., David Robinson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23329

Re: Review Request 23329: remove embedded jquery

2014-07-09 Thread David Robinson
://reviews.apache.org/r/23329/diff/ Testing --- Thanks, David Robinson

Re: Review Request 23949: Make testing of v1 command hooks easier.

2014-07-29 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23949/#review49009 --- Ship it! Ship It! - David Robinson On July 25, 2014, 8:50 p.m

Re: Review Request 23330: replace 143 kB favicon with 318 byte version

2014-07-30 Thread David Robinson
3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c Diff: https://reviews.apache.org/r/23330/diff/ Testing --- Thanks, David Robinson

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-19 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51045 --- Ship it! Ship It! - David Robinson On Aug. 19, 2014, 10:51 p.m

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

2014-09-03 Thread David Robinson
://reviews.apache.org/r/25175/#comment90965 This changes the return value from 0 to None upon timeout. Perhaps change 'break' to 'return 0'? - David Robinson On Aug. 28, 2014, 11:34 p.m., Brian Wickman wrote: --- This is an automatically

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread David Robinson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206/#review52235 --- Ship it! Ship It! - David Robinson On Sept. 3, 2014, 6:33 p.m

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread David Robinson
to match. src/test/python/apache/aurora/executor/common/test_health_checker.py https://reviews.apache.org/r/25337/#comment91190 Why do you need to cast num_calls? - David Robinson On Sept. 5, 2014, 1:20 a.m., Joe Smith wrote

Re: Review Request 23330: replace 143 kB favicon with 318 byte version

2014-09-29 Thread David Robinson
/favicon - David --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23330/#review54819 --- On July 31, 2014, 12:13 a.m., David Robinson wrote

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread David Robinson
/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson

Re: Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-12 Thread David Robinson
src/test/python/apache/aurora/client/test_base.py ... 7 passed in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson

Review Request 31913: Added 'none' host maintenance grouping function.

2015-03-10 Thread David Robinson
in 0.10 seconds 15:43:41 00:01 [junit] 15:43:41 00:01 [specs] SUCCESS Thanks, David Robinson