Re: Review Request 26244: Add a doc about dedicated hosts.

2014-10-01 Thread Jay Buffington
rather than a role + job. I assume environment cannot go into the value for dedicated. Thanks so much for writing this! - Jay Buffington On Oct. 2, 2014, 12:09 a.m., Bill Farner wrote: --- This is an automatically generated e

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-16 Thread Jay Buffington
On Oct. 16, 2014, 11:03 p.m., Joshua Cohen wrote: docs/client-cluster-configuration.md, line 34 https://reviews.apache.org/r/26834/diff/1/?file=723472#file723472line34 I think an argument could be made for removing this configuration entirely and just hardcoding this into the

Re: Review Request 26856: Adding storage configuration summary.

2014-10-17 Thread Jay Buffington
, right? Maybe link to a page that enumerates all flags. docs/storage_config.md https://reviews.apache.org/r/26856/#comment97600 This is a knit, but I would s/this document/the replicated log configuration document/; - Jay Buffington On Oct. 17, 2014, 3:16 a.m., Maxim Khutornenko wrote

Re: Review Request 26822: Fix table of contents in configuration-tutorial.md

2014-10-17 Thread Jay Buffington
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26822/#review57141 --- Ship it! Thanks! That always bugged me! - Jay Buffington

Re: Review Request 26834: Add client cluster configuration docs.

2014-10-17 Thread Jay Buffington
in a loadbalancer or a roundrobin DNS name. - Jay Buffington On Oct. 17, 2014, 12:37 a.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26834

Re: Review Request 26845: Adding Aurora scheduler storage doc.

2014-10-17 Thread Jay Buffington
://reviews.apache.org/r/26845/#comment97609 The ellipses serve no purpose. I'd remove them, but this is a minor knit. - Jay Buffington On Oct. 17, 2014, 12:21 a.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 26836: Cron documentation

2014-10-17 Thread Jay Buffington
I'd add a link here like this: The full specification for cron_schedule is [described below(however you anchor link to ## Technical Note About Syntax) docs/cron-jobs.md https://reviews.apache.org/r/26836/#comment97614 s/indepdendently/independently/ - Jay Buffington

Re: Review Request 28198: Add an example on how to build with Docker.

2014-12-12 Thread Jay Buffington
into the container. We run build this docker container on every commit through a CI process and ship it to a docker registry. Then to run, users just have to do docker run aurora/aurora - Jay Buffington On Dec. 11, 2014, 6:32 p.m., Tony Dong wrote

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-12 Thread Jay Buffington
should just remove it. - Jay Buffington On Dec. 11, 2014, 6:16 a.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-16 Thread Jay Buffington
to be modified to send the scheduler more state. Related to this is that when the docker pull takes longer than transient_state_task_timeout aurora will give up and fail the task. - Jay Buffington On Dec. 16, 2014, 9:19 p.m., Steve Niemitz wrote

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-16 Thread Jay Buffington
in ExecutorSettings if it isn't set. - Jay Buffington On Dec. 16, 2014, 9:19 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-22 Thread Jay Buffington
/MesosTaskFactory.java https://reviews.apache.org/r/28920/#comment114008 Can you set force_pull_image to true here. I can't imagine why you would ever want that to be false. https://github.com/apache/mesos/blob/master/include/mesos/mesos.proto#L1028 - Jay Buffington On Jan. 16, 2015, 12:08 a.m., Steve

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-05 Thread Jay Buffington
On Dec. 13, 2014, 1:59 a.m., Jay Buffington wrote: src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java, line 279 https://reviews.apache.org/r/28920/diff/2/?file=789365#file789365line279 I would do away with this TaskConfig hasProcesses field. You should just