On Jan. 25, 2014, 10:58 a.m., Joe Smith wrote:
src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java,
line 116
https://reviews.apache.org/r/17353/diff/1/?file=450927#file450927line116
potentially naive thought- might it be interesting to also have a way
:
src.test.python.apache.aurora.client.commands.maintenance
. SUCCESS
Thanks,
Joe Smith
---
On Feb. 24, 2014, 10:19 a.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18334
/test_maintenance.py
PRE-CREATION
Diff: https://reviews.apache.org/r/18334/diff/
Testing
---
./pants ./src/test/python/apache/aurora:all
particularly:
src.test.python.apache.aurora.client.commands.maintenance
. SUCCESS
Thanks,
Joe Smith
to explicitly call out I'm using system time to avoid missed
mock coverage causing the test suite to slow down.
Joe Smith wrote:
hm.. any chance you have suggestions on how to pass this through? I'd
prefer not to add it to the command line itself, I think
Kevin Sweeney wrote
://reviews.apache.org/r/18334/diff/
Testing
---
./pants ./src/test/python/apache/aurora:all
particularly:
src.test.python.apache.aurora.client.commands.maintenance
. SUCCESS
Thanks,
Joe Smith
start_maintenance_hosts
FATAL] usage: start_maintenance_hosts {--filename=filename | --hosts=hosts}
see the help subcommand for more details.
Thanks,
Joe Smith
On April 15, 2014, 10:42 a.m., Joe Smith wrote:
src/main/python/apache/aurora/common/shellify.py, line 7
https://reviews.apache.org/r/20046/diff/3/?file=557760#file557760line7
Any chance you can also put in sphinx-y/reStructuredText[1] docstrings
for the params?
[1
://reviews.apache.org/r/18979/#comment74104
hoorah!
- Joe Smith
On March 21, 2014, 10:58 a.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18979
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20629/#review41478
---
Ship it!
Works for me
- Joe Smith
On April 23, 2014, 12:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21136/#review42421
---
Ship it!
fwiw, lgtm as-is
- Joe Smith
On May 6, 2014, 4:10 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18979/#review43117
---
Ship it!
awesome!!!
- Joe Smith
On May 12, 2014, 5:15 a.m
src.test.python.apache.aurora.client.api.scheduler_client
. SUCCESS
Thanks,
Joe Smith
48 passed, 1 skipped in 4.53 seconds
src.test.python.apache.aurora.client.api.scheduler_client
. SUCCESS
Thanks,
Joe Smith
-mail. To reply, visit:
https://reviews.apache.org/r/21739/#review43567
---
On May 20, 2014, 4:57 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit
---
On April 12, 2014, 4:45 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20285
seconds
==
src.test.python.apache.aurora.admin.host_maintenance
. SUCCESS
Thanks,
Joe Smith
this.
Joe Smith wrote:
I'm happy to, but kts has suggested I use this (more explicit) method
instead. I kinda appreciate this more explicit call out as well, mind if I
hang tight for his opinion?
Kevin Sweeney wrote:
I typically like to make time a parameter directly so
---
On May 22, 2014, 11:14 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21848
)
- Joe Smith
On May 22, 2014, 6:12 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21741/
---
(Updated
---
On May 20, 2014, 8:51 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20285
==
src.test.python.apache.aurora.admin.host_maintenance
. SUCCESS
Thanks,
Joe Smith
/test_host_maintenance.py
ed0782b72eb12c45cefda2c3081f48b933dda206
src/test/python/apache/aurora/client/commands/test_maintenance.py
dd56b8d1feddb48a741e1a855833eb577cea67ab
Diff: https://reviews.apache.org/r/20285/diff/
Testing (updated)
---
./pants ./src/test/python/apache/aurora:all
Thanks,
Joe
/test_host_maintenance.py
176076f50c15f059c9b6876abbf56cacf5aa0f90
src/test/python/apache/aurora/client/commands/test_maintenance.py
dd56b8d1feddb48a741e1a855833eb577cea67ab
Diff: https://reviews.apache.org/r/20285/diff/
Testing
---
./pants ./src/test/python/apache/aurora:all
Thanks,
Joe Smith
/admin/admin_util.py
https://reviews.apache.org/r/22167/#comment80260
parse_hostnames
src/test/python/apache/aurora/admin/test_host_maintenance.py
https://reviews.apache.org/r/22167/#comment80263
doh. thanks
- Joe Smith
On June 11, 2014, 10:04 a.m., Maxim Khutornenko wrote
/aurora/client/cli/json_tree_diff.py
https://reviews.apache.org/r/22457/#comment80539
is this actually called somewhere?
(and I promise I tried to understand what this is doing, but I can't ~_~)
(what does 'rebase' mean?)
- Joe Smith
On June 11, 2014, 8 a.m., Mark Chu-Carroll
naive question- should there be a matching change somewhere else here? (at
least in a test maybe?)
- Joe Smith
On June 11, 2014, 4:32 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit
On June 13, 2014, 12:44 p.m., Joe Smith wrote:
+1 to exposing this via thrift if possible- can we just start with
getAllLocks and getLocksForRole? (seems you're concerned about us
publishing an API before its thought through.. however if we're adding this
now it seems like we're
://reviews.apache.org/r/22611/diff/
Testing
---
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22662/#review45863
---
On June 16, 2014, 4:09 p.m., Joe Smith wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22662/#review45863
---
On June 16, 2014, 4:09 p.m., Joe Smith wrote
src/main/python/apache/aurora/admin/BUILD
637f4e66c5fdcebea125626d1bf2883fbac9af41
src/main/thrift/org/apache/aurora/gen/BUILD
dd401f2a5d85dbcfa340017cc5603ee0b24a3d2d
Diff: https://reviews.apache.org/r/22662/diff/
Testing
---
On OS X 10.9: ./pants ./src/test/python:all
Thanks,
Joe
637f4e66c5fdcebea125626d1bf2883fbac9af41
src/main/thrift/org/apache/aurora/gen/BUILD
dd401f2a5d85dbcfa340017cc5603ee0b24a3d2d
Diff: https://reviews.apache.org/r/22662/diff/
Testing
---
On OS X 10.9: ./pants ./src/test/python:all
Thanks,
Joe Smith
://reviews.apache.org/r/22747/diff/
Testing
---
It works?
Thanks,
Joe Smith
---
It works?
Thanks,
Joe Smith
e-mail. To reply, visit:
https://reviews.apache.org/r/22747/#review46208
---
On June 20, 2014, 11:05 a.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply
---
It works?
Thanks,
Joe Smith
of the pants
migration.
- Joe Smith
On June 23, 2014, 3:38 p.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22894
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22896/#review46477
---
Ship it!
Ship It!
- Joe Smith
On June 23, 2014, 4:49 p.m
containing:
1) list of output strings
2) set of hostnames included in output
- Joe Smith
On June 20, 2014, 2:40 p.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/22697/#comment82214
This is a purely
docs/sla.md
https://reviews.apache.org/r/22697/#comment82215
that helps track
- Joe Smith
On June 25, 2014, 9:48 a.m., Maxim Khutornenko wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22842/#review46794
---
Ship it!
Ship It!
- Joe Smith
On June 25, 2014, 11:48 a.m
a70f81795465595fb81430e3faa004f4eb12a0c2
src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java
c314a2ba36f36762fb7f3ac682bc5a22608edcbb
Diff: https://reviews.apache.org/r/23180/diff/
Testing
---
$ ./gradlew test
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23180/#review47019
---
On June 30, 2014, 4:12 p.m., Joe Smith wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23528/#review47840
---
Ship it!
awesome
- Joe Smith
On July 15, 2014, 4:37 p.m., Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23455/#review48075
---
Ship it!
Ship It!
- Joe Smith
On July 14, 2014, 10:50 a.m
/python/apache/aurora/admin/test_admin_util.py
https://reviews.apache.org/r/24019/#comment86232
import subprocess
src/test/python/apache/aurora/admin/test_admin_util.py
https://reviews.apache.org/r/24019/#comment86231
...subprocess, spec=subprocess)
- Joe Smith
On July 31, 2014, 1:16
these after the deprecation,
but I suppose these files are going to get rm'd completely, so lgtm.
- Joe Smith
On July 31, 2014, 11:40 a.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
these after the deprecation,
but I suppose these files are going to get rm'd completely, so lgtm.
- Joe Smith
On July 31, 2014, 11:40 a.m., Mark Chu-Carroll wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24261/#review49525
---
Ship it!
Ship It!
- Joe Smith
On Aug. 4, 2014, 1:59 p.m., Mark
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23348/#review50079
---
Ship it!
+1 to going to 0.19.0 first.
- Joe Smith
On Aug. 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24651/#review50475
---
Ship it!
Ship It!
- Joe Smith
On Aug. 13, 2014, 8:28 a.m., Mark
/commands/maintenance.py
https://reviews.apache.org/r/24871/#comment89472
ack on this- it'd be nice to still have a '1-command-for-all-the-things'
but that's aight
- Joe Smith
On Aug. 21, 2014, 4:23 p.m., Maxim Khutornenko wrote
On Aug. 22, 2014, 11:39 a.m., Joe Smith wrote:
src/main/python/apache/aurora/admin/host_maintenance.py, line 187
https://reviews.apache.org/r/24871/diff/2/?file=68#file68line187
If we're no longer wrapping a full maintenance process (which is fine)
we shouldn't do
. SUCCESS
src.test.python.apache.aurora.executor.thermos_executor
. SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
. SUCCESS
Thanks,
Joe Smith
src.test.python.apache.aurora.executor.thermos_task_runner
. SUCCESS
Thanks,
Joe Smith
src.test.python.apache.aurora.executor.thermos_task_runner
. SUCCESS
Thanks,
Joe Smith
src.test.python.apache.aurora.executor.thermos_executor
. SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
. SUCCESS
Thanks,
Joe Smith
://reviews.apache.org/r/25208/#review52049
---
On Sept. 2, 2014, 5:45 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r
:45 p.m., Joe Smith wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/
---
(Updated Sept. 2, 2014, 5:45 p.m.)
Review
://reviews.apache.org/r/25206/#comment90865
aurora job run?
- Joe Smith
On Aug. 29, 2014, 4:17 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25206
On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote:
src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23
https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23
aurora job run?
Kevin and Toby, can you two take a look at this ASAP? I'd like to have the e2e
tests fixed
]]
+ echo 'Validated announced job.'
Validated announced job.
+ return 0
++ vagrant ssh -c 'aurora run devcluster/vagrant/test/http_example '\''pwd'\'''
++ wc -l
Thanks,
Joe Smith
On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote:
src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23
https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23
aurora job run?
Joe Smith wrote:
Kevin and Toby, can you two take a look at this ASAP? I'd like
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25208/#review52198
---
On Sept. 2, 2014, 9:06 p.m., Joe Smith wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25346/#review52334
---
Ship it!
thanks!
- Joe Smith
On Sept. 4, 2014, 11:48 a.m., Bill
. SUCCESS
src.test.python.apache.aurora.executor.thermos_task_runner
. SUCCESS
Thanks,
Joe Smith
src.test.python.apache.aurora.executor.thermos_task_runner
. SUCCESS
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52387
---
On Sept. 4, 2014, 5:43 p.m., Joe Smith wrote
. SUCCESS
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52389
---
On Sept. 4, 2014, 6:20 p.m., Joe Smith wrote
. SUCCESS
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25337/#review52395
---
On Sept. 4, 2014, 8 p.m., Joe Smith wrote:
---
This is an automatically
. SUCCESS
Thanks,
Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25466/#review52674
---
Ship it!
awesome
- Joe Smith
On Sept. 8, 2014, 7:13 p.m., Brian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52945
---
can you also add e2e test coverage?
- Joe Smith
On Sept. 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25519/#review52968
---
Ship it!
Ship It!
- Joe Smith
On Sept. 10, 2014, 3:43 p.m
://reviews.apache.org/r/25582/#comment92646
test_ssh_job_not_found
src/test/python/apache/aurora/client/cli/test_task_run.py
https://reviews.apache.org/r/25582/#comment92647
Test the ssh command for proper behavior when no tasks are found within a
job or something, I think
- Joe Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25582/#review53189
---
Ship it!
Ship It!
- Joe Smith
On Sept. 12, 2014, 10:17 a.m
On Sept. 12, 2014, 10:09 a.m., Joe Smith wrote:
src/test/python/apache/aurora/client/cli/test_task_run.py, line 228
https://reviews.apache.org/r/25582/diff/1/?file=687672#file687672line228
Test the ssh command for proper behavior when no tasks are found
within a job or something
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25543/#review53242
---
Ship it!
awesome- thanks!
- Joe Smith
On Sept. 11, 2014, 9:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25175/#review53367
---
Ship it!
Ship It!
- Joe Smith
On Sept. 15, 2014, 11:08 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25667/#review53419
---
Ship it!
Ship It!
- Joe Smith
On Sept. 15, 2014, 3:04 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26044/#review54570
---
Ship it!
Ship It!
- Joe Smith
On Sept. 25, 2014, 11:09 a.m
https://reviews.apache.org/r/25970/#comment94757
Isn't this not needed if you're specifying a side_effect?
- Joe Smith
On Sept. 25, 2014, 11:34 a.m., Maxim Khutornenko wrote:
---
This is an automatically generated e-mail. To reply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26089/#review54704
---
Ship it!
Ship It!
- Joe Smith
On Sept. 26, 2014, 10:53 a.m
://reviews.apache.org/r/26137/#comment95276
Could you update a test case to catch accessing these as properties to
catch accidental regressions?
- Joe Smith
On Sept. 29, 2014, 8:05 a.m., Mark Chu-Carroll wrote:
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26233/#review55091
---
Ship it!
Wow.
- Joe Smith
On Oct. 1, 2014, 10:27 a.m., Bill
On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote:
src/main/python/apache/aurora/client/cli/update.py, line 45
https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45
Could you update a test case to catch accessing these as properties to
catch accidental regressions
https://reviews.apache.org/r/26308/#comment95691
you need to set a spec here
Mock(SchedulerClient)
- Joe Smith
On Oct. 2, 2014, 7:38 p.m., Bill Farner wrote:
---
This is an automatically generated e-mail. To reply, visit
/test_helper.py
https://reviews.apache.org/r/25972/#comment95731
from psutil._common import puids
- Joe Smith
On Oct. 3, 2014, 10:55 a.m., Brian Wickman wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
https://reviews.apache.org/r/26308/#comment95761
Can you also assert that this was called?
src/test/python/apache/aurora/client/cli/test_api_from_cli.py
https://reviews.apache.org/r/26308/#comment95762
can you instead .assert_called_once_with(args) ?
- Joe Smith
On Oct. 2, 2014, 9:52
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25972/#review55410
---
Ship it!
Ship It!
- Joe Smith
On Oct. 3, 2014, 3:16 p.m., Brian
On Sept. 29, 2014, 11:32 p.m., Joe Smith wrote:
src/main/python/apache/aurora/client/cli/update.py, line 45
https://reviews.apache.org/r/26137/diff/1/?file=708198#file708198line45
Could you update a test case to catch accessing these as properties to
catch accidental regressions
=
src.test.python.apache.aurora.client.cli.help
. FAILURE
Thanks,
Joe Smith
=
src.test.python.apache.aurora.client.cli.help
. FAILURE
Thanks,
Joe Smith
/
Testing
---
[tw-172-25-132-201 aurora (yasumoto/pants_0.0.24)]$
./build-support/jenkins/build.sh
Thanks,
Joe Smith
-132-201 aurora (yasumoto/pants_0.0.24)]$
./build-support/jenkins/build.sh
Thanks,
Joe Smith
the before/after.
- Joe Smith
On Oct. 7, 2014, 12:58 p.m., Joshua Cohen wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26424/#review55727
---
Ship it!
Aha, here we go. Thanks!!
- Joe Smith
On Oct. 7, 2014
1 - 100 of 161 matches
Mail list logo
