Review Request 16762: Fix TaskPath import in thermos binary

2014-01-09 Thread Joe Smith
= src.test.python.apache.thermos.bin.test_thermos . SUCCESS Thanks, Joe Smith

Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Joe Smith
Description --- Fix maintenance command documentation and host/filename logic. Diffs - src/main/python/apache/aurora/client/commands/admin.py 8abb983084933f9320e782dc94f465139d559ebf Diff: https://reviews.apache.org/r/16983/diff/ Testing --- Thanks, Joe Smith

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-16 Thread Joe Smith
to style here, but i'm used to 'is not None'. Is bool() interchangeable/preferable? Joe Smith wrote: In theory, this is to represent xor (you specify at least a file of hosts or a string of hosts, but not both). This was to convert None/ to False and filename_or_hosts to True

Re: Review Request 17353: Add a stat that tracks the number of threads waiting for the storage lock.

2014-01-25 Thread Joe Smith
/ReadWriteLockManager.java https://reviews.apache.org/r/17353/#comment61753 potentially naive thought- might it be interesting to also have a way to look at getQueuedThreads, or is that already in /threads? - Joe Smith On Jan. 25, 2014, 9:15 a.m., Bill Farner wrote

Re: Review Request 17353: Add a stat that tracks the number of threads waiting for the storage lock.

2014-01-25 Thread Joe Smith
On Jan. 25, 2014, 10:58 a.m., Joe Smith wrote: src/main/java/org/apache/aurora/scheduler/storage/ReadWriteLockManager.java, line 116 https://reviews.apache.org/r/17353/diff/1/?file=450927#file450927line116 potentially naive thought- might it be interesting to also have a way

Re: Review Request 17359: Avoid using protobuf equals().

2014-01-25 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17359/#review32788 --- Ship it! Ship It! - Joe Smith On Jan. 25, 2014, 4:35 p.m., Bill

Review Request 18334: Move and unit test Maintenance module and commands

2014-02-20 Thread Joe Smith
: src.test.python.apache.aurora.client.commands.maintenance . SUCCESS Thanks, Joe Smith

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-03-03 Thread Joe Smith
--- On Feb. 24, 2014, 10:19 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18334

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-03-03 Thread Joe Smith
/test_maintenance.py PRE-CREATION Diff: https://reviews.apache.org/r/18334/diff/ Testing --- ./pants ./src/test/python/apache/aurora:all particularly: src.test.python.apache.aurora.client.commands.maintenance . SUCCESS Thanks, Joe Smith

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-03-05 Thread Joe Smith
to explicitly call out I'm using system time to avoid missed mock coverage causing the test suite to slow down. Joe Smith wrote: hm.. any chance you have suggestions on how to pass this through? I'd prefer not to add it to the command line itself, I think Kevin Sweeney wrote

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-03-07 Thread Joe Smith
://reviews.apache.org/r/18334/diff/ Testing --- ./pants ./src/test/python/apache/aurora:all particularly: src.test.python.apache.aurora.client.commands.maintenance . SUCCESS Thanks, Joe Smith

Review Request 19694: Add maintenance commands into aurora_admin

2014-03-26 Thread Joe Smith
start_maintenance_hosts FATAL] usage: start_maintenance_hosts {--filename=filename | --hosts=hosts} see the help subcommand for more details. Thanks, Joe Smith

Review Request 20285: Improve documentation and testing for host maintenance API

2014-04-12 Thread Joe Smith
Thanks, Joe Smith

Re: Review Request 20046: Add a new subcommand to aurora_admin to dump cluster state as a shell script.

2014-04-15 Thread Joe Smith
/common/shellify.py https://reviews.apache.org/r/20046/#comment73399 Any chance you can also put in sphinx-y/reStructuredText[1] docstrings for the params? [1] http://sphinx-doc.org/domains.html#info-field-lists - Joe Smith On April 14, 2014, 6:25 p.m., Kevin Sweeney wrote

Re: Review Request 20046: Add a new subcommand to aurora_admin to dump cluster state as a shell script.

2014-04-15 Thread Joe Smith
On April 15, 2014, 10:42 a.m., Joe Smith wrote: src/main/python/apache/aurora/common/shellify.py, line 7 https://reviews.apache.org/r/20046/diff/3/?file=557760#file557760line7 Any chance you can also put in sphinx-y/reStructuredText[1] docstrings for the params? [1

Re: Review Request 18979: Add an updated version of the clientv2 doc to apache.

2014-04-19 Thread Joe Smith
://reviews.apache.org/r/18979/#comment74104 hoorah! - Joe Smith On March 21, 2014, 10:58 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979

Re: Review Request 20629: End to end test should not look at the number of html lines.

2014-04-25 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20629/#review41478 --- Ship it! Works for me - Joe Smith On April 23, 2014, 12:59 p.m

Re: Review Request 21136: Add python import order wrapper/commit hook

2014-05-11 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21136/#review42421 --- Ship it! fwiw, lgtm as-is - Joe Smith On May 6, 2014, 4:10 p.m

Re: Review Request 18979: Add an updated version of the clientv2 doc to apache.

2014-05-16 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18979/#review43117 --- Ship it! awesome!!! - Joe Smith On May 12, 2014, 5:15 a.m

Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-20 Thread Joe Smith
src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS Thanks, Joe Smith

Re: Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-20 Thread Joe Smith
48 passed, 1 skipped in 4.53 seconds src.test.python.apache.aurora.client.api.scheduler_client . SUCCESS Thanks, Joe Smith

Re: Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-20 Thread Joe Smith
-mail. To reply, visit: https://reviews.apache.org/r/21739/#review43567 --- On May 20, 2014, 4:57 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 20285: Improve documentation and testing for host maintenance API

2014-05-20 Thread Joe Smith
--- On April 12, 2014, 4:45 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20285

Re: Review Request 20285: Improve documentation and testing for host maintenance API

2014-05-20 Thread Joe Smith
seconds == src.test.python.apache.aurora.admin.host_maintenance . SUCCESS Thanks, Joe Smith

Re: Review Request 21739: Add a test to catch regressions in scheduler_client connect_scheduler.

2014-05-21 Thread Joe Smith
this. Joe Smith wrote: I'm happy to, but kts has suggested I use this (more explicit) method instead. I kinda appreciate this more explicit call out as well, mind if I hang tight for his opinion? Kevin Sweeney wrote: I typically like to make time a parameter directly so

Re: Review Request 21848: Fix command typo

2014-05-23 Thread Joe Smith
--- On May 22, 2014, 11:14 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21848

Re: Review Request 21741: Adding grouping for the sla commands.

2014-05-27 Thread Joe Smith
) - Joe Smith On May 22, 2014, 6:12 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21741/ --- (Updated

Re: Review Request 20285: Improve documentation and testing for host maintenance API

2014-05-31 Thread Joe Smith
--- On May 20, 2014, 8:51 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20285

Re: Review Request 20285: Improve documentation and testing for host maintenance API

2014-05-31 Thread Joe Smith
== src.test.python.apache.aurora.admin.host_maintenance . SUCCESS Thanks, Joe Smith

Re: Review Request 20285: Improve documentation and testing for host maintenance API

2014-05-31 Thread Joe Smith
/test_host_maintenance.py ed0782b72eb12c45cefda2c3081f48b933dda206 src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab Diff: https://reviews.apache.org/r/20285/diff/ Testing (updated) --- ./pants ./src/test/python/apache/aurora:all Thanks, Joe

Re: Review Request 21943: Accept a job key for config loading.

2014-06-09 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21943/#review45119 --- Ship it! schweet - Joe Smith On May 29, 2014, 11:21 a.m

Re: Review Request 20285: Improve documentation and testing for host maintenance API

2014-06-10 Thread Joe Smith
/test_host_maintenance.py 176076f50c15f059c9b6876abbf56cacf5aa0f90 src/test/python/apache/aurora/client/commands/test_maintenance.py dd56b8d1feddb48a741e1a855833eb577cea67ab Diff: https://reviews.apache.org/r/20285/diff/ Testing --- ./pants ./src/test/python/apache/aurora:all Thanks, Joe Smith

Re: Review Request 22167: Adding SLA check into perform_maintenance_hosts command.

2014-06-11 Thread Joe Smith
/admin/admin_util.py https://reviews.apache.org/r/22167/#comment80260 parse_hostnames src/test/python/apache/aurora/admin/test_host_maintenance.py https://reviews.apache.org/r/22167/#comment80263 doh. thanks - Joe Smith On June 11, 2014, 10:04 a.m., Maxim Khutornenko wrote

Re: Review Request 22457: Improve aurora job diff command.

2014-06-13 Thread Joe Smith
/aurora/client/cli/json_tree_diff.py https://reviews.apache.org/r/22457/#comment80539 is this actually called somewhere? (and I promise I tried to understand what this is doing, but I can't ~_~) (what does 'rebase' mean?) - Joe Smith On June 11, 2014, 8 a.m., Mark Chu-Carroll

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-13 Thread Joe Smith
naive question- should there be a matching change somewhere else here? (at least in a test maybe?) - Joe Smith On June 11, 2014, 4:32 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 22483: Adding /locks endpoint to expose update locks.

2014-06-13 Thread Joe Smith
On June 13, 2014, 12:44 p.m., Joe Smith wrote: +1 to exposing this via thrift if possible- can we just start with getAllLocks and getLocksForRole? (seems you're concerned about us publishing an API before its thought through.. however if we're adding this now it seems like we're

Review Request 22611: Remove smart quotes from api.thrift

2014-06-15 Thread Joe Smith
://reviews.apache.org/r/22611/diff/ Testing --- Thanks, Joe Smith

Re: Review Request 22662: Migrate to pantsbuild pants

2014-06-16 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22662/#review45863 --- On June 16, 2014, 4:09 p.m., Joe Smith wrote

Re: Review Request 22662: Migrate to pantsbuild pants

2014-06-16 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22662/#review45863 --- On June 16, 2014, 4:09 p.m., Joe Smith wrote

Re: Review Request 22662: Migrate to pantsbuild pants

2014-06-16 Thread Joe Smith
: https://reviews.apache.org/r/22662/diff/ Testing --- On OS X 10.9: ./pants ./src/test/python:all Thanks, Joe Smith

Re: Review Request 22662: Migrate to pantsbuild pants

2014-06-17 Thread Joe Smith
src/main/python/apache/aurora/admin/BUILD 637f4e66c5fdcebea125626d1bf2883fbac9af41 src/main/thrift/org/apache/aurora/gen/BUILD dd401f2a5d85dbcfa340017cc5603ee0b24a3d2d Diff: https://reviews.apache.org/r/22662/diff/ Testing --- On OS X 10.9: ./pants ./src/test/python:all Thanks, Joe

Re: Review Request 22662: Migrate to pantsbuild pants

2014-06-17 Thread Joe Smith
637f4e66c5fdcebea125626d1bf2883fbac9af41 src/main/thrift/org/apache/aurora/gen/BUILD dd401f2a5d85dbcfa340017cc5603ee0b24a3d2d Diff: https://reviews.apache.org/r/22662/diff/ Testing --- On OS X 10.9: ./pants ./src/test/python:all Thanks, Joe Smith

Re: Review Request 22747: Add a python clean.sh script

2014-06-20 Thread Joe Smith
://reviews.apache.org/r/22747/diff/ Testing --- It works? Thanks, Joe Smith

Re: Review Request 22747: Add a python clean.sh script

2014-06-20 Thread Joe Smith
--- It works? Thanks, Joe Smith

Re: Review Request 22747: Add a python clean.sh script

2014-06-20 Thread Joe Smith
e-mail. To reply, visit: https://reviews.apache.org/r/22747/#review46208 --- On June 20, 2014, 11:05 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 22747: Add a python clean.sh script

2014-06-20 Thread Joe Smith
--- It works? Thanks, Joe Smith

Re: Review Request 22894: Resources should be an allowed dependency of python libraries within src/main/python.

2014-06-23 Thread Joe Smith
of the pants migration. - Joe Smith On June 23, 2014, 3:38 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22894

Re: Review Request 22896: Fix the end-to-end test

2014-06-23 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22896/#review46477 --- Ship it! Ship It! - Joe Smith On June 23, 2014, 4:49 p.m

Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.

2014-06-23 Thread Joe Smith
containing: 1) list of output strings 2) set of hostnames included in output - Joe Smith On June 20, 2014, 2:40 p.m., Maxim Khutornenko wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 22697: Documenting SLA stats.

2014-06-25 Thread Joe Smith
://reviews.apache.org/r/22697/#comment82214 This is a purely docs/sla.md https://reviews.apache.org/r/22697/#comment82215 that helps track - Joe Smith On June 25, 2014, 9:48 a.m., Maxim Khutornenko wrote: --- This is an automatically

Re: Review Request 22842: Changing maintenance command to drain SLA-compliant hosts in a group.

2014-06-26 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22842/#review46794 --- Ship it! Ship It! - Joe Smith On June 25, 2014, 11:48 a.m

Review Request 23180: Export a stat to track number of LOST gc_executors

2014-06-30 Thread Joe Smith
/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb Diff: https://reviews.apache.org/r/23180/diff/ Testing --- $ ./gradlew test Thanks, Joe Smith

Re: Review Request 23180: Export a stat to track number of LOST gc_executors

2014-06-30 Thread Joe Smith
a70f81795465595fb81430e3faa004f4eb12a0c2 src/test/java/org/apache/aurora/scheduler/async/GcExecutorLauncherTest.java c314a2ba36f36762fb7f3ac682bc5a22608edcbb Diff: https://reviews.apache.org/r/23180/diff/ Testing --- $ ./gradlew test Thanks, Joe Smith

Re: Review Request 23180: Export a stat to track number of LOST gc_executors

2014-06-30 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23180/#review47019 --- On June 30, 2014, 4:12 p.m., Joe Smith wrote

Re: Review Request 23180: Export a stat to track number of LOST gc_executors

2014-07-03 Thread Joe Smith
Thanks, Joe Smith

Re: Review Request 23528: Upgrade to public release of pants

2014-07-15 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23528/#review47840 --- Ship it! awesome - Joe Smith On July 15, 2014, 4:37 p.m., Brian

Re: Review Request 23455: Add a lightweight version of command hooks for clientv1 commands.

2014-07-17 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23455/#review48075 --- Ship it! Ship It! - Joe Smith On July 14, 2014, 10:50 a.m

Re: Review Request 24019: Blocking on post drain script call.

2014-07-31 Thread Joe Smith
/python/apache/aurora/admin/test_admin_util.py https://reviews.apache.org/r/24019/#comment86232 import subprocess src/test/python/apache/aurora/admin/test_admin_util.py https://reviews.apache.org/r/24019/#comment86231 ...subprocess, spec=subprocess) - Joe Smith On July 31, 2014, 1:16

Re: Review Request 24160: Add deprecation warnings for aurora client v1 command.

2014-08-04 Thread Joe Smith
these after the deprecation, but I suppose these files are going to get rm'd completely, so lgtm. - Joe Smith On July 31, 2014, 11:40 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 24160: Add deprecation warnings for aurora client v1 command.

2014-08-04 Thread Joe Smith
these after the deprecation, but I suppose these files are going to get rm'd completely, so lgtm. - Joe Smith On July 31, 2014, 11:40 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 24261: Add deprecation warnings to other clientv1 commands.

2014-08-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24261/#review49525 --- Ship it! Ship It! - Joe Smith On Aug. 4, 2014, 1:59 p.m., Mark

Re: Review Request 23348: Upgrading Mesos version from 0.18.0 to 0.19.0

2014-08-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23348/#review50079 --- Ship it! +1 to going to 0.19.0 first. - Joe Smith On Aug. 8

Re: Review Request 24651: Fix bug in deprecation warning for cancel-update.

2014-08-13 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24651/#review50475 --- Ship it! Ship It! - Joe Smith On Aug. 13, 2014, 8:28 a.m., Mark

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Joe Smith
/commands/maintenance.py https://reviews.apache.org/r/24871/#comment89472 ack on this- it'd be nice to still have a '1-command-for-all-the-things' but that's aight - Joe Smith On Aug. 21, 2014, 4:23 p.m., Maxim Khutornenko wrote

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Joe Smith
On Aug. 22, 2014, 11:39 a.m., Joe Smith wrote: src/main/python/apache/aurora/admin/host_maintenance.py, line 187 https://reviews.apache.org/r/24871/diff/2/?file=68#file68line187 If we're no longer wrapping a full maintenance process (which is fine) we shouldn't do

Re: Review Request 24871: Converting perform_maintenance_hosts into host_drain.

2014-08-22 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24871/#review51331 --- Ship it! Thank you!! - Joe Smith On Aug. 22, 2014, 2:26 p.m

Review Request 25208: Increment Mesos version to 0.20.0

2014-08-29 Thread Joe Smith
. SUCCESS src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-08-29 Thread Joe Smith
src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-08-30 Thread Joe Smith
src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

2014-09-02 Thread Joe Smith
On Aug. 28, 2014, 4:49 p.m., Maxim Khutornenko wrote: src/main/python/apache/thermos/core/runner.py, line 821 https://reviews.apache.org/r/25175/diff/1/?file=671859#file671859line821 *Regression test y/n ?* Definitely yes from me. +1 - Joe

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
://reviews.apache.org/r/25208/#review52049 --- On Sept. 2, 2014, 5:45 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
:45 p.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/ --- (Updated Sept. 2, 2014, 5:45 p.m.) Review

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
src.test.python.apache.aurora.executor.thermos_executor . SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Joe Smith
://reviews.apache.org/r/25206/#comment90865 aurora job run? - Joe Smith On Aug. 29, 2014, 4:17 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25206

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-02 Thread Joe Smith
On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote: src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 aurora job run? Kevin and Toby, can you two take a look at this ASAP? I'd like to have the e2e tests fixed

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-02 Thread Joe Smith
]] + echo 'Validated announced job.' Validated announced job. + return 0 ++ vagrant ssh -c 'aurora run devcluster/vagrant/test/http_example '\''pwd'\''' ++ wc -l Thanks, Joe Smith

Re: Review Request 25206: Fix aurora run in end to end tests.

2014-09-03 Thread Joe Smith
On Sept. 2, 2014, 6:47 p.m., Joe Smith wrote: src/test/sh/org/apache/aurora/e2e/test_run.sh, line 23 https://reviews.apache.org/r/25206/diff/1/?file=672554#file672554line23 aurora job run? Joe Smith wrote: Kevin and Toby, can you two take a look at this ASAP? I'd like

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-03 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25208/#review52198 --- On Sept. 2, 2014, 9:06 p.m., Joe Smith wrote

Re: Review Request 25208: Increment Mesos version to 0.20.0

2014-09-03 Thread Joe Smith
++ vagrant ssh -c 'aurora run devcluster/vagrant/test/http_example '\''pwd'\''' ++ wc -l Thanks, Joe Smith

Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
== src.test.python.apache.aurora.executor.common.health_checker . SUCCESS Tests in vagrant image Thanks, Joe Smith

Re: Review Request 25346: Specify required vagrant version in Vagrantfile.

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25346/#review52334 --- Ship it! thanks! - Joe Smith On Sept. 4, 2014, 11:48 a.m., Bill

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
. SUCCESS src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
src.test.python.apache.aurora.executor.thermos_task_runner . SUCCESS Thanks, Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52387 --- On Sept. 4, 2014, 5:43 p.m., Joe Smith wrote

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
. SUCCESS Thanks, Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52389 --- On Sept. 4, 2014, 6:20 p.m., Joe Smith wrote

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
. SUCCESS Thanks, Joe Smith

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-04 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25337/#review52395 --- On Sept. 4, 2014, 8 p.m., Joe Smith wrote: --- This is an automatically

Re: Review Request 25337: Preserve executor HealthCheckerThread name

2014-09-05 Thread Joe Smith
. SUCCESS Thanks, Joe Smith

Re: Review Request 25466: Upgrade Aurora to psutil 2.1.1

2014-09-08 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25466/#review52674 --- Ship it! awesome - Joe Smith On Sept. 8, 2014, 7:13 p.m., Brian

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52945 --- can you also add e2e test coverage? - Joe Smith On Sept. 10

Re: Review Request 25519: Adding get_scheduler admin command.

2014-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25519/#review52968 --- Ship it! Ship It! - Joe Smith On Sept. 10, 2014, 3:43 p.m

Re: Review Request 25582: Fix error in client task ssh command when the job isn't found.

2014-09-12 Thread Joe Smith
://reviews.apache.org/r/25582/#comment92646 test_ssh_job_not_found src/test/python/apache/aurora/client/cli/test_task_run.py https://reviews.apache.org/r/25582/#comment92647 Test the ssh command for proper behavior when no tasks are found within a job or something, I think - Joe Smith

Re: Review Request 25582: Fix error in client task ssh command when the job isn't found.

2014-09-12 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25582/#review53189 --- Ship it! Ship It! - Joe Smith On Sept. 12, 2014, 10:17 a.m

Re: Review Request 25582: Fix error in client task ssh command when the job isn't found.

2014-09-12 Thread Joe Smith
On Sept. 12, 2014, 10:09 a.m., Joe Smith wrote: src/test/python/apache/aurora/client/cli/test_task_run.py, line 228 https://reviews.apache.org/r/25582/diff/1/?file=687672#file687672line228 Test the ssh command for proper behavior when no tasks are found within a job or something

Re: Review Request 25543: Update to pants 0.0.23.

2014-09-12 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25543/#review53242 --- Ship it! awesome- thanks! - Joe Smith On Sept. 11, 2014, 9:13

Re: Review Request 25175: Fix possible deadlock in TaskRunner.collect_updates.

2014-09-15 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25175/#review53367 --- Ship it! Ship It! - Joe Smith On Sept. 15, 2014, 11:08 a.m

Re: Review Request 25667: Removing host_drain delay.

2014-09-15 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25667/#review53419 --- Ship it! Ship It! - Joe Smith On Sept. 15, 2014, 3:04 p.m

Re: Review Request 26015: Skip past irrelevant jobs when running cron show command.

2014-09-24 Thread Joe Smith
/client/cli/cron.py https://reviews.apache.org/r/26015/#comment94681 Mainly confirming for myself- but this follows the expected behavior- if a job is the right name, but not a cron: INVALID_PARAMETER. If there are no jobs matching the name: INVALID_PARAMETER. - Joe Smith On Sept. 24

  1   2   >