Re: Review Request 16306: job status command, with wildcard support.

2014-01-13 Thread Jonathan Boulle
, visit: https://reviews.apache.org/r/16306/ --- (Updated Jan. 9, 2014, 10:29 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Repository: aurora Description --- Added an implementation of the status

Re: Review Request 16423: client v2: added implementations of job diff, job inspect.

2014-01-13 Thread Jonathan Boulle
/#comment60343 nit: could we use a more generic username for all the tests? - Jonathan Boulle On Jan. 13, 2014, 3:02 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Review Request 16941: add support for multiple GPG keys and fix rollback instructions

2014-01-15 Thread Jonathan Boulle
--- add support for multiple GPG keys and fix rollback instructions Diffs - build-support/tag-release 6940d5d5dadb8c68cf5268fbb5c790114de58c0a Diff: https://reviews.apache.org/r/16941/diff/ Testing --- Thanks, Jonathan Boulle

Re: Review Request 16983: Fix maintenance command documentation and host/filename logic.

2014-01-17 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16983/#review32179 --- Ship it! Ship It! - Jonathan Boulle On Jan. 16, 2014, 9:17 p.m

Re: Review Request 17063: Update tag-release to allow patch level increments.

2014-01-17 Thread Jonathan Boulle
On Jan. 17, 2014, 7:27 p.m., Brian Wickman wrote: build-support/release/tag-release, line 70 https://reviews.apache.org/r/17063/diff/1/?file=427256#file427256line70 hmm - should this include patch too? yes - Jonathan ---

Re: Review Request 17068: Added docs about git setup.

2014-01-17 Thread Jonathan Boulle
/#comment60963 s/setup/set up/ s/configured/configure/ docs/contributing.md https://reviews.apache.org/r/17068/#comment60965 s/jira/JIRA/ s/reviewboard/ReviewBoard docs/contributing.md https://reviews.apache.org/r/17068/#comment60964 s/emails your/emails from your/ - Jonathan

Re: Review Request 17051: Add clientv2 implementations of update and list jobs.

2014-01-21 Thread Jonathan Boulle
://reviews.apache.org/r/17051/#comment61257 line 58 of context.py still raises CommandError ?? - Jonathan Boulle On Jan. 17, 2014, 8:05 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 17153: Implement restart command for client v2.

2014-01-21 Thread Jonathan Boulle
/#comment61315 hm. missing merge? src/main/python/apache/aurora/client/cli/options.py https://reviews.apache.org/r/17153/#comment61316 s/operate/operated/ - Jonathan Boulle On Jan. 21, 2014, 10:03 p.m., Mark Chu-Carroll wrote

Re: Review Request 17351: Use only a single write transaction to save HostAttributes in resourceOffers.

2014-01-24 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17351/#review32778 --- Ship it! Ship It! - Jonathan Boulle On Jan. 25, 2014, 6:03 a.m

Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-25 Thread Jonathan Boulle
/#comment61574 s/in/it src/test/python/apache/aurora/client/cli/test_update.py https://reviews.apache.org/r/17185/#comment61576 configs = [TaskConfig(...) for ...] - Jonathan Boulle On Jan. 22, 2014, 3:02 p.m., Mark Chu-Carroll wrote

Re: Review Request 17359: Avoid using protobuf equals().

2014-01-25 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17359/#review32787 --- Ship it! Ship It! - Jonathan Boulle On Jan. 26, 2014, 12:35 a.m

Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-27 Thread Jonathan Boulle
something like https://cgit.twitter.biz/science/tree/src/python/twitter/aurora/client/api_internal/deployment_cli.py#n214 maybe print_out could support an indent= kwarg? - Jonathan Boulle On Jan. 27, 2014, 2:56 p.m., Mark Chu-Carroll wrote

Re: Review Request 17185: Merged all of the open clientv2 reviews into one unified change.

2014-01-27 Thread Jonathan Boulle
://reviews.apache.org/r/17185/#comment61850 should have clarified: this line = 12 spaces indentation, line 358 = 13 spaces indentation. so maybe you can change the latter instead :-) - Jonathan Boulle On Jan. 27, 2014, 6:21 p.m., Mark Chu-Carroll wrote

Re: Review Request 17412: Quiet noisy status checker debug messages

2014-01-27 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17412/#review32862 --- Ship it! Ship It! - Jonathan Boulle On Jan. 27, 2014, 7:31 p.m

Re: Review Request 17293: s/thermos_observe/thermos_observer/ in README.md

2014-01-27 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17293/#review32883 --- Ship it! Ship It! - Jonathan Boulle On Jan. 24, 2014, 1:28 a.m

Re: Review Request 17270: Bridge framework for client v2.

2014-01-28 Thread Jonathan Boulle
s/ // - Jonathan Boulle On Jan. 28, 2014, 3:23 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-01-29 Thread Jonathan Boulle
? - Jonathan Boulle On Jan. 28, 2014, 4:24 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-01-31 Thread Jonathan Boulle
://reviews.apache.org/r/17581/#comment62799 whoah - these indents appear to be 4sp, should be 2sp - Jonathan Boulle On Jan. 31, 2014, 7:34 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-02-03 Thread Jonathan Boulle
://reviews.apache.org/r/17581/#comment62894 hmm, log.error is nonfatal, so you should probably die() in these two cases - Jonathan Boulle On Jan. 31, 2014, 7:52 p.m., Dan Norris wrote: --- This is an automatically generated e-mail

Re: Review Request 17581: AURORA-108: make set_quota in aurora_admin require explicit units

2014-02-03 Thread Jonathan Boulle
On Feb. 3, 2014, 6:50 p.m., Jonathan Boulle wrote: src/main/python/apache/aurora/client/commands/admin.py, lines 174-181 https://reviews.apache.org/r/17581/diff/3/?file=462163#file462163line174 hmm, log.error is nonfatal, so you should probably die() in these two cases sorry I

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Jonathan Boulle
://reviews.apache.org/r/17332/#comment63422 is this supposed to have been removed? src/test/python/apache/aurora/client/cli/test_quota.py https://reviews.apache.org/r/17332/#comment63423 duped with test_get_quota.py? - Jonathan Boulle On Feb. 5, 2014, 3:08 p.m., Mark Chu-Carroll wrote

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Jonathan Boulle
On Feb. 6, 2014, 6:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/role.py, line 44 https://reviews.apache.org/r/17332/diff/1/?file=450590#file450590line44 Yes, this entire file was meant to be removed. I git mv'ed it to create quota.py and it's not in

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Jonathan Boulle
://reviews.apache.org/r/17332/#comment63436 nit: s/print/render/ src/main/python/apache/aurora/client/cli/quota.py https://reviews.apache.org/r/17332/#comment63435 could this be bounded a little more narrowly? what about other bad response codes? - Jonathan Boulle On Feb. 5, 2014, 3

Re: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails

2014-02-06 Thread Jonathan Boulle
On Feb. 5, 2014, 2:18 a.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/api/command_runner.py, line 139 https://reviews.apache.org/r/17724/diff/1/?file=469319#file469319line139 It's API level, because this is the highest level shared by all of the distinct code

Re: Review Request 17270: Bridge framework for client v2.

2014-02-06 Thread Jonathan Boulle
, since presumably any implementation of register_nouns will need to call register_noun - Jonathan Boulle On Jan. 30, 2014, 9:03 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 17270: Bridge framework for client v2.

2014-02-06 Thread Jonathan Boulle
On Feb. 6, 2014, 10:36 p.m., Mark Chu-Carroll wrote: src/main/python/apache/aurora/client/cli/__init__.py, line 149 https://reviews.apache.org/r/17270/diff/3/?file=456886#file456886line149 That's actually the way that I originally wrote it, and wickman wanted me to change it to

Re: Review Request 17270: Bridge framework for client v2.

2014-02-07 Thread Jonathan Boulle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17270/#review33946 --- Ship it! Ship It! - Jonathan Boulle On Feb. 7, 2014, 3:31 p.m

Re: Review Request 17752: Add task noun, supporting run and ssh verbs.

2014-02-11 Thread Jonathan Boulle
://reviews.apache.org/r/17752/#comment64264 bad merge? this still references context instead of instance_str - Jonathan Boulle On Feb. 7, 2014, 8:44 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply

Review Request 18163: Remove appapp references from schema

2014-02-14 Thread Jonathan Boulle
/ Testing --- Thanks, Jonathan Boulle

Review Request 18248: fix python tests on master

2014-02-18 Thread Jonathan Boulle
Description --- derr https://builds.apache.org/job/Aurora/116/changes Diffs - src/main/python/apache/aurora/config/thrift.py e293c92c7a2a6fa4eb165d10b8b1ac08be8e22c1 Diff: https://reviews.apache.org/r/18248/diff/ Testing --- Thanks, Jonathan Boulle