Re: Review Request 16615: Client command hooks doc

2014-01-13 Thread Kevin Sweeney
. - Kevin Sweeney On Jan. 3, 2014, 11:19 a.m., Tom Galloway wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16615/ --- (Updated

Re: Review Request 16834: Dropping scheduler_list_job_updates from aurora_admin

2014-01-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16834/#review31675 --- Ship it! Ship It! - Kevin Sweeney On Jan. 13, 2014, 3:34 p.m

Re: Review Request 16170: Revert Thrift upgrade.

2014-01-14 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16170/#review31756 --- Discarding this. - Kevin Sweeney On Dec. 10, 2013, 5:32 p.m

Re: Review Request 16265: Script for creating tags

2014-01-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16265/#review30382 --- On Jan. 15, 2014, 2:57 p.m., Kevin Sweeney wrote

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

2014-01-16 Thread Kevin Sweeney
(tested on Python 2.4 and Python 3.3): checksum=$(python -c import hashlib; m=hashlib.md5(); m.update(open('$file', 'rb').read()); print(m.hexdigest())) - Kevin Sweeney On Jan. 16, 2014, 12:34 p.m., Bill Farner wrote

Re: Review Request 16985: Script to create Python sdists.

2014-01-16 Thread Kevin Sweeney
-SNAPSHOT Wrote /Users/ksweeney/workspace/aurora/dist/apache.gen.thermos-0.5.0-SNAPSHOT.tar.gz Thanks, Kevin Sweeney

Re: Review Request 16615: Client command hooks doc

2014-01-16 Thread Kevin Sweeney
/asf?p=incubator-aurora.git;a=commit;h=915977e4978a527c0133cb6f1fba350d11ce464c Please mark this review as submitted at your earliest convenience. Thanks so much for your work on this Tom! - Kevin Sweeney On Jan. 14, 2014, 12:23 p.m., Tom Galloway wrote

Re: Review Request 16601: Adding initial image in images directory

2014-01-16 Thread Kevin Sweeney
-us.apache.org/repos/asf?p=incubator-aurora.git;a=commit;h=915977e4978a527c0133cb6f1fba350d11ce464c Please mark this review as submitted at your earliest convenience. - Kevin Sweeney On Jan. 3, 2014, 1:14 a.m., Tom Galloway wrote

Re: Review Request 17042: Add a web interface to the zookeeper instance.

2014-01-21 Thread Kevin Sweeney
to pushd ~vagrant sudo -H -u vagrant git clone https://github.com/phunt/zookeeper_dashboard popd - Kevin Sweeney On Jan. 17, 2014, 11:21 a.m., Tobias Weingartner wrote: --- This is an automatically generated e-mail

Re: Review Request 17332: Add a noun supporting operations on roles

2014-01-24 Thread Kevin Sweeney
/prod/appserver - Kevin Sweeney On Jan. 24, 2014, 2:07 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Kevin Sweeney
/MemTaskStore.java https://reviews.apache.org/r/17372/#comment61900 Does it make sense to special-case the primary-key index here? Seems that the taskId index could implement SecondaryIndex (or just rename SecondaryIndex to Index). - Kevin Sweeney On Jan. 26, 2014, 1:52 p.m., Bill Farner wrote

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32900 --- Ship it! Ship It! - Kevin Sweeney On Jan. 26, 2014, 1:52 p.m

Re: Review Request 17412: Quiet noisy status checker debug messages

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17412/#review32901 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 1:25 p.m

Re: Review Request 17432: Fix regression causing secondary index to store duplicate tasks.

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17432/#review32916 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 3:58 p.m

Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/#review32923 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 4:19 p.m

Review Request 17464: Upgrade RBTools to 0.5.5.

2014-01-28 Thread Kevin Sweeney
a05476d175bf3959cc6e5d96aab55215fac9e36b Diff: https://reviews.apache.org/r/17464/diff/ Testing --- Posted this review, verified upgrade works. Thanks, Kevin Sweeney

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Kevin Sweeney
/StateManagerImpl.java https://reviews.apache.org/r/16873/#comment61431 This seems like a big enough gotcha to warrant filing a ticket. - Kevin Sweeney On Jan. 14, 2014, 3:27 p.m., Bill Farner wrote: --- This is an automatically generated e

Re: Review Request 17063: Update tag-release to allow patch level increments.

2014-01-28 Thread Kevin Sweeney
/17063/#comment62305 A dev tag should update .auroraversion so that generated artifacts have the tag in them. Without this the tag will point to a -snapshot. - Kevin Sweeney On Jan. 28, 2014, 3:11 p.m., Brian Wickman wrote

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review33076 --- Ship it! Ship It! - Kevin Sweeney On Jan. 28, 2014, 2:17 p.m

Re: Review Request 17063: Update tag-release to allow patch level increments.

2014-01-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17063/#review33077 --- Ship it! Ship It! - Kevin Sweeney On Jan. 28, 2014, 3:32 p.m

Review Request 17475: Upgrade mesos to 0.15.0

2014-01-28 Thread Kevin Sweeney
5170b4076fc6e4424914493208c779f4494ed097 src/main/python/apache/aurora/executor/BUILD 2524b2ee295011cca51fff672adf65cdc8e9137b Diff: https://reviews.apache.org/r/17475/diff/ Testing --- vagrant up ./build-support/jenkins/build.sh Thanks, Kevin Sweeney

Re: Review Request 17507: Fix indentation in tutorial

2014-01-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17507/#review33240 --- Pushing this trivial change to master TBR. - Kevin Sweeney

Re: Review Request 17559: requirement should be mesos==0.15.0-rc4

2014-01-30 Thread Kevin Sweeney
not to go forward with that one? - Kevin Sweeney On Jan. 30, 2014, 1:03 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17559

Re: Review Request 17562: Added cluster name to page title.

2014-01-30 Thread Kevin Sweeney
getClusterInfo - Kevin Sweeney On Jan. 30, 2014, 2:27 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562

Re: Review Request 17578: When trying to schedule a task, only query once for active tasks in the job.

2014-01-30 Thread Kevin Sweeney
about making this query lazy so that it happens the first time the info is needed rather than eagerly when it might not be needed? - Kevin Sweeney On Jan. 30, 2014, 6:17 p.m., Bill Farner wrote: --- This is an automatically generated e

Re: Review Request 17332: Add a noun supporting operations on roles

2014-01-31 Thread Kevin Sweeney
On Jan. 24, 2014, 2:35 p.m., Kevin Sweeney wrote: Why is this happening on a role noun and not a quota noun. i.e. aurora quota get west/ksweeney v.s. aurora role get_quota west/ksweeney The second looks inconsistent with the noun-verb model to me and if we ever

Re: Review Request 17666: Adding DRAINING state into api.thrift.

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/#review33462 --- Ship it! Ship It! - Kevin Sweeney On Feb. 3, 2014, 10:16 a.m

Re: Review Request 17060: Fix noisy status checker debug log.

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17060/#review33463 --- Ship it! Ship It! - Kevin Sweeney On Jan. 17, 2014, 11:06 a.m

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Kevin Sweeney
expansion with \$? - Kevin Sweeney On Feb. 3, 2014, 8:30 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457

Re: Review Request 17056: fix dependencies for setup_py

2014-02-03 Thread Kevin Sweeney
://reviews.apache.org/r/17056/#comment62959 I'm unclear on the convention being followed for -packaged dependencies. Wouldn't this be automatic if src/main/python/apache/aurora/config has a provides statement? - Kevin Sweeney On Jan. 17, 2014, 10:37 a.m., Brian Wickman wrote

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Kevin Sweeney
On Feb. 3, 2014, 1:47 p.m., Kevin Sweeney wrote: examples/vagrant/provision-dev-environment.sh, line 5 https://reviews.apache.org/r/17457/diff/4/?file=463503#file463503line5 git is already on this commandline and setuptools shouldn't be needed. From the virtualbox environment

Review Request 17679: Upgrade twitter.common.python to 0.3.0

2014-02-03 Thread Kevin Sweeney
229e201b8fa7b069eee4291695ce341318ef976e rbt 8828ead987ba84ef8d7435b30b7ff99a1d5e20a1 Diff: https://reviews.apache.org/r/17679/diff/ Testing --- Ran ./pants, ./rbt, ./build-support/pex, ./build-support/release/make-python-sdists from clean and dirty repos. ./pants src/test/python:all Thanks, Kevin Sweeney

Re: Review Request 17562: Added cluster name to page title.

2014-02-03 Thread Kevin Sweeney
On Jan. 30, 2014, 4:56 p.m., Kevin Sweeney wrote: Suman Karumuri wrote: Spoke to Bill before making these changes. We decided to use getInfo API and deprecate getAPIVersion. The getInfo will return with the clusterName and APIVersion for now. In future it may include other

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33530 --- Ship it! Ship It! - Kevin Sweeney On Feb. 3, 2014, 3:43 p.m

Re: Review Request 17715: Added THROTTLED state to scheduler UI.

2014-02-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17715/#review33626 --- Ship it! Ship It! - Kevin Sweeney On Feb. 4, 2014, 11 a.m

Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17729/#review33742 --- Ship it! Ship It! - Kevin Sweeney On Feb. 4, 2014, 5:59 p.m

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Kevin Sweeney
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 7:08 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https

Re: Review Request 17056: fix dependencies for setup_py

2014-02-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review33840 --- Did this ever land? - Kevin Sweeney On Jan. 17, 2014, 10:37 a.m

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-02-06 Thread Kevin Sweeney
://reviews.apache.org/r/17750/ Merging AbstractCronIT and QuartzCronIT is on the list of followup TODOs for that review, so this will be mitigated then. - Kevin Sweeney On Feb. 6, 2014, 12:57 p.m., Jake Farrell wrote

Re: Review Request 17723: Implementing support for DRAINING state.

2014-02-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17723/#review33847 --- Ship it! Ship It! - Kevin Sweeney On Feb. 4, 2014, 1:31 p.m

Re: Review Request 17750: CronScheduler implementation based on Quartz.

2014-02-10 Thread Kevin Sweeney
., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17750/ --- (Updated Feb. 5, 2014, 3:23 p.m.) Review

Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.

2014-02-11 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/#review34215 --- Ship it! Ship It! - Kevin Sweeney On Feb. 11, 2014, 10:58 a.m

Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-12 Thread Kevin Sweeney
/UIRedirectFilter.java https://reviews.apache.org/r/18036/#comment64393 Is this not logged by the library? - Kevin Sweeney On Feb. 12, 2014, 3:26 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18229/#review34736 --- Can you verify this fixes the e2e test? - Kevin Sweeney On Feb

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18229/#review34772 --- Ship it! Ship It! - Kevin Sweeney On Feb. 18, 2014, 10:52 a.m

Review Request 18245: Use user.signingkey for tag-signing.

2014-02-18 Thread Kevin Sweeney
://reviews.apache.org/r/18245/diff/ Testing --- Tested with user.signingkey set and unset on local merged master. Thanks, Kevin Sweeney

Review Request 18247: Add kevints CODE SIGNING KEY to KEYS.

2014-02-18 Thread Kevin Sweeney
Description --- Add kevints CODE SIGNING KEY to KEYS. Diffs - KEYS 55eec288042426313f67b070b1cc489283ef2bbf Diff: https://reviews.apache.org/r/18247/diff/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 18306: Merge remote-tracking branch 'brianm/patch-2' into HEAD

2014-02-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18306/#review35025 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 2:01 a.m

Re: Review Request 18306: Merge remote-tracking branch 'brianm/patch-2' into HEAD

2014-02-20 Thread Kevin Sweeney
/repos/asf?p=incubator-aurora.git;a=commit;h=56a8cc37940d0bb75d5f54f75cc71757b5c4aa60 - Kevin Sweeney On Feb. 20, 2014, 2:01 a.m., Brian McCallister wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 18297: Clean up idea module configuration, make sure generated sources are available.

2014-02-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/#review35038 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 10:41 a.m

Re: Review Request 16710: Support multiple simulataneous auth mechanisms.

2014-02-24 Thread Kevin Sweeney
://reviews.apache.org/r/16710/#review31445 --- On Jan. 7, 2014, 4:45 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 18481: Upgrade pex to twitter.common.python==0.3.1

2014-02-25 Thread Kevin Sweeney
--- SSIA Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf Diff: https://reviews.apache.org/r/18481/diff/ Testing --- Tested upgrade on clean and dirty master. Thanks, Kevin Sweeney

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

2014-02-25 Thread Kevin Sweeney
request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs - build-support/pex

Re: Review Request 18241: Reworked LogStorage to avoid unnecessary extra calls to write().

2014-02-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18241/#review35453 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 5:16 p.m

Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.

2014-02-25 Thread Kevin Sweeney
/storage/ReadWriteLockManager.java https://reviews.apache.org/r/18240/#comment65978 reads better statically imported (here and elsewhere). - Kevin Sweeney On Feb. 18, 2014, 1:55 p.m., Bill Farner wrote: --- This is an automatically

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

2014-02-25 Thread Kevin Sweeney
=incubator-aurora.git;a=commitdiff;h=6e7acbfb7a8b4cb9694fbc510fc67e07c1b34454 - Kevin Sweeney On Feb. 24, 2014, 6:45 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345

Review Request 18490: Generate cron predictions using -Duser.timezone=GMT.

2014-02-25 Thread Kevin Sweeney
0f71f70b5aec7646375f775fde6e1eceae038a9e Diff: https://reviews.apache.org/r/18490/diff/ Testing --- Manual testing against internal implementation - test against quartz coming in a later review. Thanks, Kevin Sweeney

Re: Review Request 18523: Remove rogue apostrophes.

2014-02-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18523/#review35537 --- Ship it! Ship It! - Kevin Sweeney On Feb. 26, 2014, 9:43 a.m

Re: Review Request 18528: Make markdown TOC and anchors more plaintext-friendly.

2014-02-26 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18528/#review35552 --- Ship it! Ship It! - Kevin Sweeney On Feb. 26, 2014, 11:07 a.m

Re: Review Request 18546: Renamed Quota to ResourceAggregate.

2014-02-27 Thread Kevin Sweeney
/ --- (Updated Feb. 26, 2014, 6:44 p.m.) Review request for Aurora, Kevin Sweeney, Mark Chu-Carroll, Maxim Khutornenko, and Bill Farner. Bugs: AURORA-105 https://issues.apache.org/jira/browse/AURORA-105 Repository: aurora Description --- Updated client

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-02-27 Thread Kevin Sweeney
Rather than give up if /usr/bin/python isn't =2.6,3, shouldn't it instead check for python2.7 and python2.6 on PATH (similar to https://github.com/apache/incubator-aurora/blob/master/build-support/virtualenv#L6-L13 ). - Kevin Sweeney On Feb. 26, 2014, 2:06 p.m., Dan Norris

Re: Review Request 18598: Updated test to use environment variable if it exits.

2014-02-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18598/#review35731 --- Ship it! Ship It! - Kevin Sweeney On Feb. 27, 2014, 4:44 p.m

Re: Review Request 18537: AURORA-227: Aurora build should check for the Python version

2014-02-27 Thread Kevin Sweeney
On Feb. 27, 2014, 3:04 p.m., Kevin Sweeney wrote: build.gradle, lines 251-260 https://reviews.apache.org/r/18537/diff/1/?file=504979#file504979line251 Rather than give up if /usr/bin/python isn't =2.6,3, shouldn't it instead check for python2.7 and python2.6 on PATH (similar

Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Kevin Sweeney
: https://reviews.apache.org/r/18602/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Kevin Sweeney

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Kevin Sweeney
/apache/aurora/common/http_signaler.py b19b72d6400cef1a2e469b1853a7d49c063d5a25 Diff: https://reviews.apache.org/r/18602/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Kevin Sweeney

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Kevin Sweeney
--- On Feb. 27, 2014, 5:59 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602

Re: Review Request 18580: Upgrade mesos to 0.17.0

2014-02-27 Thread Kevin Sweeney
wait for another shipit. - Kevin Sweeney On Feb. 27, 2014, 6:31 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-27 Thread Kevin Sweeney
/python/apache/aurora/common/http_signaler.py b19b72d6400cef1a2e469b1853a7d49c063d5a25 Diff: https://reviews.apache.org/r/18602/diff/ Testing --- ./build-support/jenkins/build.sh Thanks, Kevin Sweeney

Re: Review Request 18580: Upgrade mesos to 0.17.0

2014-02-28 Thread Kevin Sweeney
/#review35819 --- On Feb. 27, 2014, 6:31 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580

Re: Review Request 18602: Make http signaler timeout secs configurable via environment variable.

2014-02-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18602/#review35810 --- On Feb. 27, 2014, 6:37 p.m., Kevin Sweeney wrote: --- This is an automatically generated e

Re: Review Request 18580: Upgrade mesos to 0.17.0

2014-02-28 Thread Kevin Sweeney
--- On Feb. 27, 2014, 6:31 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18580/ --- (Updated

Re: Review Request 18580: Upgrade mesos to 0.17.0

2014-02-28 Thread Kevin Sweeney
src/test/java/org/apache/aurora/scheduler/MesosSchedulerImplTest.java 7a91ab8d9437ba465018fb9dc221d68174178534 Diff: https://reviews.apache.org/r/18580/diff/ Testing --- ./build-support/jenkins/build.sh ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh Thanks, Kevin Sweeney

Review Request 18658: GZIP HTTP thrift API responses

2014-02-28 Thread Kevin Sweeney
Diff: https://reviews.apache.org/r/18658/diff/ Testing --- Verified API responses are gzipped. Thanks, Kevin Sweeney

Re: Review Request 17347: Added non-prod consumption info to getQuota call.

2014-02-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17347/#review35890 --- Ship it! Ship It! - Kevin Sweeney On Feb. 28, 2014, 3:32 p.m

Re: Review Request 18658: GZIP HTTP thrift API responses

2014-03-03 Thread Kevin Sweeney
--- On Feb. 28, 2014, 5:27 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18658

Re: Review Request 18704: Remove LogStream.close, which was a no-op everywhere.

2014-03-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18704/#review36010 --- Ship it! Ship It! - Kevin Sweeney On March 3, 2014, 11:05 a.m

Re: Review Request 18713: Initiate a teardown of scheduler lifecycle upon application exit.

2014-03-06 Thread Kevin Sweeney
On March 3, 2014, 6:16 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java, line 236 https://reviews.apache.org/r/18713/diff/1/?file=509104#file509104line236 Not sure how shutdownRegistry.addAction() fits into this specific Closure. It

Re: Review Request 18655: Added JobKey set into TaskQuery.

2014-03-07 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18655/#review36547 --- Ship it! Ship It! - Kevin Sweeney On March 3, 2014, 5:03 p.m

Re: Review Request 18926: Aurora-102: Add failOnVersionConfict() to scheduler build

2014-03-10 Thread Kevin Sweeney
should this be prefix, rev? Also perhaps add a comment explaining why we're stuck on certain versions? - Kevin Sweeney On March 10, 2014, 9:22 a.m., Jake Farrell wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 19061: Disable kill of production jobs without force flag

2014-03-11 Thread Kevin Sweeney
and everywhere else - Kevin Sweeney On March 11, 2014, 12:42 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061

Re: Review Request 19061: Disable kill of production jobs without force flag

2014-03-11 Thread Kevin Sweeney
://reviews.apache.org/r/19061/#comment68024 Actually not even this is sufficient. Due to a quirk in the query API, the responseCode is set to INVALID_REQUEST when the result set is empty (which will cause a die here). - Kevin Sweeney On March 11, 2014, 1:03 p.m., Mark Chu-Carroll wrote

Re: Review Request 19061: Disable kill of production jobs without force flag

2014-03-11 Thread Kevin Sweeney
--force I don't think we should prompt. - Kevin Sweeney On March 11, 2014, 3:23 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19061

Re: Review Request 19143: Catch errors thrown by authentication modules.

2014-03-12 Thread Kevin Sweeney
://reviews.apache.org/r/19143/#comment68245 I'm pretty wary of swallowing exceptions like this - seems like an easy way to paper over bugs / hide truly exceptional events. I'd at least log the traceback at debug level here so that it's available in debug output. - Kevin Sweeney On March

Re: Review Request 19159: Add killall.

2014-03-13 Thread Kevin Sweeney
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19159/ --- (Updated March 12, 2014, 3:11 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: aurora-260 https://issues.apache.org/jira

Re: Review Request 19159: Add killall.

2014-03-13 Thread Kevin Sweeney
. Kevin Sweeney wrote: If someone is going to search-and-replace kill with killall without wanting to do that I'm not sure we can stop them from shooting themselves in the foot. Up to you but I'm in favor of dropping this required option. I run unqualified kill (which will now

Re: Review Request 19159: Add killall.

2014-03-13 Thread Kevin Sweeney
https://reviews.apache.org/r/19159/#comment68515 Not needed since we're no longer disambiguating the old --cluster=a ROLE NAME form. - Kevin Sweeney On March 13, 2014, 5:14 p.m., Mark Chu-Carroll wrote: --- This is an automatically

Re: Review Request 18487: Refactor LogStorage to more cleanly separate replay and write-behind modes, and require explicit implementation of mutate operations.

2014-03-14 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18487/#review37275 --- Ship it! Ship It! - Kevin Sweeney On March 3, 2014, 10:29 a.m

Re: Review Request 19250: Properly handle filtering offers when multiple attributes have the same name.

2014-03-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19250/#review37427 --- - Kevin Sweeney On March 17, 2014, 11:55 a.m., Bill Farner wrote

Re: Review Request 19323: Added jobStats on old role page. Disabled job status badge.

2014-03-17 Thread Kevin Sweeney
revert? - Kevin Sweeney On March 17, 2014, 4:57 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19323

Re: Review Request 19426: Don't forget to register status checker observables.

2014-03-19 Thread Kevin Sweeney
/status_checker.py https://reviews.apache.org/r/19426/#comment69573 Any reason not to make this an abstractproperty? Just backwards compatibility? - Kevin Sweeney On March 19, 2014, 3:55 p.m., Brian Wickman wrote

Re: Review Request 19450: Added nextCronRunMs field to JobSummary.

2014-03-20 Thread Kevin Sweeney
production classes across packages in unit tests src/test/java/org/apache/aurora/scheduler/thrift/ThriftIT.java https://reviews.apache.org/r/19450/#comment69746 +1 to mock - Kevin Sweeney On March 19, 2014, 11:22 p.m., Suman Karumuri wrote

Re: Review Request 19494: Change missing shipits tool to serve as a dashboard for all outstanding reviews.

2014-03-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19494/#review38026 --- Ship it! Ship It! - Kevin Sweeney On March 20, 2014, 3:07 p.m

Re: Review Request 19509: Now consuming nonProd consumption from the new getQuota API

2014-03-21 Thread Kevin Sweeney
and expressively detect this breakage. - Kevin Sweeney On March 20, 2014, 7:39 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19509

Re: Review Request 19396: Implement client command logging with a unique token.

2014-03-21 Thread Kevin Sweeney
://reviews.apache.org/r/19396/#comment70196 Should this be prefixed with self? As a side note this seems excessively verbose to me (36 characters of your 100 character line), perhaps just have self.log? - Kevin Sweeney On March 21, 2014, 12:06 p.m., Mark Chu-Carroll wrote

Re: Review Request 17042: Add a web interface to the zookeeper instance.

2014-03-24 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17042/#review38366 --- Ship it! Ship It! - Kevin Sweeney On Feb. 9, 2014, 10:40 p.m

Re: Review Request 18658: GZIP HTTP thrift API responses

2014-03-25 Thread Kevin Sweeney
/resources/org/apache/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d Diff: https://reviews.apache.org/r/18658/diff/ Testing --- Verified API responses are gzipped. Thanks, Kevin Sweeney

Re: Review Request 16710: Support multiple simulataneous auth mechanisms.

2014-03-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16710/#review38467 --- Discarding this review for now. - Kevin Sweeney On Jan. 7, 2014

Re: Review Request 18658: GZIP HTTP thrift API responses

2014-03-25 Thread Kevin Sweeney
456634c76b9993119af2d841073c31a4a1c82ab7 Diff: https://reviews.apache.org/r/18658/diff/ Testing --- Verified API responses are gzipped. Thanks, Kevin Sweeney

Re: Review Request 18658: GZIP HTTP thrift API responses

2014-03-25 Thread Kevin Sweeney
/aurora/scheduler/http/ui/js/services.js 81cd12c4fea473192cd7e6b6dba245e4dde30b3d Diff: https://reviews.apache.org/r/18658/diff/ Testing --- Verified API responses are gzipped. Thanks, Kevin Sweeney

Re: Review Request 19396: Implement client command logging with a unique token.

2014-03-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19396/#review38513 --- Ship it! Ship It! - Kevin Sweeney On March 21, 2014, 12:06 p.m

  1   2   3   4   5   6   7   8   >