Re: Review Request 16743: Use a separate thread for Driver.join() to avoid stalling the executor service.

2014-01-08 Thread Kevin Sweeney
On Jan. 8, 2014, 3:20 p.m., Maxim Khutornenko wrote: src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java, line 158 https://reviews.apache.org/r/16743/diff/1/?file=419102#file419102line158 How would the unhandled exception surface from here? Does it make sense to

Re: Review Request 16743: Use a separate thread for Driver.join() to avoid stalling the executor service.

2014-01-08 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16743/#review31412 --- Ship it! Ship It! - Kevin Sweeney On Jan. 8, 2014, 3:15 p.m

Review Request 16797: Change name of client console script to aurora.

2014-01-10 Thread Kevin Sweeney
--- Change name of client console script to aurora. Diffs - src/main/python/apache/aurora/client/BUILD 510297084a8fb14154aa0074f4e61a14b5837a8c Diff: https://reviews.apache.org/r/16797/diff/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 16615: Client command hooks doc

2014-01-13 Thread Kevin Sweeney
. - Kevin Sweeney On Jan. 3, 2014, 11:19 a.m., Tom Galloway wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16615/ --- (Updated

Re: Review Request 16834: Dropping scheduler_list_job_updates from aurora_admin

2014-01-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16834/#review31675 --- Ship it! Ship It! - Kevin Sweeney On Jan. 13, 2014, 3:34 p.m

Re: Review Request 16170: Revert Thrift upgrade.

2014-01-14 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16170/#review31756 --- Discarding this. - Kevin Sweeney On Dec. 10, 2013, 5:32 p.m

Re: Review Request 16265: Script for creating tags

2014-01-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16265/#review30382 --- On Jan. 15, 2014, 2:57 p.m., Kevin Sweeney wrote

Re: Review Request 16265: Script for creating tags

2014-01-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16265/#review31978 --- Thanks, submitted. - Kevin Sweeney On Jan. 15, 2014, 2:57 p.m

Re: Review Request 16931: Fixing admin scheduler_print_recovery_tasks.

2014-01-15 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16931/#review31979 --- Ship it! Ship It! - Kevin Sweeney On Jan. 15, 2014, 5:02 p.m

Re: Review Request 16941: add support for multiple GPG keys and fix rollback instructions

2014-01-16 Thread Kevin Sweeney
/ --- (Updated Jan. 15, 2014, 5:50 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- add support for multiple GPG keys and fix rollback instructions Diffs - build-support/tag-release

Re: Review Request 16941: add support for multiple GPG keys and fix rollback instructions

2014-01-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16941/#review32058 --- Ship it! Ship It! - Kevin Sweeney On Jan. 15, 2014, 5:50 p.m

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

2014-01-16 Thread Kevin Sweeney
(tested on Python 2.4 and Python 3.3): checksum=$(python -c import hashlib; m=hashlib.md5(); m.update(open('$file', 'rb').read()); print(m.hexdigest())) - Kevin Sweeney On Jan. 16, 2014, 12:34 p.m., Bill Farner wrote

Re: Review Request 16986: Add a test to encourage taking care with thrift changes.

2014-01-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16986/#review32088 --- Ship it! Ship It! - Kevin Sweeney On Jan. 16, 2014, 2:12 p.m

Re: Review Request 16985: Script to create Python sdists.

2014-01-16 Thread Kevin Sweeney
-SNAPSHOT Wrote /Users/ksweeney/workspace/aurora/dist/apache.gen.thermos-0.5.0-SNAPSHOT.tar.gz Thanks, Kevin Sweeney

Re: Review Request 16985: Script to create Python sdists.

2014-01-16 Thread Kevin Sweeney
generated e-mail. To reply, visit: https://reviews.apache.org/r/16985/#review32104 --- On Jan. 16, 2014, 4:56 p.m., Kevin Sweeney wrote: --- This is an automatically generated e

Re: Review Request 16615: Client command hooks doc

2014-01-16 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16615/#review32112 --- Ship it! Ship It! - Kevin Sweeney On Jan. 14, 2014, 12:23 p.m

Re: Review Request 16615: Client command hooks doc

2014-01-16 Thread Kevin Sweeney
/asf?p=incubator-aurora.git;a=commit;h=915977e4978a527c0133cb6f1fba350d11ce464c Please mark this review as submitted at your earliest convenience. Thanks so much for your work on this Tom! - Kevin Sweeney On Jan. 14, 2014, 12:23 p.m., Tom Galloway wrote

Re: Review Request 16601: Adding initial image in images directory

2014-01-16 Thread Kevin Sweeney
-us.apache.org/repos/asf?p=incubator-aurora.git;a=commit;h=915977e4978a527c0133cb6f1fba350d11ce464c Please mark this review as submitted at your earliest convenience. - Kevin Sweeney On Jan. 3, 2014, 1:14 a.m., Tom Galloway wrote

Re: Review Request 16985: Script to create Python sdists.

2014-01-16 Thread Kevin Sweeney
in /Users/ksweeney/workspace/aurora/dist/apache.gen.thermos-0.5.0-SNAPSHOT Wrote /Users/ksweeney/workspace/aurora/dist/apache.gen.thermos-0.5.0-SNAPSHOT.tar.gz Thanks, Kevin Sweeney

Re: Review Request 16874: Deprecate CronCollisionPolicy.RUN_OVERLAP.

2014-01-16 Thread Kevin Sweeney
9291fe668a30c32bed6791351c0fa905e57c26c1 src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java c67912365e1ca40a6d0d57cce6dc169306d17f10 Diff: https://reviews.apache.org/r/16874/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 16874: Deprecate CronCollisionPolicy.RUN_OVERLAP.

2014-01-16 Thread Kevin Sweeney
--- On Jan. 16, 2014, 6:22 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16874

Re: Review Request 17057: Deploying Aurora documentation improvements

2014-01-17 Thread Kevin Sweeney
mark this review submitted at your convenience. - Kevin Sweeney On Jan. 17, 2014, 10:47 a.m., Jeremy Lingmann wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17057

Re: Review Request 17072: Fixed and added docs about clusters.json, other misc markdown adjustments.

2014-01-17 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17072/#review32218 --- Ship it! Ship It! - Kevin Sweeney On Jan. 17, 2014, 2:53 p.m

Re: Review Request 17133: Improve test coverage for TaskAssignerImpl.

2014-01-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17133/#review32400 --- Ship it! Ship It! - Kevin Sweeney On Jan. 20, 2014, 2:12 p.m

Re: Review Request 17161: Update all dependencies coming from twitter commons and upgrade to guava 15

2014-01-21 Thread Kevin Sweeney
to warrant a linked ticket (reference it on the first line of your commit so that jenkins will comment). - Kevin Sweeney On Jan. 21, 2014, 3:18 p.m., Bill Farner wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 17042: Add a web interface to the zookeeper instance.

2014-01-21 Thread Kevin Sweeney
to pushd ~vagrant sudo -H -u vagrant git clone https://github.com/phunt/zookeeper_dashboard popd - Kevin Sweeney On Jan. 17, 2014, 11:21 a.m., Tobias Weingartner wrote: --- This is an automatically generated e-mail

Re: Review Request 17088: Cache hashCode in generated immutable classes.

2014-01-23 Thread Kevin Sweeney
https://reviews.apache.org/r/17088/#comment61566 parens on lhs are unnecessary here. src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py https://reviews.apache.org/r/17088/#comment61567 parens on lhs are unnecessary here. - Kevin Sweeney On Jan. 18, 2014, 11:19 a.m

Re: Review Request 17332: Add a noun supporting operations on roles

2014-01-24 Thread Kevin Sweeney
/prod/appserver - Kevin Sweeney On Jan. 24, 2014, 2:07 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Kevin Sweeney
/MemTaskStore.java https://reviews.apache.org/r/17372/#comment61900 Does it make sense to special-case the primary-key index here? Seems that the taskId index could implement SecondaryIndex (or just rename SecondaryIndex to Index). - Kevin Sweeney On Jan. 26, 2014, 1:52 p.m., Bill Farner wrote

Re: Review Request 17372: Add an abstraction for secondary indices, introduce an index on slave host.

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17372/#review32900 --- Ship it! Ship It! - Kevin Sweeney On Jan. 26, 2014, 1:52 p.m

Re: Review Request 17412: Quiet noisy status checker debug messages

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17412/#review32901 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 1:25 p.m

Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Kevin Sweeney
, Kevin Sweeney, Bill Farner, and Brian Wickman. Bugs: AURORA-30 https://issues.apache.org/jira/browse/AURORA-30 Repository: aurora Description --- Removes aurora/twitterdeps and moves all external dependency calls to a new 3rdparty/python/BUILD file. Diffs

Re: Review Request 17432: Fix regression causing secondary index to store duplicate tasks.

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17432/#review32916 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 3:58 p.m

Re: Review Request 17419: AURORA-30:Clean up and coalesce 3rdparty python deps

2014-01-27 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17419/#review32923 --- Ship it! Ship It! - Kevin Sweeney On Jan. 27, 2014, 4:19 p.m

Review Request 17464: Upgrade RBTools to 0.5.5.

2014-01-28 Thread Kevin Sweeney
a05476d175bf3959cc6e5d96aab55215fac9e36b Diff: https://reviews.apache.org/r/17464/diff/ Testing --- Posted this review, verified upgrade works. Thanks, Kevin Sweeney

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Kevin Sweeney
/StateManagerImpl.java https://reviews.apache.org/r/16873/#comment61431 This seems like a big enough gotcha to warrant filing a ticket. - Kevin Sweeney On Jan. 14, 2014, 3:27 p.m., Bill Farner wrote: --- This is an automatically generated e

Re: Review Request 17063: Update tag-release to allow patch level increments.

2014-01-28 Thread Kevin Sweeney
/17063/#comment62305 A dev tag should update .auroraversion so that generated artifacts have the tag in them. Without this the tag will point to a -snapshot. - Kevin Sweeney On Jan. 28, 2014, 3:11 p.m., Brian Wickman wrote

Re: Review Request 17430: Bug fix: Return job count instead of task count on GetRoleSummary() call.

2014-01-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17430/#review33076 --- Ship it! Ship It! - Kevin Sweeney On Jan. 28, 2014, 2:17 p.m

Re: Review Request 17063: Update tag-release to allow patch level increments.

2014-01-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17063/#review33077 --- Ship it! Ship It! - Kevin Sweeney On Jan. 28, 2014, 3:32 p.m

Review Request 17475: Upgrade mesos to 0.15.0

2014-01-28 Thread Kevin Sweeney
5170b4076fc6e4424914493208c779f4494ed097 src/main/python/apache/aurora/executor/BUILD 2524b2ee295011cca51fff672adf65cdc8e9137b Diff: https://reviews.apache.org/r/17475/diff/ Testing --- vagrant up ./build-support/jenkins/build.sh Thanks, Kevin Sweeney

Review Request 17507: Fix indentation in tutorial

2014-01-29 Thread Kevin Sweeney
Description --- Fix indentation in tutorial Diffs - docs/tutorial.md a9c83fb72b7e41719717ac20c146caa161d6dc5e Diff: https://reviews.apache.org/r/17507/diff/ Testing --- Pushed to github branch and verified formatting. Thanks, Kevin Sweeney

Re: Review Request 17507: Fix indentation in tutorial

2014-01-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17507/#review33240 --- Pushing this trivial change to master TBR. - Kevin Sweeney

Re: Review Request 17559: requirement should be mesos==0.15.0-rc4

2014-01-30 Thread Kevin Sweeney
not to go forward with that one? - Kevin Sweeney On Jan. 30, 2014, 1:03 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17559

Re: Review Request 17562: Added cluster name to page title.

2014-01-30 Thread Kevin Sweeney
getClusterInfo - Kevin Sweeney On Jan. 30, 2014, 2:27 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562

Re: Review Request 17578: When trying to schedule a task, only query once for active tasks in the job.

2014-01-30 Thread Kevin Sweeney
about making this query lazy so that it happens the first time the info is needed rather than eagerly when it might not be needed? - Kevin Sweeney On Jan. 30, 2014, 6:17 p.m., Bill Farner wrote: --- This is an automatically generated e

Re: Review Request 17332: Add a noun supporting operations on roles

2014-01-31 Thread Kevin Sweeney
On Jan. 24, 2014, 2:35 p.m., Kevin Sweeney wrote: Why is this happening on a role noun and not a quota noun. i.e. aurora quota get west/ksweeney v.s. aurora role get_quota west/ksweeney The second looks inconsistent with the noun-verb model to me and if we ever

Re: Review Request 17666: Adding DRAINING state into api.thrift.

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17666/#review33462 --- Ship it! Ship It! - Kevin Sweeney On Feb. 3, 2014, 10:16 a.m

Re: Review Request 17060: Fix noisy status checker debug log.

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17060/#review33463 --- Ship it! Ship It! - Kevin Sweeney On Jan. 17, 2014, 11:06 a.m

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Kevin Sweeney
expansion with \$? - Kevin Sweeney On Feb. 3, 2014, 8:30 a.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457

Re: Review Request 17056: fix dependencies for setup_py

2014-02-03 Thread Kevin Sweeney
://reviews.apache.org/r/17056/#comment62959 I'm unclear on the convention being followed for -packaged dependencies. Wouldn't this be automatic if src/main/python/apache/aurora/config has a provides statement? - Kevin Sweeney On Jan. 17, 2014, 10:37 a.m., Brian Wickman wrote

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Kevin Sweeney
On Feb. 3, 2014, 11:31 a.m., Kevin Sweeney wrote: examples/vagrant/provision-mesos-slave.sh, line 9 https://reviews.apache.org/r/17457/diff/3/?file=463332#file463332line9 Rather than using sed here you can use interpolation as follows: eager expansion

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Kevin Sweeney
On Feb. 3, 2014, 1:47 p.m., Kevin Sweeney wrote: examples/vagrant/provision-dev-environment.sh, line 5 https://reviews.apache.org/r/17457/diff/4/?file=463503#file463503line5 git is already on this commandline and setuptools shouldn't be needed. From the virtualbox environment

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Kevin Sweeney
/provision-dev-environment.sh https://reviews.apache.org/r/17457/#comment63025 kill eol whitespace examples/vagrant/provision-mesos-slave.sh https://reviews.apache.org/r/17457/#comment63026 Escape exit status with \$? for lazy interpolation. - Kevin Sweeney On Feb. 3, 2014, 2:55 p.m., Mark

Review Request 17679: Upgrade twitter.common.python to 0.3.0

2014-02-03 Thread Kevin Sweeney
229e201b8fa7b069eee4291695ce341318ef976e rbt 8828ead987ba84ef8d7435b30b7ff99a1d5e20a1 Diff: https://reviews.apache.org/r/17679/diff/ Testing --- Ran ./pants, ./rbt, ./build-support/pex, ./build-support/release/make-python-sdists from clean and dirty repos. ./pants src/test/python:all Thanks, Kevin Sweeney

Re: Review Request 17056: fix dependencies for setup_py

2014-02-03 Thread Kevin Sweeney
. - Kevin Sweeney On Jan. 17, 2014, 10:37 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/ --- (Updated

Re: Review Request 17562: Added cluster name to page title.

2014-02-03 Thread Kevin Sweeney
On Jan. 30, 2014, 4:56 p.m., Kevin Sweeney wrote: Suman Karumuri wrote: Spoke to Bill before making these changes. We decided to use getInfo API and deprecate getAPIVersion. The getInfo will return with the clusterName and APIVersion for now. In future it may include other

Re: Review Request 17457: Initial version of an end-to-end test using vagrant

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17457/#review33530 --- Ship it! Ship It! - Kevin Sweeney On Feb. 3, 2014, 3:43 p.m

Re: Review Request 17679: Upgrade twitter.common.python to 0.3.0

2014-02-03 Thread Kevin Sweeney
/release/make-python-sdists from clean and dirty repos. ./pants src/test/python:all Thanks, Kevin Sweeney

Re: Review Request 17689: Fixing submit instructions.

2014-02-03 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17689/#review33557 --- Ship it! Ship It! - Kevin Sweeney On Feb. 3, 2014, 6 p.m

Re: Review Request 17715: Added THROTTLED state to scheduler UI.

2014-02-04 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17715/#review33626 --- Ship it! Ship It! - Kevin Sweeney On Feb. 4, 2014, 11 a.m

Re: Review Request 17724: Add an exception catch to provide a better error message when distributed command runner fails

2014-02-04 Thread Kevin Sweeney
? where do I define them?) - Kevin Sweeney On Feb. 4, 2014, 1:49 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17724

Review Request 17750: CronScheduler implementation based on Quartz.

2014-02-05 Thread Kevin Sweeney
/17750/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.

2014-02-05 Thread Kevin Sweeney
: https://reviews.apache.org/r/17749/#review33715 --- On Feb. 5, 2014, 12:31 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 17749: Refactor CronScheduler interfaces to use Guava Service.

2014-02-05 Thread Kevin Sweeney
94441b8f7a66c1eabc542e56275f3b32cf536684 src/test/java/org/apache/aurora/scheduler/state/CronJobManagerTest.java 462e64f1d6a57724ed51953149dd151081b63115 Diff: https://reviews.apache.org/r/17749/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17729/#review33742 --- Ship it! Ship It! - Kevin Sweeney On Feb. 4, 2014, 5:59 p.m

Re: Review Request 17768: AURORA-193: License header cleanup

2014-02-05 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17768/#review33743 --- Ship it! Ship It! - Kevin Sweeney On Feb. 5, 2014, 4:24 p.m

Review Request 17771: AURORA-193: Fix license plugin

2014-02-05 Thread Kevin Sweeney
: https://reviews.apache.org/r/17771/diff/ Testing (updated) --- ./gradlew clean build Thanks, Kevin Sweeney

Re: Review Request 17332: Add a noun supporting operations on roles

2014-02-06 Thread Kevin Sweeney
: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17332/ --- (Updated Feb. 5, 2014, 7:08 a.m.) Review request for Aurora, Kevin Sweeney and Brian Wickman. Bugs: aurora-107 https

Re: Review Request 17056: fix dependencies for setup_py

2014-02-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review33840 --- Did this ever land? - Kevin Sweeney On Jan. 17, 2014, 10:37 a.m

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-02-06 Thread Kevin Sweeney
://reviews.apache.org/r/17750/ Merging AbstractCronIT and QuartzCronIT is on the list of followup TODOs for that review, so this will be mitigated then. - Kevin Sweeney On Feb. 6, 2014, 12:57 p.m., Jake Farrell wrote

Re: Review Request 17723: Implementing support for DRAINING state.

2014-02-06 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17723/#review33847 --- Ship it! Ship It! - Kevin Sweeney On Feb. 4, 2014, 1:31 p.m

Review Request 17823: Add a utility to list missing shipits.

2014-02-06 Thread Kevin Sweeney
| wc -l 11 Thanks, Kevin Sweeney

Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.

2014-02-06 Thread Kevin Sweeney
://reviews.apache.org/r/17785/#comment63544 I'm not clear on why THROTTLED is an active state - doesn't it precede PENDING? src/test/resources/org/apache/aurora/gen/api.thrift.md5 https://reviews.apache.org/r/17785/#comment63541 Looks like this might need rebasing. - Kevin Sweeney On Feb. 5

Re: Review Request 17785: Ignore THROTTLED tasks when looking for tasks associated with a slave.

2014-02-06 Thread Kevin Sweeney
On Feb. 6, 2014, 4:05 p.m., Kevin Sweeney wrote: src/main/thrift/org/apache/aurora/gen/api.thrift, line 273 https://reviews.apache.org/r/17785/diff/1/?file=470610#file470610line273 I'm not clear on why THROTTLED is an active state - doesn't it precede PENDING? Maxim

Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution

2014-02-06 Thread Kevin Sweeney
, 2014, 5:45 p.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Bugs: AURORA-145 https://issues.apache.org/jira/browse/AURORA-145 Repository: aurora Description --- AURORA-145:Test dependencies leak into distribution First part of Aurora-145 which makes

Re: Review Request 17750: CronScheduler implementation based on Quartz.

2014-02-10 Thread Kevin Sweeney
., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17750/ --- (Updated Feb. 5, 2014, 3:23 p.m.) Review

Re: Review Request 17955: Moving RUN_OVERLAP check into receiveJob() to prevent failure on startup.

2014-02-11 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17955/#review34215 --- Ship it! Ship It! - Kevin Sweeney On Feb. 11, 2014, 10:58 a.m

Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-12 Thread Kevin Sweeney
/UIRedirectFilter.java https://reviews.apache.org/r/18036/#comment64393 Is this not logged by the library? - Kevin Sweeney On Feb. 12, 2014, 3:26 p.m., Suman Karumuri wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 18036: Added LeaderRedirectFilter to scheduler home page.

2014-02-13 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18036/#review34403 --- Ship it! LGTM mod redundant redundant logging - Kevin Sweeney

Re: Review Request 17823: Add a utility to list missing shipits.

2014-02-13 Thread Kevin Sweeney
| wc -l 7 Thanks, Kevin Sweeney

Re: Review Request 17750: CronScheduler implementation based on Quartz.

2014-02-13 Thread Kevin Sweeney
/scheduler/cron/quartz/QuartzCronSchedulerTest.java PRE-CREATION Diff: https://reviews.apache.org/r/17750/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Review Request 18149: Cron predictor conformance test.

2014-02-14 Thread Kevin Sweeney
d8c40222809f525ce485a002873f1fe9dedc2748 src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json PRE-CREATION Diff: https://reviews.apache.org/r/18149/diff/ Testing --- ./gradlew build Thanks, Kevin Sweeney

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18229/#review34736 --- Can you verify this fixes the e2e test? - Kevin Sweeney On Feb

Re: Review Request 18229: Pin aurora at pants==0.0.14-dev2

2014-02-18 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18229/#review34772 --- Ship it! Ship It! - Kevin Sweeney On Feb. 18, 2014, 10:52 a.m

Review Request 18244: Use GMT in generated predictions.

2014-02-18 Thread Kevin Sweeney
--- Use GMT in generated conformance data. Diffs - src/main/resources/org/apache/aurora/scheduler/cron/testing/cron-schedule-predictions.json d4feb1bd8245aa294c3231b141018070fb0d68e5 Diff: https://reviews.apache.org/r/18244/diff/ Testing --- Manual inspection. Thanks, Kevin

Review Request 18245: Use user.signingkey for tag-signing.

2014-02-18 Thread Kevin Sweeney
://reviews.apache.org/r/18245/diff/ Testing --- Tested with user.signingkey set and unset on local merged master. Thanks, Kevin Sweeney

Review Request 18247: Add kevints CODE SIGNING KEY to KEYS.

2014-02-18 Thread Kevin Sweeney
Description --- Add kevints CODE SIGNING KEY to KEYS. Diffs - KEYS 55eec288042426313f67b070b1cc489283ef2bbf Diff: https://reviews.apache.org/r/18247/diff/ Testing --- Thanks, Kevin Sweeney

Re: Review Request 18306: Merge remote-tracking branch 'brianm/patch-2' into HEAD

2014-02-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18306/#review35025 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 2:01 a.m

Re: Review Request 18306: Merge remote-tracking branch 'brianm/patch-2' into HEAD

2014-02-20 Thread Kevin Sweeney
/repos/asf?p=incubator-aurora.git;a=commit;h=56a8cc37940d0bb75d5f54f75cc71757b5c4aa60 - Kevin Sweeney On Feb. 20, 2014, 2:01 a.m., Brian McCallister wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 18297: Clean up idea module configuration, make sure generated sources are available.

2014-02-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18297/#review35038 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 10:41 a.m

Re: Review Request 18141: Prepare and launch GC executor tasks asynchronously.

2014-02-20 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18141/#review35103 --- Ship it! Ship It! - Kevin Sweeney On Feb. 19, 2014, 1:39 p.m

Re: Review Request 18316: Aurora-193: fix license plugin

2014-02-21 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18316/#review35199 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 11:50 a.m

Re: Review Request 18334: Move and unit test Maintenance module and commands

2014-02-24 Thread Kevin Sweeney
to explicitly call out I'm using system time to avoid missed mock coverage causing the test suite to slow down. - Kevin Sweeney On Feb. 24, 2014, 10:19 a.m., Joe Smith wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 16710: Support multiple simulataneous auth mechanisms.

2014-02-24 Thread Kevin Sweeney
://reviews.apache.org/r/16710/#review31445 --- On Jan. 7, 2014, 4:45 p.m., Kevin Sweeney wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 18481: Upgrade pex to twitter.common.python==0.3.1

2014-02-25 Thread Kevin Sweeney
--- SSIA Diffs - build-support/pex cd083d996884681acf6f731ed24037342f2309bf Diff: https://reviews.apache.org/r/18481/diff/ Testing --- Tested upgrade on clean and dirty master. Thanks, Kevin Sweeney

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

2014-02-25 Thread Kevin Sweeney
request for Aurora and Kevin Sweeney. Bugs: AURORA-225 https://issues.apache.org/jira/browse/AURORA-225 Repository: aurora Description --- AURORA-225: Shell scripts in checkout should use an absolute path Diffs - build-support/pex

Re: Review Request 18241: Reworked LogStorage to avoid unnecessary extra calls to write().

2014-02-25 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18241/#review35453 --- Ship it! Ship It! - Kevin Sweeney On Feb. 20, 2014, 5:16 p.m

Re: Review Request 18240: Accumulate read/write timing in MemStorage for top-level operations only.

2014-02-25 Thread Kevin Sweeney
/storage/ReadWriteLockManager.java https://reviews.apache.org/r/18240/#comment65978 reads better statically imported (here and elsewhere). - Kevin Sweeney On Feb. 18, 2014, 1:55 p.m., Bill Farner wrote: --- This is an automatically

Re: Review Request 18345: AURORA-225: Shell scripts in checkout should use an absolute path

2014-02-25 Thread Kevin Sweeney
=incubator-aurora.git;a=commitdiff;h=6e7acbfb7a8b4cb9694fbc510fc67e07c1b34454 - Kevin Sweeney On Feb. 24, 2014, 6:45 p.m., Dan Norris wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18345

Re: Review Request 18481: Upgrade pex to twitter.common.python==0.3.1

2014-02-25 Thread Kevin Sweeney
. Changes --- rebase Repository: aurora Description --- SSIA Diffs (updated) - build-support/pex 56f952a4042be2b9fca7c8879ac127468ec76988 Diff: https://reviews.apache.org/r/18481/diff/ Testing --- Tested upgrade on clean and dirty master. Thanks, Kevin Sweeney

  1   2   3   4   5   6   7   8   9   >