Review Request 28920: Add support for docker containers to aurora

2014-12-10 Thread Steve Niemitz
/apache/aurora/scheduler/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-10 Thread Steve Niemitz
/scheduler/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-16 Thread Steve Niemitz
Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-16 Thread Steve Niemitz
/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2014-12-26 Thread Steve Niemitz
ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-29 Thread Steve Niemitz
/LeaderRedirect.java cf173850635572c0df38bdd5cb14de8ce2016bf7 src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java c3bf5ea4cbeaad03e187f84215b86531d55c25b3 Diff: https://reviews.apache.org/r/29464/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-29 Thread Steve Niemitz
, visit: https://reviews.apache.org/r/29464/#review66297 --- On Dec. 29, 2014, 8:23 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-29 Thread Steve Niemitz
(to separate wiring from implementation). Also, this value will need to be plumbed into the mesos Log somehow. Steve Niemitz wrote: Ok cool, I can make that change. Also can you explain more what you mean by plumbed into the mesos Log somehow? - Steve

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-30 Thread Steve Niemitz
(to separate wiring from implementation). Also, this value will need to be plumbed into the mesos Log somehow. Steve Niemitz wrote: Ok cool, I can make that change. Steve Niemitz wrote: Also can you explain more what you mean by plumbed into the mesos Log somehow? Kevin

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-30 Thread Steve Niemitz
--- On Dec. 29, 2014, 8:23 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-30 Thread Steve Niemitz
c3bf5ea4cbeaad03e187f84215b86531d55c25b3 Diff: https://reviews.apache.org/r/29464/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-30 Thread Steve Niemitz
c3bf5ea4cbeaad03e187f84215b86531d55c25b3 Diff: https://reviews.apache.org/r/29464/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-30 Thread Steve Niemitz
/aurora/scheduler/http/JettyServerModuleTest.java fbc3da3ab239b67ce3012d5a14fccd3ccb20a241 src/test/java/org/apache/aurora/scheduler/http/LeaderRedirectTest.java c3bf5ea4cbeaad03e187f84215b86531d55c25b3 Diff: https://reviews.apache.org/r/29464/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-30 Thread Steve Niemitz
://reviews.apache.org/r/29464/#review66425 --- On Dec. 31, 2014, 12:23 a.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-30 Thread Steve Niemitz
. 31, 2014, 12:23 a.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464/ --- (Updated Dec. 31, 2014, 12:23

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-31 Thread Steve Niemitz
--- Thanks, Steve Niemitz

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2014-12-31 Thread Steve Niemitz
c3bf5ea4cbeaad03e187f84215b86531d55c25b3 src/test/python/apache/aurora/executor/common/test_announcer.py e329a90b8fba43611f5120e2a5ee82220dbe2a91 Diff: https://reviews.apache.org/r/29464/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Steve Niemitz
/executor/test_thermos_executor.py 6c8ae1cf7fb578237708a954bd42162d66b39f4d Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-23 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69439 --- @ReviewBot retry - Steve Niemitz On Jan. 23, 2015, 5:23 p.m

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-14 Thread Steve Niemitz
/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-14 Thread Steve Niemitz
. To reply, visit: https://reviews.apache.org/r/28920/#review68098 --- On Jan. 14, 2015, 7:14 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-14 Thread Steve Niemitz
://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-14 Thread Steve Niemitz
supplemented with https://reviews.apache.org/r/29827/ Steve Niemitz wrote: Is there any need to validate anymore now that the volume configuration is gone? That's what was going to be validated correct? Bill Farner wrote: I would like to see an argument to specify which `ContainerType`s

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Steve Niemitz
/SchedulerThriftInterfaceTest.java ad9126c32893080e128d086ea3bfd7ad23d27b89 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-15 Thread Steve Niemitz
503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-14 Thread Steve Niemitz
--- On Jan. 13, 2015, 1:11 a.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/ --- (Updated Jan. 13, 2015

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-14 Thread Steve Niemitz
/#review68013 --- On Jan. 13, 2015, 1:11 a.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-14 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68013 --- On Jan. 13, 2015, 1:11 a.m., Steve Niemitz wrote

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-14 Thread Steve Niemitz
using a clutch... @ReviewBot retry - Steve Niemitz On Jan. 14, 2015, 4:50 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-14 Thread Steve Niemitz
/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-14 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68056 --- @ReviewBot retry - Steve Niemitz On Jan. 14, 2015, 4:50 p.m

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-22 Thread Steve Niemitz
generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review68845 --- On Jan. 16, 2015, 12:08 a.m., Steve Niemitz wrote: --- This is an automatically generated e-mail

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-22 Thread Steve Niemitz
--- On Jan. 16, 2015, 12:08 a.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-22 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69333 --- On Jan. 16, 2015, 12:08 a.m., Steve Niemitz wrote

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-22 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review69288 --- On Jan. 16, 2015, 12:08 a.m., Steve Niemitz wrote

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-22 Thread Steve Niemitz
with a DockerSandboxProvider in the thermos executor? similarly, DOCKER_COMMAND_SUFFIX should be unnecessary since this information is available in the TaskConfig. if both the above are true, then we don't need any of the changes to CommandUtil. Steve Niemitz wrote

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-22 Thread Steve Niemitz
with a DockerSandboxProvider in the thermos executor? similarly, DOCKER_COMMAND_SUFFIX should be unnecessary since this information is available in the TaskConfig. if both the above are true, then we don't need any of the changes to CommandUtil. Steve Niemitz wrote

Review Request 30331: Fixed python tests hanging

2015-01-27 Thread Steve Niemitz
Description --- Fixed python tests hanging Diffs - src/test/python/apache/aurora/executor/test_thermos_executor.py e6191f3e7775663ad4a75546b5e86289bb73e989 Diff: https://reviews.apache.org/r/30331/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 30331: Fixed python tests hanging

2015-01-27 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30331/#review69902 --- On Jan. 27, 2015, 10:28 p.m., Steve Niemitz wrote

Re: Review Request 30331: Fixed python tests hanging

2015-01-27 Thread Steve Niemitz
e6191f3e7775663ad4a75546b5e86289bb73e989 Diff: https://reviews.apache.org/r/30331/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 30331: Fixed python tests hanging

2015-01-27 Thread Steve Niemitz
On Jan. 27, 2015, 10:32 p.m., Kevin Sweeney wrote: Any idea which change introduced this breakage? Can you elaborate in the description? Steve Niemitz wrote: Sorry yeah, I was writing up an email to the dev list. I'll just post here instead. I actually was the one who broke

Re: Review Request 30384: Added TellApart to list of aurora users.

2015-01-28 Thread Steve Niemitz
. Changes --- So many more Ss. Repository: aurora Description --- Added TellApart to list of aurora users. Diffs (updated) - README.md 61e0253b1f7a3958c1e8444a071d8364b4164fab Diff: https://reviews.apache.org/r/30384/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 30384: Added TellApart to list of aurora users.

2015-01-28 Thread Steve Niemitz
though. :) - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30384/#review70107 --- On Jan. 28, 2015, 11:03 p.m., Steve Niemitz wrote

Review Request 30384: Added TellApart to list of aurora users.

2015-01-28 Thread Steve Niemitz
--- Added TellApart to list of aurora users. Diffs - README.md 61e0253b1f7a3958c1e8444a071d8364b4164fab Diff: https://reviews.apache.org/r/30384/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29827: End to end tests for docker in aurora

2015-01-27 Thread Steve Niemitz
/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29827: End to end tests for docker in aurora

2015-01-28 Thread Steve Niemitz
/29827/#review70026 --- On Jan. 27, 2015, 4:58 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827

Re: Review Request 29827: End to end tests for docker in aurora

2015-01-28 Thread Steve Niemitz
/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 30471: Revert backwards incomaptible chnages to GC ExecutorInfo.

2015-01-30 Thread Steve Niemitz
is true there's no changes to the functionality my Docker implementation needs. I'm still curious why I'm not running into this issues though. - Steve Niemitz On Jan. 30, 2015, 11:24 p.m., Zameer Manji wrote: --- This is an automatically

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-05 Thread Steve Niemitz
--- On Jan. 5, 2015, 8:25 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-05 Thread Steve Niemitz
/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-12 Thread Steve Niemitz
. If so, would it be easier to just accept an arbitrary number of additional assets to copy into the sandbox? I would find that more generalized, and easier to understand. If you go with the above, i _think_ you can also safely nuke the extra args plumbing. Steve Niemitz wrote

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-12 Thread Steve Niemitz
/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-12 Thread Steve Niemitz
503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-12 Thread Steve Niemitz
503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Review Request 29827: End to end tests for docker in aurora

2015-01-12 Thread Steve Niemitz
PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_common.sh 31646425233470b5f87ab50ef4504264f235f48a src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 578662ccd1735ebf500d066b3cc17b30f635c15f Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-09 Thread Steve Niemitz
://reviews.apache.org/r/29464/#review67136 --- On Jan. 8, 2015, 5:25 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-09 Thread Steve Niemitz
/scheduler/mesos/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Steve Niemitz
/executor/common/test_announcer.py e329a90b8fba43611f5120e2a5ee82220dbe2a91 Diff: https://reviews.apache.org/r/29464/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-06 Thread Steve Niemitz
ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Steve Niemitz
/#review66920 --- On Jan. 5, 2015, 6:47 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-06 Thread Steve Niemitz
--- On Jan. 6, 2015, 10:45 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464/ --- (Updated Jan. 6

Re: Review Request 29829: Fixed cleanup in end to end failure after v1 client removal

2015-01-12 Thread Steve Niemitz
Sweeney. Repository: aurora Description --- Fixed cleanup in end to end failure after v1 client removal Diffs - src/test/sh/org/apache/aurora/e2e/test_common.sh 31646425233470b5f87ab50ef4504264f235f48a Diff: https://reviews.apache.org/r/29829/diff/ Testing --- Thanks, Steve

Re: Review Request 29827: End to end tests for docker in aurora

2015-01-12 Thread Steve Niemitz
/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-12 Thread Steve Niemitz
. If so, would it be easier to just accept an arbitrary number of additional assets to copy into the sandbox? I would find that more generalized, and easier to understand. If you go with the above, i _think_ you can also safely nuke the extra args plumbing. Steve Niemitz wrote

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-12 Thread Steve Niemitz
503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29829: Fixed cleanup in end to end failure after v1 client removal

2015-01-12 Thread Steve Niemitz
/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29827: End to end tests for docker in aurora

2015-01-12 Thread Steve Niemitz
/http_example_docker.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve

Re: Review Request 29827: End to end tests for docker in aurora

2015-01-12 Thread Steve Niemitz
PRE-CREATION src/test/sh/org/apache/aurora/e2e/http/http_example_docker_updated.aurora PRE-CREATION src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh 45da754341de52759d05a8960a9a978111f1e415 Diff: https://reviews.apache.org/r/29827/diff/ Testing --- Thanks, Steve Niemitz

Review Request 29829: Fixed cleanup in end to end failure after v1 client removal

2015-01-12 Thread Steve Niemitz
cleanup in end to end failure after v1 client removal Diffs - src/test/sh/org/apache/aurora/e2e/test_common.sh 31646425233470b5f87ab50ef4504264f235f48a Diff: https://reviews.apache.org/r/29829/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-12 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review67761 --- @ReviewBot retry - Steve Niemitz On Jan. 12, 2015, 9:40 p.m

Re: Review Request 29827: End to end tests for docker in aurora

2015-01-12 Thread Steve Niemitz
--- On Jan. 12, 2015, 11:05 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29827

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-05 Thread Steve Niemitz
/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-05 Thread Steve Niemitz
/MesosTaskFactoryImplTest.java ddcb511d108220ab5e4efcf3496458f7ab4a20c2 src/test/python/apache/aurora/executor/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-05 Thread Steve Niemitz
c3bf5ea4cbeaad03e187f84215b86531d55c25b3 src/test/python/apache/aurora/executor/common/test_announcer.py e329a90b8fba43611f5120e2a5ee82220dbe2a91 Diff: https://reviews.apache.org/r/29464/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-05 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920/#review66692 --- On Dec. 26, 2014, 9:05 p.m., Steve Niemitz wrote

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-08 Thread Steve Niemitz
/29464/#review67136 --- On Jan. 7, 2015, 9:21 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29464

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-07 Thread Steve Niemitz
/executor/common/test_announcer.py e329a90b8fba43611f5120e2a5ee82220dbe2a91 Diff: https://reviews.apache.org/r/29464/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29464: Add option to override local scheduler address published into ZooKeeper

2015-01-07 Thread Steve Niemitz
c3bf5ea4cbeaad03e187f84215b86531d55c25b3 src/test/python/apache/aurora/executor/common/test_announcer.py e329a90b8fba43611f5120e2a5ee82220dbe2a91 Diff: https://reviews.apache.org/r/29464/diff/ Testing --- Thanks, Steve Niemitz

Review Request 29662: Fixed make-python-sdists

2015-01-07 Thread Steve Niemitz
make-python-sdists after removal of v1 client. Diffs - build-support/release/make-python-sdists a7a627f006b85c0749b3b7eac9528046091bf988 Diff: https://reviews.apache.org/r/29662/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 29662: Fixed make-python-sdists

2015-01-07 Thread Steve Niemitz
. Repository: aurora Description --- Fixed make-python-sdists after removal of v1 client. Diffs - build-support/release/make-python-sdists a7a627f006b85c0749b3b7eac9528046091bf988 Diff: https://reviews.apache.org/r/29662/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-08 Thread Steve Niemitz
/test_thermos_executor.py 503e62f4cac872b14f6985b5bccc3e4dfcf81789 Diff: https://reviews.apache.org/r/28920/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-08 Thread Steve Niemitz
for it to be used? Can we cope with the user specifying a bad path? If not, what's the fallout - TASK_FAILED? Steve Niemitz wrote: The Volume options are for mounting paths on the host into the docker container, and correspond to the -v flag of docker run (https://docs.docker.com

Re: Review Request 28920: Add support for docker containers to aurora

2015-01-08 Thread Steve Niemitz
--- On Jan. 6, 2015, 11:32 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28920

Review Request 32106: Changed the updater to not update an instance if only the job owner changes

2015-03-16 Thread Steve Niemitz
/org/apache/aurora/scheduler/updater/InstanceUpdaterTest.java 09c147e76d7c2c130a1fdd85459c45395fee7dde Diff: https://reviews.apache.org/r/32106/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 31813: Minor clean up to docker docs.

2015-03-06 Thread Steve Niemitz
://reviews.apache.org/r/31813/#comment122752 Haha, moints. - Steve Niemitz On March 6, 2015, 11:06 p.m., Joshua Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31813

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Steve Niemitz
/MesosTaskFactoryImplTest.java 444d6d3fdaf86eb84612f846eaa326eb75c49898 src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java efe62ceb502ead88a2f0cd6d09a76664e465d9bc Diff: https://reviews.apache.org/r/31338/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Steve Niemitz
)); ``` Done - Steve --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74782 --- On March 2, 2015, 4:59 p.m., Steve Niemitz

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-03 Thread Steve Niemitz
/MesosTaskFactoryImplTest.java 444d6d3fdaf86eb84612f846eaa326eb75c49898 src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java efe62ceb502ead88a2f0cd6d09a76664e465d9bc Diff: https://reviews.apache.org/r/31338/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-03 Thread Steve Niemitz
efe62ceb502ead88a2f0cd6d09a76664e465d9bc Diff: https://reviews.apache.org/r/31338/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-03-03 Thread Steve Niemitz
Niemitz On Feb. 26, 2015, 3:20 p.m., Steve Niemitz wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/ --- (Updated Feb

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Steve Niemitz
/MesosTaskFactoryImplTest.java 444d6d3fdaf86eb84612f846eaa326eb75c49898 src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java efe62ceb502ead88a2f0cd6d09a76664e465d9bc Diff: https://reviews.apache.org/r/31338/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Steve Niemitz
we should fail if other volumes show up. ``` assertEquals( ImmutableList.of(expected), taskInfo.getExecutor().getContainer().getVolumesList()); ``` Steve Niemitz wrote: I think checking only this specifically is a more robust test

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74752 --- @ReviewBot retry - Steve Niemitz On March 2, 2015, 4:59 p.m

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-03-02 Thread Steve Niemitz
/MesosTaskFactoryImplTest.java 444d6d3fdaf86eb84612f846eaa326eb75c49898 src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java efe62ceb502ead88a2f0cd6d09a76664e465d9bc Diff: https://reviews.apache.org/r/31338/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Steve Niemitz
/MesosTaskFactoryImplTest.java 444d6d3fdaf86eb84612f846eaa326eb75c49898 src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java efe62ceb502ead88a2f0cd6d09a76664e465d9bc Diff: https://reviews.apache.org/r/31338/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31338/#review74507 --- On Feb. 25, 2015, 10:35 p.m., Steve Niemitz wrote

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-02-27 Thread Steve Niemitz
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31423/#review74620 --- On Feb. 26, 2015, 3:20 p.m., Steve Niemitz wrote

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-27 Thread Steve Niemitz
/MesosTaskFactoryImplTest.java 444d6d3fdaf86eb84612f846eaa326eb75c49898 src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java efe62ceb502ead88a2f0cd6d09a76664e465d9bc Diff: https://reviews.apache.org/r/31338/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 31338: Added a command line flag, -global_container_mounts, to allow mounting paths from the slaves into the (docker) containers they run.

2015-02-25 Thread Steve Niemitz
/MesosTaskFactoryImplTest.java 444d6d3fdaf86eb84612f846eaa326eb75c49898 src/test/java/org/apache/aurora/scheduler/mesos/TaskExecutors.java efe62ceb502ead88a2f0cd6d09a76664e465d9bc Diff: https://reviews.apache.org/r/31338/diff/ Testing --- Thanks, Steve Niemitz

Re: Review Request 31423: Stop the announcer and status checkers before starting to kill the runners

2015-02-25 Thread Steve Niemitz
. Watching ZK, I can confirm that the nodes are removed before process shutdown begins. Watching the executor log also confirms this. I couldn't observe any other side effects either. Thanks, Steve Niemitz

  1   2   >