Re: Review Request 16423: client v2: added implementations of job diff, job inspect.

2014-01-13 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31615
---


Sorry about the merge glitches; that was sloppy of me. I shouldn't have tried 
to push the branch-merge so quickly.


src/test/python/twitter/aurora/client/cli/BUILD
https://reviews.apache.org/r/16423/#comment60210

Weird - don't see this in my workspace. Strange; I must have done something 
stupid like not saved one of my open buffers before pushing the review.


- Mark Chu-Carroll


On Jan. 8, 2014, 7:12 p.m., Mark Chu-Carroll wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16423/
 ---
 
 (Updated Jan. 8, 2014, 7:12 p.m.)
 
 
 Review request for Aurora, Jonathan Boulle and Brian Wickman.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Implemented client v2 versions of the diff and inspect verbs.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/cli/__init__.py 
 2c08cf985a3ad9126a544596f895540524af865c 
   src/main/python/apache/aurora/client/cli/context.py 
 c50f1a15847f5374a30d6bc93915123d8471e4aa 
   src/main/python/apache/aurora/client/cli/jobs.py 
 b789361313e279ac8398a92a46ec724c09fb4513 
   src/main/python/apache/aurora/client/cli/options.py 
 80fabb93945f38011b1e9c64ed20f8035ec146fa 
   src/main/python/apache/aurora/client/options.py 
 af56351eed21805f09bfe50cb91745d58b665627 
   src/test/python/apache/aurora/client/cli/test_kill.py 
 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
   src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
   src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/16423/diff/
 
 
 Testing
 ---
 
 Added new unit tests for diff; inspect doesn't do any API calls that aren't 
 already tested.
 
 
 Thanks,
 
 Mark Chu-Carroll
 




Re: Review Request 16423: client v2: added implementations of job diff, job inspect.

2014-01-13 Thread Jonathan Boulle

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/#review31650
---



src/main/python/apache/aurora/client/cli/__init__.py
https://reviews.apache.org/r/16423/#comment60331

kill



src/main/python/apache/aurora/client/cli/context.py
https://reviews.apache.org/r/16423/#comment60334

s/file/file./



src/main/python/apache/aurora/client/cli/context.py
https://reviews.apache.org/r/16423/#comment60332

%s/job_key/jobkey/g



src/main/python/apache/aurora/client/cli/context.py
https://reviews.apache.org/r/16423/#comment60333

result.extend(...)



src/main/python/apache/aurora/client/cli/context.py
https://reviews.apache.org/r/16423/#comment60335

kill



src/main/python/apache/aurora/client/cli/context.py
https://reviews.apache.org/r/16423/#comment60336

return resp or []



src/main/python/apache/aurora/client/cli/jobs.py
https://reviews.apache.org/r/16423/#comment60341

no help()?



src/main/python/apache/aurora/client/cli/jobs.py
https://reviews.apache.org/r/16423/#comment60340

no help()? 



src/main/python/apache/aurora/client/cli/jobs.py
https://reviews.apache.org/r/16423/#comment60339

could this just live on the class?



src/main/python/apache/aurora/client/cli/jobs.py
https://reviews.apache.org/r/16423/#comment60338

s/specifying/setting/



src/test/python/apache/aurora/client/cli/util.py
https://reviews.apache.org/r/16423/#comment60344

hm, remove?



src/test/python/twitter/aurora/client/cli/BUILD
https://reviews.apache.org/r/16423/#comment60342

:/



src/test/python/twitter/aurora/client/cli/test_diff.py
https://reviews.apache.org/r/16423/#comment60343

nit: could we use a more generic username for all the tests?


- Jonathan Boulle


On Jan. 13, 2014, 3:02 p.m., Mark Chu-Carroll wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/16423/
 ---
 
 (Updated Jan. 13, 2014, 3:02 p.m.)
 
 
 Review request for Aurora, Jonathan Boulle and Brian Wickman.
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Implemented client v2 versions of the diff and inspect verbs.
 
 
 Diffs
 -
 
   src/main/python/apache/aurora/client/cli/__init__.py 
 2c08cf985a3ad9126a544596f895540524af865c 
   src/main/python/apache/aurora/client/cli/context.py 
 c50f1a15847f5374a30d6bc93915123d8471e4aa 
   src/main/python/apache/aurora/client/cli/jobs.py 
 b789361313e279ac8398a92a46ec724c09fb4513 
   src/main/python/apache/aurora/client/cli/options.py 
 80fabb93945f38011b1e9c64ed20f8035ec146fa 
   src/main/python/apache/aurora/client/options.py 
 af56351eed21805f09bfe50cb91745d58b665627 
   src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
   src/test/python/apache/aurora/client/cli/BUILD 
 9528eed70e76431f720c4a26651ae0729903288c 
   src/test/python/apache/aurora/client/cli/test_create.py 
 df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54 
   src/test/python/apache/aurora/client/cli/test_kill.py 
 75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
   src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION 
   src/test/python/apache/aurora/client/cli/util.py 
 c6d38304fb8ac89b9a175d8c20438a8831f784df 
   src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
   src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/16423/diff/
 
 
 Testing
 ---
 
 Added new unit tests for diff; inspect doesn't do any API calls that aren't 
 already tested.
 
 
 Thanks,
 
 Mark Chu-Carroll
 




Re: Review Request 16423: client v2: added implementations of job diff, job inspect.

2014-01-13 Thread Mark Chu-Carroll

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16423/
---

(Updated Jan. 13, 2014, 5:28 p.m.)


Review request for Aurora, Jonathan Boulle and Brian Wickman.


Changes
---

Addressed latest round of reviews.


Repository: aurora


Description
---

Implemented client v2 versions of the diff and inspect verbs.


Diffs (updated)
-

  src/main/python/apache/aurora/client/cli/__init__.py 
2c08cf985a3ad9126a544596f895540524af865c 
  src/main/python/apache/aurora/client/cli/context.py 
c50f1a15847f5374a30d6bc93915123d8471e4aa 
  src/main/python/apache/aurora/client/cli/jobs.py 
b789361313e279ac8398a92a46ec724c09fb4513 
  src/main/python/apache/aurora/client/cli/options.py 
80fabb93945f38011b1e9c64ed20f8035ec146fa 
  src/main/python/apache/aurora/client/options.py 
af56351eed21805f09bfe50cb91745d58b665627 
  src/main/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
  src/test/python/apache/aurora/client/cli/BUILD 
9528eed70e76431f720c4a26651ae0729903288c 
  src/test/python/apache/aurora/client/cli/test_create.py 
df2386d3e1372d5dc3eb55f8e3a0f471a9b3ab54 
  src/test/python/apache/aurora/client/cli/test_kill.py 
75fb6b6a66ce018015073fc0ee04bf6e9a5c0773 
  src/test/python/apache/aurora/client/cli/test_status.py PRE-CREATION 
  src/test/python/apache/aurora/client/cli/util.py 
c6d38304fb8ac89b9a175d8c20438a8831f784df 
  src/test/python/twitter/aurora/client/cli/BUILD PRE-CREATION 
  src/test/python/twitter/aurora/client/cli/test_diff.py PRE-CREATION 

Diff: https://reviews.apache.org/r/16423/diff/


Testing
---

Added new unit tests for diff; inspect doesn't do any API calls that aren't 
already tested.


Thanks,

Mark Chu-Carroll