Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/ --- (Updated Jan. 29, 2014, 12:09 a.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Bill Farner
> On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/state/SideEffect.java, line 77 > > > > > > Should these be javadoc comments instead? Good call, done. - Bill ---

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Bill Farner
> On Jan. 28, 2014, 9:50 p.m., Kevin Sweeney wrote: > > src/main/java/org/apache/aurora/scheduler/state/StateManagerImpl.java, > > lines 543-546 > > > > > > This seems like a big enough gotcha to warrant filing a tick

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Bill Farner
> On Jan. 22, 2014, 8:43 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/state/SideEffect.java, line 42 > > > > > > Missing comments for public methods in this class? We typically don't bot

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review32551 --- Ship it! src/main/java/org/apache/aurora/scheduler/state/StateMana

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-28 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review33054 --- Kevin — ping? Presumably you can review while i fix up Maxim's non-

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-22 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review32511 --- Ship it! Minor comments below. src/main/java/org/apache/aurora/sc

Re: Review Request 16873: Refactor StateManagerImpl and TaskStateMachine for less code and better readability.

2014-01-22 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16873/#review32502 --- Ping - Bill Farner On Jan. 14, 2014, 11:27 p.m., Bill Farner wrot