Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/#review32377 --- ping? - Mark Chu-Carroll On Jan. 17, 2014, 3:05 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/ --- (Updated Jan. 17, 2014, 3:05 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-53 https://issues.apache.org/jira/browse/aurora-53 Repository: aurora Description --- Add clientv2 implementations of update and list jobs. (This was originally planned to also include cancel_update and restart, but after testing problems led to splitting out AURORA-42, and merges with restart failed, I decided to submit these two, and put the others in a subsequent change.) Diffs - src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933 src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157 src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4 src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49 src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0 src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457 src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5 src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737 src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084 src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456 src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35 src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll
Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/#review32430 --- src/main/python/apache/aurora/client/cli/jobs.py https://reviews.apache.org/r/17051/#comment61257 line 58 of context.py still raises CommandError ?? - Jonathan Boulle On Jan. 17, 2014, 8:05 p.m., Mark Chu-Carroll wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/ --- (Updated Jan. 17, 2014, 8:05 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Bugs: aurora-53 https://issues.apache.org/jira/browse/aurora-53 Repository: aurora Description --- Add clientv2 implementations of update and list jobs. (This was originally planned to also include cancel_update and restart, but after testing problems led to splitting out AURORA-42, and merges with restart failed, I decided to submit these two, and put the others in a subsequent change.) Diffs - src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933 src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157 src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4 src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49 src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0 src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457 src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5 src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737 src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084 src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456 src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35 src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll
Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/ --- (Updated Jan. 17, 2014, 1:58 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Changes --- Address wickman's review comments. Bugs: aurora-53 https://issues.apache.org/jira/browse/aurora-53 Repository: aurora Description --- Add clientv2 implementations of update and list jobs. (This was originally planned to also include cancel_update and restart, but after testing problems led to splitting out AURORA-42, and merges with restart failed, I decided to submit these two, and put the others in a subsequent change.) Diffs (updated) - src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49 src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll
Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/ --- (Updated Jan. 17, 2014, 2:11 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Changes --- grumble, I screwed up my git commands; this should be the correct diff. Bugs: aurora-53 https://issues.apache.org/jira/browse/aurora-53 Repository: aurora Description --- Add clientv2 implementations of update and list jobs. (This was originally planned to also include cancel_update and restart, but after testing problems led to splitting out AURORA-42, and merges with restart failed, I decided to submit these two, and put the others in a subsequent change.) Diffs (updated) - src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49 src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll
Re: Review Request 17051: Add clientv2 implementations of update and list jobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17051/ --- (Updated Jan. 17, 2014, 3:05 p.m.) Review request for Aurora, Jonathan Boulle and Brian Wickman. Changes --- address jonboulle's review comments. Bugs: aurora-53 https://issues.apache.org/jira/browse/aurora-53 Repository: aurora Description --- Add clientv2 implementations of update and list jobs. (This was originally planned to also include cancel_update and restart, but after testing problems led to splitting out AURORA-42, and merges with restart failed, I decided to submit these two, and put the others in a subsequent change.) Diffs (updated) - src/main/python/apache/aurora/client/api/__init__.py 0fdf1f99feb24445735ce3783578d1aa1cb0f933 src/main/python/apache/aurora/client/api/job_monitor.py f444d1edb52e3763310460dd5737e0a63d005157 src/main/python/apache/aurora/client/api/scheduler_client.py fb65aee66c42969a719c5c0a1eb868dbf6b16ac4 src/main/python/apache/aurora/client/cli/context.py be156bb52dd48e8e5a0df3ddfb0aef1a815d538e src/main/python/apache/aurora/client/cli/jobs.py c519e3c1a4dc055ae1a77d29ca5ba2e6464cacf0 src/main/python/apache/aurora/client/cli/options.py 0aaf8801950b18be2f00fb1a1f9d8a5a853a1c42 src/main/python/apache/aurora/client/commands/core.py edc57b20f37e6c3d4f13b357b922b9b69091050d src/test/python/apache/aurora/client/api/test_job_monitor.py 9327b32c746d0ff3bd58c900d38bd804331937cf src/test/python/apache/aurora/client/cli/BUILD 97b074488c569c1c92e2bfd69f09ffbd3a827d49 src/test/python/apache/aurora/client/cli/test_create.py 2b0c504e439db777067f02a085e833ac42a1ebc0 src/test/python/apache/aurora/client/cli/test_diff.py b8997e2215585631b8a4b3ddccf38dca7c44464c src/test/python/apache/aurora/client/cli/test_kill.py 66d729dc0cdff71a8f8496c528d6fb71dbdb5457 src/test/python/apache/aurora/client/cli/test_status.py f4ca0d0c824cb7d20585f609a2f5f259f36a3ca0 src/test/python/apache/aurora/client/cli/test_update.py PRE-CREATION src/test/python/apache/aurora/client/cli/util.py 2985865264a7fd9dd8f59182a4df9e335e210f84 src/test/python/apache/aurora/client/commands/test_cancel_update.py b1d63cc75f2d6407e3960d6cf254d5fd832f96c5 src/test/python/apache/aurora/client/commands/test_create.py 57a6dc8fe94282db455f37e7918c63ba14c5d737 src/test/python/apache/aurora/client/commands/test_diff.py a0421530b272a6a0bc03d5f4fc23fad4881c756b src/test/python/apache/aurora/client/commands/test_kill.py edca5dc039fe9a8411d9f83bc6e6e8e3360a1084 src/test/python/apache/aurora/client/commands/test_listjobs.py 16973d4281298f89ceb0ec3fb57efaae83933456 src/test/python/apache/aurora/client/commands/test_restart.py 77a24e8143e84b32b47d6018f79f8d949668be35 src/test/python/apache/aurora/client/commands/test_run.py 0a6aaf8c951e6bdb4dddcda4d1bb0589276238ef src/test/python/apache/aurora/client/commands/test_ssh.py 64dc896a6fbee8c4fe282c61aa1d8b4f236676fd src/test/python/apache/aurora/client/commands/test_status.py 9241631a8f35c82b0d0940c69569431b6c8a43da src/test/python/apache/aurora/client/commands/test_update.py de6039be73edec030890cb8ebca9c99b28acb4fc src/test/python/apache/aurora/client/commands/util.py 22694a29d277b3693a429793a0fc7c0ca2552260 Diff: https://reviews.apache.org/r/17051/diff/ Testing --- Unit tests all pass; new tests added for the new update command. Thanks, Mark Chu-Carroll
