Re: Review Request 17056: fix dependencies for setup_py
On March 21, 2014, 3:07 p.m., Bill Farner wrote: Update or discard? Ping? - Bill --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review38108 --- On Jan. 17, 2014, 6:37 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/ --- (Updated Jan. 17, 2014, 6:37 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- When testing the updated pants setup_py, I noticed that some extra junk was being added to the apache.aurora.common sdist (the generated thrift code from apache.gen.aurora.) This fixes those dependencies. Diffs - src/main/python/apache/aurora/client/BUILD a603ee5d171c828700a9ac6836afb22a03638eff src/main/python/apache/aurora/common/BUILD ae0f40741dbe0a2156c1cf7534f5b2e48ca2bb65 src/main/python/apache/thermos/core/BUILD d5734b11ae59757611483401ab40495c60e12f11 Diff: https://reviews.apache.org/r/17056/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 17056: fix dependencies for setup_py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review38378 --- crap, i missed this. will merge/repost/submit. - Brian Wickman On Jan. 17, 2014, 6:37 p.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/ --- (Updated Jan. 17, 2014, 6:37 p.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- When testing the updated pants setup_py, I noticed that some extra junk was being added to the apache.aurora.common sdist (the generated thrift code from apache.gen.aurora.) This fixes those dependencies. Diffs - src/main/python/apache/aurora/client/BUILD a603ee5d171c828700a9ac6836afb22a03638eff src/main/python/apache/aurora/common/BUILD ae0f40741dbe0a2156c1cf7534f5b2e48ca2bb65 src/main/python/apache/thermos/core/BUILD d5734b11ae59757611483401ab40495c60e12f11 Diff: https://reviews.apache.org/r/17056/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 17056: fix dependencies for setup_py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/ --- (Updated March 24, 2014, 10:16 p.m.) Review request for Aurora and Kevin Sweeney. Changes --- merged master Repository: aurora Description --- When testing the updated pants setup_py, I noticed that some extra junk was being added to the apache.aurora.common sdist (the generated thrift code from apache.gen.aurora.) This fixes those dependencies. Diffs (updated) - src/main/python/apache/aurora/client/BUILD fafd055d8c51c24c8ded56f4316b7f6ddd96ac28 src/main/python/apache/aurora/common/BUILD ce73f93b37d96c5667a6b9bef66b8e7521f0cd83 src/main/python/apache/thermos/core/BUILD 6da1a61f328edaa0eed2fe02c8c5bdcdbda751c3 Diff: https://reviews.apache.org/r/17056/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 17056: fix dependencies for setup_py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review33840 --- Did this ever land? - Kevin Sweeney On Jan. 17, 2014, 10:37 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/ --- (Updated Jan. 17, 2014, 10:37 a.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- When testing the updated pants setup_py, I noticed that some extra junk was being added to the apache.aurora.common sdist (the generated thrift code from apache.gen.aurora.) This fixes those dependencies. Diffs - src/main/python/apache/aurora/client/BUILD a603ee5d171c828700a9ac6836afb22a03638eff src/main/python/apache/aurora/common/BUILD ae0f40741dbe0a2156c1cf7534f5b2e48ca2bb65 src/main/python/apache/thermos/core/BUILD d5734b11ae59757611483401ab40495c60e12f11 Diff: https://reviews.apache.org/r/17056/diff/ Testing --- Thanks, Brian Wickman
Re: Review Request 17056: fix dependencies for setup_py
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/#review33495 --- src/main/python/apache/aurora/client/BUILD https://reviews.apache.org/r/17056/#comment62959 I'm unclear on the convention being followed for -packaged dependencies. Wouldn't this be automatic if src/main/python/apache/aurora/config has a provides statement? - Kevin Sweeney On Jan. 17, 2014, 10:37 a.m., Brian Wickman wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17056/ --- (Updated Jan. 17, 2014, 10:37 a.m.) Review request for Aurora and Kevin Sweeney. Repository: aurora Description --- When testing the updated pants setup_py, I noticed that some extra junk was being added to the apache.aurora.common sdist (the generated thrift code from apache.gen.aurora.) This fixes those dependencies. Diffs - src/main/python/apache/aurora/client/BUILD a603ee5d171c828700a9ac6836afb22a03638eff src/main/python/apache/aurora/common/BUILD ae0f40741dbe0a2156c1cf7534f5b2e48ca2bb65 src/main/python/apache/thermos/core/BUILD d5734b11ae59757611483401ab40495c60e12f11 Diff: https://reviews.apache.org/r/17056/diff/ Testing --- Thanks, Brian Wickman
