Re: Review Request 17562: Added cluster name to page title.

2014-03-06 Thread Suman Karumuri
On Feb. 25, 2014, 8:10 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/http/SchedulerzJob.java, line 195 https://reviews.apache.org/r/17562/diff/6/?file=503050#file503050line195 doc here has drifted, please being it back in check Done. On Feb. 25, 2014, 8:10

Re: Review Request 17562: Added cluster name to page title.

2014-03-06 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated March 6, 2014, 11:43 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 17562: Added cluster name to page title.

2014-02-25 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/#review35447 --- Ship it!

Re: Review Request 17562: Added cluster name to page title.

2014-02-24 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated Feb. 25, 2014, 1:22 a.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 17562: Added cluster name to page title.

2014-02-20 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated Feb. 20, 2014, 9:53 p.m.) Review request for Aurora, Kevin Sweeney

Re: Review Request 17562: Added cluster name to page title.

2014-02-20 Thread Suman Karumuri
On Feb. 4, 2014, 8:52 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java, line 231 https://reviews.apache.org/r/17562/diff/3/?file=464021#file464021line231 Please revert. This is an anti-pattern, as tests can no longer alter

Re: Review Request 17562: Added cluster name to page title.

2014-02-04 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/ --- (Updated Feb. 4, 2014, 8:15 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17562: Added cluster name to page title.

2014-02-03 Thread Kevin Sweeney
On Jan. 30, 2014, 4:56 p.m., Kevin Sweeney wrote: Suman Karumuri wrote: Spoke to Bill before making these changes. We decided to use getInfo API and deprecate getAPIVersion. The getInfo will return with the clusterName and APIVersion for now. In future it may include other

Re: Review Request 17562: Added cluster name to page title.

2014-01-30 Thread Kevin Sweeney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17562/#review33266 ---

Re: Review Request 17562: Added cluster name to page title.

2014-01-30 Thread Suman Karumuri
On Jan. 31, 2014, 12:56 a.m., Kevin Sweeney wrote: Spoke to Bill before making these changes. We decided to use getInfo API and deprecate getAPIVersion. The getInfo will return with the clusterName and APIVersion for now. In future it may include other attributes and hence the flexible