Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.

2014-02-06 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17729/#review33844
---



src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
https://reviews.apache.org/r/17729/#comment63461

Done.


- Maxim Khutornenko


On Feb. 5, 2014, 1:59 a.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/17729/
 ---
 
 (Updated Feb. 5, 2014, 1:59 a.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-192
 https://issues.apache.org/jira/browse/AURORA-192
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Removing JobConfigValidation from populateJobConfig RPC to finalize migration 
 to client quota checks.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
 15ff590ecebe8d87ba66a55ed176fb22122b354a 
   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
 8ad24f9762854fa8f1ed19dfd95ca4a50640cbf3 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  479c2d9b3ee522d7feb125f5dea0973abb5b18b6 
   src/main/python/apache/aurora/client/api/__init__.py 
 fbdf2b3f98d1b96da72dee98bc0b74ec1b79e243 
   src/main/python/apache/aurora/client/api/updater.py 
 61e5737cc3cb4d457348cbc1df1f0fc93143de51 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 77cd09ec91afc98910a867c2632c790a8e0a72ce 
   
 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
  79f09cd856be28f227fc76fb5a8e3298fb785a3a 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  02b7a27e0a9ec5226d9d043de8bf4739fb151b09 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 62fc8045f6a5fda234df73452685bd04e3142aaf 
   src/test/python/apache/aurora/client/api/test_updater.py 
 eabb938ead5b3bab067339ae085dbe2fd262d6a7 
   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
 10fcf08f87abb8a0e3d2750237b482ebdd3ac65d 
 
 Diff: https://reviews.apache.org/r/17729/diff/
 
 
 Testing
 ---
 
 gradle clean build
 ./pants src/test/python/apache/aurora:all
 
 aurora_client diff/update in vagrant with/without JobConfigValidation in 
 api.thrift
 
 
 Thanks,
 
 Maxim Khutornenko
 




Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.

2014-02-06 Thread Maxim Khutornenko

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17729/
---

(Updated Feb. 6, 2014, 9:22 p.m.)


Review request for Aurora, Kevin Sweeney and Bill Farner.


Changes
---

CR comments.


Bugs: AURORA-192
https://issues.apache.org/jira/browse/AURORA-192


Repository: aurora


Description
---

Removing JobConfigValidation from populateJobConfig RPC to finalize migration 
to client quota checks.


Diffs (updated)
-

  src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
15ff590ecebe8d87ba66a55ed176fb22122b354a 
  src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
8ad24f9762854fa8f1ed19dfd95ca4a50640cbf3 
  
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 
479c2d9b3ee522d7feb125f5dea0973abb5b18b6 
  src/main/python/apache/aurora/client/api/__init__.py 
fbdf2b3f98d1b96da72dee98bc0b74ec1b79e243 
  src/main/python/apache/aurora/client/api/updater.py 
61e5737cc3cb4d457348cbc1df1f0fc93143de51 
  src/main/thrift/org/apache/aurora/gen/api.thrift 
77cd09ec91afc98910a867c2632c790a8e0a72ce 
  
src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java 
79f09cd856be28f227fc76fb5a8e3298fb785a3a 
  
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
 02b7a27e0a9ec5226d9d043de8bf4739fb151b09 
  src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
62fc8045f6a5fda234df73452685bd04e3142aaf 
  src/test/python/apache/aurora/client/api/test_updater.py 
eabb938ead5b3bab067339ae085dbe2fd262d6a7 
  src/test/resources/org/apache/aurora/gen/api.thrift.md5 
10fcf08f87abb8a0e3d2750237b482ebdd3ac65d 

Diff: https://reviews.apache.org/r/17729/diff/


Testing
---

gradle clean build
./pants src/test/python/apache/aurora:all

aurora_client diff/update in vagrant with/without JobConfigValidation in 
api.thrift


Thanks,

Maxim Khutornenko



Re: Review Request 17729: Removing quota checks from populateJobConfig RPC.

2014-02-05 Thread Kevin Sweeney

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17729/#review33742
---

Ship it!


Ship It!

- Kevin Sweeney


On Feb. 4, 2014, 5:59 p.m., Maxim Khutornenko wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/17729/
 ---
 
 (Updated Feb. 4, 2014, 5:59 p.m.)
 
 
 Review request for Aurora, Kevin Sweeney and Bill Farner.
 
 
 Bugs: AURORA-192
 https://issues.apache.org/jira/browse/AURORA-192
 
 
 Repository: aurora
 
 
 Description
 ---
 
 Removing JobConfigValidation from populateJobConfig RPC to finalize migration 
 to client quota checks.
 
 
 Diffs
 -
 
   src/main/java/org/apache/aurora/scheduler/state/SchedulerCore.java 
 15ff590ecebe8d87ba66a55ed176fb22122b354a 
   src/main/java/org/apache/aurora/scheduler/state/SchedulerCoreImpl.java 
 8ad24f9762854fa8f1ed19dfd95ca4a50640cbf3 
   
 src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
  479c2d9b3ee522d7feb125f5dea0973abb5b18b6 
   src/main/python/apache/aurora/client/api/__init__.py 
 fbdf2b3f98d1b96da72dee98bc0b74ec1b79e243 
   src/main/python/apache/aurora/client/api/updater.py 
 61e5737cc3cb4d457348cbc1df1f0fc93143de51 
   src/main/thrift/org/apache/aurora/gen/api.thrift 
 77cd09ec91afc98910a867c2632c790a8e0a72ce 
   
 src/test/java/org/apache/aurora/scheduler/state/BaseSchedulerCoreImplTest.java
  79f09cd856be28f227fc76fb5a8e3298fb785a3a 
   
 src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java
  02b7a27e0a9ec5226d9d043de8bf4739fb151b09 
   src/test/java/org/apache/aurora/scheduler/thrift/aop/ForwardingThrift.java 
 62fc8045f6a5fda234df73452685bd04e3142aaf 
   src/test/python/apache/aurora/client/api/test_updater.py 
 eabb938ead5b3bab067339ae085dbe2fd262d6a7 
   src/test/resources/org/apache/aurora/gen/api.thrift.md5 
 10fcf08f87abb8a0e3d2750237b482ebdd3ac65d 
 
 Diff: https://reviews.apache.org/r/17729/diff/
 
 
 Testing
 ---
 
 gradle clean build
 ./pants src/test/python/apache/aurora:all
 
 aurora_client diff/update in vagrant with/without JobConfigValidation in 
 api.thrift
 
 
 Thanks,
 
 Maxim Khutornenko