Re: Review Request 17730: Now sorting roles before displaying them on home page.

2014-02-06 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17730/ --- (Updated Feb. 6, 2014, 7:32 p.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17730: Now sorting roles before displaying them on home page.

2014-02-06 Thread Suman Karumuri
> On Feb. 5, 2014, 8:28 p.m., Bill Farner wrote: > > src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js, > > line 25 > > > > > > JavaScript ignoramus here, but have you considered localeCompare()

Re: Review Request 17730: Now sorting roles before displaying them on home page.

2014-02-05 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17730/#review33719 --- Ship it! src/main/resources/org/apache/aurora/scheduler/http/ui/js

Re: Review Request 17730: Now sorting roles before displaying them on home page.

2014-02-05 Thread Bill Farner
> On Feb. 5, 2014, 1:45 a.m., Bill Farner wrote: > > The approach here differs from (what appears to be) the smart-table > > documentation [1]. Did you find that approach to be unusable? > > > > [1] http://lorenzofox3.github.io/smart-table-website/ > > Suman Karumuri wrote: > Do you mean

Re: Review Request 17730: Now sorting roles before displaying them on home page.

2014-02-04 Thread Suman Karumuri
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17730/ --- (Updated Feb. 5, 2014, 7:14 a.m.) Review request for Aurora, Kevin Sweeney and

Re: Review Request 17730: Now sorting roles before displaying them on home page.

2014-02-04 Thread Suman Karumuri
> On Feb. 5, 2014, 1:45 a.m., Bill Farner wrote: > > The approach here differs from (what appears to be) the smart-table > > documentation [1]. Did you find that approach to be unusable? > > > > [1] http://lorenzofox3.github.io/smart-table-website/ Do you mean sortPredicate described there? I

Re: Review Request 17730: Now sorting roles before displaying them on home page.

2014-02-04 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17730/#review33671 --- The approach here differs from (what appears to be) the smart-table