On Feb. 6, 2014, 5:23 a.m., Jake Farrell wrote:
The new patch does not modify the gradle-license-plugin sourceSet as
intended, it ends up using the default of sourceSet.all in the plugin which
grabs all resources, dist, and 3rdparty dirs. Digging into the code the
license plugin extends SourceTask, which has the setSource function to
replace all sourceSets within the SourceTask, leveraging this for any
License task type we can set the paths we want to use and this fixes the
issue.
testing done: rm -rf .gradle ./gradlew clean build
Changes needed to make are:
tasks.withType(nl.javadude.gradle.plugins.license.License).each {
licenseTask -
licenseTask.setSource files($projectDir/src/main/java,
$projectDir/src/test/java)
}
license {
header rootProject.file('config/checkstyle/apache.header')
strictCheck true
skipExistingHeaders true
ext.year = Calendar.getInstance().get(Calendar.YEAR)
}
new review submitted with these updates: https://reviews.apache.org/r/18316/
- Jake
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17771/#review33762
---
On Feb. 6, 2014, 1:55 a.m., Kevin Sweeney wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17771/
---
(Updated Feb. 6, 2014, 1:55 a.m.)
Review request for Aurora, Jake Farrell and Maxim Khutornenko.
Bugs: AURORA-193
https://issues.apache.org/jira/browse/AURORA-193
Repository: aurora
Description
---
Copy sourceSets instead of mutating it.
Diffs
-
build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d
Diff: https://reviews.apache.org/r/17771/diff/
Testing
---
./gradlew clean build
Thanks,
Kevin Sweeney
