Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution
> On March 21, 2014, 2:52 p.m., Bill Farner wrote: > > Jake - do you agree with discarding this in favor of > > https://reviews.apache.org/r/17750/? Was waiting on Kevin to commit that and then was going to rebase the other changes that I did for this against his https://reviews.apache.org/r/17750 - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review38101 --- On Feb. 7, 2014, 1:45 a.m., Jake Farrell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17818/ > --- > > (Updated Feb. 7, 2014, 1:45 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-145 > https://issues.apache.org/jira/browse/AURORA-145 > > > Repository: aurora > > > Description > --- > > AURORA-145:Test dependencies leak into distribution > > First part of Aurora-145 which makes easy mock and zookeeper testing > part of the test compile only. Part two will be to look at 3rd party > dependencies and see what we can do to make the dist smaller. > > > Diffs > - > > build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d > src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java > > src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java > 041d1f9937672df64864be09bbc4fd2a38b9b1ab > > src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 6cfaf39ee41862d088ab9747b7820da3f5014a0c > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > f708ab3c2fa5d50b084e037f9cc0cb998935120a > > Diff: https://reviews.apache.org/r/17818/diff/ > > > Testing > --- > > ran all unit tests with no failures > > > Thanks, > > Jake Farrell > >
Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review38101 --- Jake - do you agree with discarding this in favor of https://reviews.apache.org/r/17750/? - Bill Farner On Feb. 7, 2014, 1:45 a.m., Jake Farrell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17818/ > --- > > (Updated Feb. 7, 2014, 1:45 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-145 > https://issues.apache.org/jira/browse/AURORA-145 > > > Repository: aurora > > > Description > --- > > AURORA-145:Test dependencies leak into distribution > > First part of Aurora-145 which makes easy mock and zookeeper testing > part of the test compile only. Part two will be to look at 3rd party > dependencies and see what we can do to make the dist smaller. > > > Diffs > - > > build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d > src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java > > src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java > 041d1f9937672df64864be09bbc4fd2a38b9b1ab > > src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 6cfaf39ee41862d088ab9747b7820da3f5014a0c > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > f708ab3c2fa5d50b084e037f9cc0cb998935120a > > Diff: https://reviews.apache.org/r/17818/diff/ > > > Testing > --- > > ran all unit tests with no failures > > > Thanks, > > Jake Farrell > >
Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review34224 --- The move into src/test is still a no-go AFAICT, since we currently expect AbstractCronIT to be published for external consumption. My personal preference is to nuke AbstractCronIT with https://reviews.apache.org/r/17750, obviating the need for this reshuffling. - Bill Farner On Feb. 7, 2014, 1:45 a.m., Jake Farrell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17818/ > --- > > (Updated Feb. 7, 2014, 1:45 a.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-145 > https://issues.apache.org/jira/browse/AURORA-145 > > > Repository: aurora > > > Description > --- > > AURORA-145:Test dependencies leak into distribution > > First part of Aurora-145 which makes easy mock and zookeeper testing > part of the test compile only. Part two will be to look at 3rd party > dependencies and see what we can do to make the dist smaller. > > > Diffs > - > > build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d > src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java > > src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java > 041d1f9937672df64864be09bbc4fd2a38b9b1ab > > src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 6cfaf39ee41862d088ab9747b7820da3f5014a0c > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > f708ab3c2fa5d50b084e037f9cc0cb998935120a > > Diff: https://reviews.apache.org/r/17818/diff/ > > > Testing > --- > > ran all unit tests with no failures > > > Thanks, > > Jake Farrell > >
Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/ --- (Updated Feb. 7, 2014, 1:45 a.m.) Review request for Aurora, Kevin Sweeney and Bill Farner. Changes --- Adds back AbstractCronIT and moves it to src/test. patch redone against trunk and passes all test cases Bugs: AURORA-145 https://issues.apache.org/jira/browse/AURORA-145 Repository: aurora Description --- AURORA-145:Test dependencies leak into distribution First part of Aurora-145 which makes easy mock and zookeeper testing part of the test compile only. Part two will be to look at 3rd party dependencies and see what we can do to make the dist smaller. Diffs (updated) - build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java 041d1f9937672df64864be09bbc4fd2a38b9b1ab src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 6cfaf39ee41862d088ab9747b7820da3f5014a0c src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java f708ab3c2fa5d50b084e037f9cc0cb998935120a Diff: https://reviews.apache.org/r/17818/diff/ Testing --- ran all unit tests with no failures Thanks, Jake Farrell
Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution
> On Feb. 6, 2014, 9:53 p.m., Kevin Sweeney wrote: > > No ship. AbstractCronIT is used by QuartzCronIT in > > https://reviews.apache.org/r/17750/ > > > > Merging AbstractCronIT and QuartzCronIT is on the list of followup TODOs > > for that review, so this will be mitigated then. AbstractCronIT depends on com.twitter.common.testing.easymock.EasyMockTest, will keep it and move to src/test rather than its current location. - Jake --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review33846 --- On Feb. 6, 2014, 8:57 p.m., Jake Farrell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17818/ > --- > > (Updated Feb. 6, 2014, 8:57 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-145 > https://issues.apache.org/jira/browse/AURORA-145 > > > Repository: aurora > > > Description > --- > > AURORA-145:Test dependencies leak into distribution > > First part of Aurora-145 which makes easy mock and zookeeper testing > part of the test compile only. Part two will be to look at 3rd party > dependencies and see what we can do to make the dist smaller. > > > Diffs > - > > build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d > src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java > d8c40222809f525ce485a002873f1fe9dedc2748 > > src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java > 041d1f9937672df64864be09bbc4fd2a38b9b1ab > > src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 6cfaf39ee41862d088ab9747b7820da3f5014a0c > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > f708ab3c2fa5d50b084e037f9cc0cb998935120a > > Diff: https://reviews.apache.org/r/17818/diff/ > > > Testing > --- > > ran all unit tests with no failures > > > Thanks, > > Jake Farrell > >
Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review33891 --- I'll be out until Monday - I'll have another look then. - Kevin Sweeney On Feb. 6, 2014, 5:45 p.m., Jake Farrell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17818/ > --- > > (Updated Feb. 6, 2014, 5:45 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-145 > https://issues.apache.org/jira/browse/AURORA-145 > > > Repository: aurora > > > Description > --- > > AURORA-145:Test dependencies leak into distribution > > First part of Aurora-145 which makes easy mock and zookeeper testing > part of the test compile only. Part two will be to look at 3rd party > dependencies and see what we can do to make the dist smaller. > > > Diffs > - > > build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d > src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java > > src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java > 041d1f9937672df64864be09bbc4fd2a38b9b1ab > > src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 6cfaf39ee41862d088ab9747b7820da3f5014a0c > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > f708ab3c2fa5d50b084e037f9cc0cb998935120a > > Diff: https://reviews.apache.org/r/17818/diff/ > > > Testing > --- > > ran all unit tests with no failures > > > Thanks, > > Jake Farrell > >
Re: Review Request 17818: AURORA-145:Test dependencies leak into distribution
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17818/#review33846 --- No ship. AbstractCronIT is used by QuartzCronIT in https://reviews.apache.org/r/17750/ Merging AbstractCronIT and QuartzCronIT is on the list of followup TODOs for that review, so this will be mitigated then. - Kevin Sweeney On Feb. 6, 2014, 12:57 p.m., Jake Farrell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17818/ > --- > > (Updated Feb. 6, 2014, 12:57 p.m.) > > > Review request for Aurora, Kevin Sweeney and Bill Farner. > > > Bugs: AURORA-145 > https://issues.apache.org/jira/browse/AURORA-145 > > > Repository: aurora > > > Description > --- > > AURORA-145:Test dependencies leak into distribution > > First part of Aurora-145 which makes easy mock and zookeeper testing > part of the test compile only. Part two will be to look at 3rd party > dependencies and see what we can do to make the dist smaller. > > > Diffs > - > > build.gradle 4ba72c109b92d05581dbfe78194518653f20e12d > src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java > d8c40222809f525ce485a002873f1fe9dedc2748 > > src/main/java/org/apache/aurora/scheduler/storage/log/testing/LogOpMatcher.java > 041d1f9937672df64864be09bbc4fd2a38b9b1ab > > src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java > > src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java > 6cfaf39ee41862d088ab9747b7820da3f5014a0c > src/test/java/org/apache/aurora/scheduler/storage/log/LogStorageTest.java > f708ab3c2fa5d50b084e037f9cc0cb998935120a > > Diff: https://reviews.apache.org/r/17818/diff/ > > > Testing > --- > > ran all unit tests with no failures > > > Thanks, > > Jake Farrell > >
